Skip to content

Fixes #13689, parameteric colors were sometimes loading wrong cached image#13690

Closed
lukemcgregor wants to merge 1 commit into
mapbox:mainfrom
lukemcgregor:main
Closed

Fixes #13689, parameteric colors were sometimes loading wrong cached image#13690
lukemcgregor wants to merge 1 commit into
mapbox:mainfrom
lukemcgregor:main

Conversation

@lukemcgregor

Copy link
Copy Markdown

This fixes #13689. I fixed this using an LLM so a human who knows the code (@ibesora ?) needs to review and make sure this wont have unintended side effects.
It does however correct this issue:

ezgif com-video-to-gif-converter

@lukemcgregor lukemcgregor requested a review from a team as a code owner June 24, 2026 08:47
@lukemcgregor lukemcgregor requested review from mapboxit and removed request for a team June 24, 2026 08:47
@CLAassistant

CLAassistant commented Jun 24, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

Copy link
Copy Markdown

Hey, @lukemcgregor 👋 Thanks for your contribution to Mapbox GL JS!

Important: This repository does not accept direct merges. All changes go through our internal review process.

What happens next:

  1. A team member will review your PR here first
  2. If it looks good, they will import it to our internal repository for further review
  3. If approved, changes will be synced back here via our release process

Please respond to any review comments on this PR. For more details, see CONTRIBUTING.md.

@stepankuzmin stepankuzmin removed the request for review from mapboxit June 25, 2026 07:53
@ibesora

ibesora commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Hey @lukemcgregor thanks for this!
I verified it correctly fixes the issue you found.
I've imported this PR to our internal repo and I'll close this one here.
I'll comment on the issue you opened once the fix has merged.
Thanks for taking the time to debug this!

@ibesora ibesora closed this Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Color tints in symbol layer change as you zoom, this swaps between the correct color for the symbol and a color from another symbol

3 participants