Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Commit 286bc66

Browse files
committed
Issue #15065 changelogs and nit fix.
1 parent 2c5528e commit 286bc66

4 files changed

Lines changed: 9 additions & 5 deletions

File tree

platform/android/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Mapbox welcomes participation and contributions from everyone. If you'd like to
55
## master
66

77
* Performance improvements for queryRenderedFeatures API and optimization that allocates containers based on a number of rendered layers. ([#14930](https://github.com/mapbox/mapbox-gl-native/pull/14930))
8+
- Fixed rendering layers after fill-extrusion regression caused by optimization of fill-extrusion rendering [#15065](https://github.com/mapbox/mapbox-gl-native/pull/15065)
89

910
## 8.2.0-alpha.2 - July 3, 2019
1011

platform/ios/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT
55
## master
66

77
* Performance improvements for queryRenderedFeatures API and optimization that allocates containers based on a number of rendered layers. ([#14930](https://github.com/mapbox/mapbox-gl-native/pull/14930))
8+
* Fixed rendering layers after fill-extrusion regression caused by optimization of fill-extrusion rendering. ([#15065](https://github.com/mapbox/mapbox-gl-native/pull/15065))
89

910
## 5.2.0
1011

platform/macos/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
* Added an `MGLMapView.prefetchesTiles` property to configure lower-resolution tile prefetching behavior. ([#14816](https://github.com/mapbox/mapbox-gl-native/pull/14816))
66
* Fixed queryRenderedFeatues bug caused by incorrect sort feature index calculation. ([#14884](https://github.com/mapbox/mapbox-gl-native/pull/14884))
77
* Performance improvements for queryRenderedFeatures API and optimization that allocates containers based on a number of rendered layers. ([#14930](https://github.com/mapbox/mapbox-gl-native/pull/14930))
8+
* Fixed rendering layers after fill-extrusion regression caused by optimization of fill-extrusion rendering. ([#15065](https://github.com/mapbox/mapbox-gl-native/pull/15065))
89

910
### Styles and rendering
1011

src/mbgl/renderer/render_orchestrator.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -342,15 +342,16 @@ std::unique_ptr<RenderTree> RenderOrchestrator::createRenderTree(const UpdatePar
342342
}
343343
}
344344

345-
uint32_t i = static_cast<uint32_t>(layerRenderItems.size()) - 1;
346-
for (auto it = layerRenderItems.begin(); it != layerRenderItems.end(); ++it, --i) {
347-
RenderLayer& renderLayer = it->layer;
348-
renderLayer.prepare({it->source, *imageManager, *patternAtlas, *lineAtlas, updateParameters.transformState});
345+
auto opaquePassCutOffEstimation = layerRenderItems.size();
346+
for (auto& renderItem : layerRenderItems) {
347+
RenderLayer& renderLayer = renderItem.layer;
348+
renderLayer.prepare({renderItem.source, *imageManager, *patternAtlas, *lineAtlas, updateParameters.transformState});
349349
if (renderLayer.needsPlacement()) {
350350
layersNeedPlacement.emplace_back(renderLayer);
351351
}
352352
if (renderLayer.is3D() && renderTreeParameters->opaquePassCutOff == 0) {
353-
renderTreeParameters->opaquePassCutOff = i;
353+
--opaquePassCutOffEstimation;
354+
renderTreeParameters->opaquePassCutOff = uint32_t(opaquePassCutOffEstimation);
354355
}
355356
}
356357
// Symbol placement.

0 commit comments

Comments
 (0)