make directions waypoint name nullable as non-null breaks backwards compatibility (#1386)

Author: Pablo Guardiola

services-directions-models/src/main/java/com/mapbox/api/directions/v5/models/DirectionsWaypoint.java

@@ -34,7 +34,7 @@ public static Builder builder() {
    * @return string with the name of the way the coordinate snapped to
    * @since 1.0.0
    */
-  @NonNull
+  @Nullable
   public abstract String name();
 
   /**
@@ -121,7 +121,7 @@ public abstract static class Builder {
      * @since 3.0.0
      */
     @NonNull
-    public abstract Builder name(@NonNull String name);
+    public abstract Builder name(@Nullable String name);
 
     /**
      * The rawLocation as a double array representing a location snapped to the road network.

services-directions-models/src/test/java/com/mapbox/api/directions/v5/models/DirectionsResponseTest.java

@@ -5,7 +5,6 @@
 import com.mapbox.geojson.Point;
 
 import java.io.IOException;
-import java.util.Arrays;
 import java.util.List;
 import org.junit.Assert;
 import org.junit.Test;
@@ -22,6 +21,8 @@ public class DirectionsResponseTest extends TestUtils {
   private static final String DIRECTIONS_V5_MULTIPLE_ROUTES_WITH_OPTIONS =
     "directions_v5_multiple_routes_with_options.json";
   private static final String DIRECTIONS_V5_SILENT_WAYPOINT = "directions_v5_silent_waypoints.json";
+  private static final String DIRECTIONS_WAYPOINTS_WITHOUT_NAMES =
+    "directions_response_waypoints_without_names.json";
 
   @Test
   public void sanity() throws Exception {
@@ -114,7 +115,7 @@ public void fromJson_deserializesOptions() throws Exception {
   }
 
   @Test
-  public void fromJson_deserializeWiaWaypoints() throws IOException {
+  public void fromJson_deserializeViaWaypoints() throws IOException {
     String json = loadJsonFixture(DIRECTIONS_V5_SILENT_WAYPOINT);
 
     DirectionsRoute route = DirectionsResponse.fromJson(json).routes().get(0);
@@ -138,4 +139,14 @@ public void fromToJsonForRouteWithSilentWaypoints() throws IOException {
 
     assertEquals(initial, deserialized);
   }
+
+  @Test
+  public void fromJson_deserializeWaypointsWithoutNames() throws Exception {
+    String json = loadJsonFixture(DIRECTIONS_WAYPOINTS_WITHOUT_NAMES);
+
+    DirectionsResponse response = DirectionsResponse.fromJson(json);
+
+    assertNotNull(response);
+    assertEquals(2, response.routes().size());
+  }
 }