Geocoding Observerable NullPointerException Fix (#52)

* #51 - Using getService() to ensure service object is created
* #51 - Adding Observable test
* #51 - Testing the GeocodingResponse Observable using RxJava's TestSubscriber
* Fix MapboxDirections v4 too

Author: bleege

libjava/lib/src/main/java/com/mapbox/services/directions/v4/MapboxDirections.java

@@ -99,7 +99,7 @@ public Observable<DirectionsResponse> getObservable() {
         // No need to recreate it
         if (observable != null) return observable;
 
-        observable = service.getObservable(
+        observable = getService().getObservable(
                 builder.profile,
                 builder.getWaypoints(),
                 builder.accessToken,

libjava/lib/src/main/java/com/mapbox/services/geocoding/v5/MapboxGeocoding.java

@@ -4,8 +4,8 @@
 import com.mapbox.services.commons.MapboxBuilder;
 import com.mapbox.services.commons.MapboxService;
 import com.mapbox.services.commons.ServicesException;
-import com.mapbox.services.geocoding.v5.models.GeocodingResponse;
 import com.mapbox.services.commons.models.Position;
+import com.mapbox.services.geocoding.v5.models.GeocodingResponse;
 
 import java.io.IOException;
 import java.util.Locale;
@@ -94,7 +94,7 @@ public Observable<GeocodingResponse> getObservable() {
         // No need to recreate it
         if (observable != null) return observable;
 
-        observable = service.getObservable(
+        observable = getService().getObservable(
                 builder.getGeocodingDataset(),
                 builder.getQuery(),
                 builder.getAccessToken(),

libjava/lib/src/test/java/com/mapbox/services/geocoding/v5/MapboxGeocodingTest.java

@@ -23,13 +23,13 @@
 import okhttp3.mockwebserver.MockResponse;
 import okhttp3.mockwebserver.MockWebServer;
 import retrofit2.Response;
+import rx.Observable;
+import rx.observers.TestSubscriber;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
 
-/**
- * Created by antonio on 4/14/16.
- */
 public class MapboxGeocodingTest {
 
     private final static double DELTA = 1E-10;
@@ -143,4 +143,26 @@ public void testContext() throws ServicesException, IOException {
         assertEquals(contexts.get(4).getShortCode(), "us");
     }
 
+    @Test
+    public void testObservable() throws ServicesException, IOException {
+        MapboxGeocoding client = new MapboxGeocoding.Builder()
+                .setAccessToken("pk.XXX")
+                .setLocation("1600 pennsylvania ave nw")
+                .build();
+        client.setBaseUrl(mockUrl.toString());
+        Observable<GeocodingResponse> geocodingResponseObservable = client.getObservable();
+        assertNotNull(geocodingResponseObservable);
+
+        TestSubscriber<GeocodingResponse> testSubscriber = new TestSubscriber<>();
+        geocodingResponseObservable.subscribe(testSubscriber);
+
+        testSubscriber.assertNoErrors();
+        List<GeocodingResponse> responses = testSubscriber.getOnNextEvents();
+        assertNotNull(responses);
+        assertTrue("Geocoding Response Returned", responses.size() > 0);
+        List<FeatureContext> contexts = responses.get(0).getFeatures().get(0).getContext();
+        assertEquals(contexts.get(4).getId(), "country.12862386939497690");
+        assertEquals(contexts.get(4).getText(), "United States");
+        assertEquals(contexts.get(4).getShortCode(), "us");
+    }
 }