Replaces org.apache.commons:commons-lang3 with TextUtils subset (#44)

Author: zugaldia

libjava/lib/build.gradle

@@ -9,9 +9,6 @@ dependencies {
     compile 'com.squareup.retrofit2:converter-gson:2.0.1'
     compile 'com.squareup.retrofit2:adapter-rxjava:2.0.1'
 
-    // Apache commons for StringUtils
-    compile 'org.apache.commons:commons-lang3:3.4'
-
     // Testing
     testCompile 'junit:junit:4.12'
     testCompile 'org.hamcrest:hamcrest-junit:2.0.0.0'

libjava/lib/src/main/java/com/mapbox/services/commons/utils/MapboxUtils.java

@@ -1,7 +1,5 @@
 package com.mapbox.services.commons.utils;
 
-import org.apache.commons.lang3.StringUtils;
-
 /**
  * Misc utils around Mapbox services.
  */
@@ -16,7 +14,7 @@ public class MapboxUtils {
      * @return true if the provided access token is valid, false otherwise.
      */
     public static boolean isAccessTokenValid(String accessToken) {
-        if (StringUtils.isEmpty(accessToken)) return false;
+        if (TextUtils.isEmpty(accessToken)) return false;
         if (!accessToken.startsWith("pk.") && !accessToken.startsWith("sk.")) return false;
         return true;
     }

libjava/lib/src/main/java/com/mapbox/services/commons/utils/TextUtils.java

@@ -0,0 +1,42 @@
+package com.mapbox.services.commons.utils;
+
+/**
+ * Some code from https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/text/TextUtils.java
+ *
+ * We avoid including a full library like org.apache.commons:commons-lang3 to avoid
+ * an unnecessary large number of methods, which is inconvenient to Android devs.
+ */
+public class TextUtils {
+
+    /**
+     * Returns true if the string is null or 0-length.
+     * @param str the string to be examined
+     * @return true if str is null or zero length
+     */
+    public static boolean isEmpty(CharSequence str) {
+        if (str == null || str.length() == 0)
+            return true;
+        else
+            return false;
+    }
+
+    /**
+     * Returns a string containing the tokens joined by delimiters.
+     * @param tokens an array objects to be joined. Strings will be formed from
+     *     the objects by calling object.toString().
+     */
+    public static String join(CharSequence delimiter, Object[] tokens) {
+        StringBuilder sb = new StringBuilder();
+        boolean firstTime = true;
+        for (Object token: tokens) {
+            if (firstTime) {
+                firstTime = false;
+            } else {
+                sb.append(delimiter);
+            }
+            sb.append(token);
+        }
+        return sb.toString();
+    }
+
+}

libjava/lib/src/main/java/com/mapbox/services/directions/v4/MapboxDirections.java

@@ -4,11 +4,10 @@
 import com.mapbox.services.commons.MapboxBuilder;
 import com.mapbox.services.commons.MapboxService;
 import com.mapbox.services.commons.ServicesException;
+import com.mapbox.services.commons.utils.TextUtils;
 import com.mapbox.services.directions.v4.models.DirectionsResponse;
 import com.mapbox.services.directions.v4.models.Waypoint;
 
-import org.apache.commons.lang3.StringUtils;
-
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -266,7 +265,7 @@ public String getWaypoints() {
             }
 
             // The waypoints parameter should be a semicolon-separated list of locations to visit
-            waypointsFormatted = StringUtils.join(pieces, ";");
+            waypointsFormatted = TextUtils.join(";", pieces.toArray());
             return waypointsFormatted;
         }
 

libjava/lib/src/main/java/com/mapbox/services/directions/v5/MapboxDirections.java

@@ -6,10 +6,9 @@
 import com.mapbox.services.commons.ServicesException;
 import com.mapbox.services.commons.models.Bearing;
 import com.mapbox.services.commons.models.Position;
+import com.mapbox.services.commons.utils.TextUtils;
 import com.mapbox.services.directions.v5.models.DirectionsResponse;
 
-import org.apache.commons.lang3.StringUtils;
-
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
@@ -292,7 +291,7 @@ public String getCoordinates() {
                         coordinate.getLatitude()));
             }
 
-            return StringUtils.join(coordinatesFormatted, ";");
+            return TextUtils.join(";", coordinatesFormatted.toArray());
         }
 
         @Override
@@ -324,7 +323,7 @@ public String getBearings() {
                         bearings[i].getRange());
             }
 
-            return StringUtils.join(bearingsFormatted, ";");
+            return TextUtils.join(";", bearingsFormatted);
         }
 
         public String getGeometries() {
@@ -355,7 +354,7 @@ public String getRadiuses() {
                 radiusesFormatted[i] = String.format(Locale.US, "%f", radiuses[i]);
             }
 
-            return StringUtils.join(radiusesFormatted, ";");
+            return TextUtils.join(";", radiusesFormatted);
         }
 
         public Boolean isSteps() {