remove character waypoint names limit from mapbox map matching and mapbox directions (#941)

Author: Guardiola31337

services-directions/src/main/java/com/mapbox/api/directions/v5/MapboxDirections.java

@@ -754,9 +754,6 @@ public MapboxDirections build() {
             + " the number of waypoints provided.");
         }
         final String waypointNamesStr = TextUtils.formatWaypointNames(waypointNames);
-        if (!waypointNamesStr.isEmpty() && waypointNamesStr.length() > 500) {
-          throw new ServicesException("Waypoint names exceed 500 character limit.");
-        }
         waypointNames(waypointNamesStr);
       }
 

services-directions/src/test/java/com/mapbox/api/directions/v5/MapboxDirectionsTest.java

@@ -680,37 +680,6 @@ public void build_exceptionThrownWhenWaypointNamesDoNotMatchCoordinates() throws
       .build();
   }
 
-  @Test
-  public void build_exceptionThrownWhenWaypointNamesExceedLimit() throws Exception {
-    thrown.expect(ServicesException.class);
-    thrown.expectMessage(
-      startsWith("Waypoint names exceed 500 character limit"));
-
-    StringBuilder longWpName = new StringBuilder();
-    for (int i = 0; i < 124; i++) {
-      longWpName.append("Home");
-    }
-    MapboxDirections mapboxDirections = MapboxDirections.builder()
-      .origin(Point.fromLngLat(2.0, 2.0))
-      .destination(Point.fromLngLat(4.0, 4.0))
-      .addWaypointNames(longWpName.toString(), "Work")
-      .baseUrl("https://foobar.com")
-      .accessToken(ACCESS_TOKEN)
-      .build();
-
-    assertTrue(mapboxDirections.cloneCall().request().url().toString()
-      .contains("waypoint_names=Home"));
-
-    // one more char results in exception
-    mapboxDirections = MapboxDirections.builder()
-      .origin(Point.fromLngLat(2.0, 2.0))
-      .destination(Point.fromLngLat(4.0, 4.0))
-      .addWaypointNames(longWpName.toString(), "Work1")
-      .baseUrl("https://foobar.com")
-      .accessToken(ACCESS_TOKEN)
-      .build();
-  }
-
   @Test
   public void testWithWaypointNames() throws Exception {
 

services-matching/src/main/java/com/mapbox/api/matching/v5/MapboxMapMatching.java

@@ -731,9 +731,6 @@ public MapboxMapMatching build() {
             + " the number of waypoints provided.");
         }
         final String waypointNamesStr = TextUtils.formatWaypointNames(waypointNames);
-        if (!waypointNamesStr.isEmpty() && waypointNamesStr.length() > 500) {
-          throw new ServicesException("Waypoint names exceed 500 character limit.");
-        }
         waypointNames(waypointNamesStr);
       }
 

services-matching/src/test/java/com/mapbox/api/matching/v5/MapboxMapMatchingTest.java

@@ -650,39 +650,6 @@ public void build_exceptionThrownWhenWaypointNamesDoNotMatchWaypoints() throws E
       .build();
   }
 
-  @Test
-  public void build_exceptionThrownWhenWaypointNamesExceedLimit() throws Exception {
-    thrown.expect(ServicesException.class);
-    thrown.expectMessage(
-      startsWith("Waypoint names exceed 500 character limit"));
-
-    StringBuilder longWpName = new StringBuilder();
-    for (int i = 0; i < 124; i++) {
-      longWpName.append("Home");
-    }
-    MapboxMapMatching mapMatching = MapboxMapMatching.builder()
-      .baseUrl("https://foobar.com")
-      .accessToken(ACCESS_TOKEN)
-      .coordinate(Point.fromLngLat(2.0, 2.0))
-      .coordinate(Point.fromLngLat(4.0, 4.0))
-      .waypoints(0, 1)
-      .addWaypointNames(longWpName.toString(), "Work")
-      .build();
-
-    assertTrue(mapMatching.cloneCall().request().url().toString()
-      .contains("waypoint_names=Home"));
-
-    // one more char results in exception
-    mapMatching = MapboxMapMatching.builder()
-      .baseUrl("https://foobar.com")
-      .accessToken(ACCESS_TOKEN)
-      .coordinate(Point.fromLngLat(2.0, 2.0))
-      .coordinate(Point.fromLngLat(4.0, 4.0))
-      .waypoints(0, 1)
-      .addWaypointNames(longWpName.toString(), "Work1") // waypoint ar too long
-      .build();
-  }
-
   @Test
   public void testWithWaypointNames() throws Exception {