Skip to content

Commit 5e1cba7

Browse files
JunDaiJUN DAI
authored andcommitted
Update annotation for NonNull attributes. #1087
1 parent baef449 commit 5e1cba7

4 files changed

Lines changed: 9 additions & 7 deletions

File tree

services-directions-models/src/main/java/com/mapbox/api/directions/v5/models/DirectionsRoute.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.mapbox.api.directions.v5.models;
22

3+
import androidx.annotation.NonNull;
34
import androidx.annotation.Nullable;
45

56
import com.google.auto.value.AutoValue;
@@ -46,7 +47,7 @@ public static Builder builder() {
4647
* @return a double number with unit meters
4748
* @since 1.0.0
4849
*/
49-
@Nullable
50+
@NonNull
5051
public abstract Double distance();
5152

5253
/**
@@ -55,7 +56,7 @@ public static Builder builder() {
5556
* @return a double number with unit seconds
5657
* @since 1.0.0
5758
*/
58-
@Nullable
59+
@NonNull
5960
public abstract Double duration();
6061

6162
/**
@@ -173,7 +174,7 @@ public abstract static class Builder {
173174
* @return this builder for chaining options together
174175
* @since 3.0.0
175176
*/
176-
public abstract Builder distance(@Nullable Double distance);
177+
public abstract Builder distance(@NonNull Double distance);
177178

178179
/**
179180
* The estimated travel time from origin to destination.
@@ -182,7 +183,7 @@ public abstract static class Builder {
182183
* @return this builder for chaining options together
183184
* @since 3.0.0
184185
*/
185-
public abstract Builder duration(@Nullable Double duration);
186+
public abstract Builder duration(@NonNull Double duration);
186187

187188
/**
188189
* Gives the geometry of the route. Commonly used to draw the route on the map view.

services-directions-models/src/main/java/com/mapbox/api/directions/v5/models/RouteOptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ public List<String> annotationsList() {
353353
* @since 3.0.0
354354
*/
355355
@SerializedName("uuid")
356-
@Nullable
356+
@NonNull
357357
public abstract String requestUuid();
358358

359359
/**

services-directions-models/src/test/java/com/mapbox/api/directions/v5/models/DirectionsRouteTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,14 @@ public class DirectionsRouteTest extends TestUtils {
1818
public void sanity() throws Exception {
1919
DirectionsRoute route = DirectionsRoute.builder()
2020
.distance(100d)
21+
.duration(100d)
2122
.build();
2223
assertNotNull(route);
2324
}
2425

2526
@Test
2627
public void testSerializable() throws Exception {
27-
DirectionsRoute route = DirectionsRoute.builder().distance(100d).build();
28+
DirectionsRoute route = DirectionsRoute.builder().distance(100d).duration(100d).build();
2829
byte[] serialized = TestUtils.serialize(route);
2930
assertEquals(route, deserialize(serialized, DirectionsRoute.class));
3031
}

0 commit comments

Comments
 (0)