Skip to content

Commit a24ab52

Browse files
committed
match the new geocoding API for position
1 parent e926f13 commit a24ab52

3 files changed

Lines changed: 13 additions & 7 deletions

File tree

libandroid/app/src/main/java/com/mapbox/services/android/testapp/geocoding/GeocodingWidgetActivity.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@ protected void onCreate(Bundle savedInstanceState) {
5050
autocomplete.setOnFeatureListener(new GeocoderAutoCompleteView.OnFeatureListener() {
5151
@Override
5252
public void OnFeatureClick(GeocodingFeature feature) {
53-
updateMap(feature.getLatitude(), feature.getLongitude());
53+
Position position = feature.asPosition();
54+
updateMap(position.getLatitude(), position.getLongitude());
5455
}
5556
});
5657

libandroid/lib/src/main/java/com/mapbox/services/android/geocoder/AndroidGeocoder.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -229,13 +229,14 @@ public List<Address> getFromLocationName(String locationName, int maxResults,
229229
// Find results not contained within the bbox
230230
List<GeocodingFeature> featuresToRemove = new ArrayList<>();
231231
for (GeocodingFeature feature: features) {
232-
if (feature.getLatitude() < lowerLeftLatitude) {
232+
Position featurePosition = feature.asPosition();
233+
if (featurePosition.getLatitude() < lowerLeftLatitude) {
233234
featuresToRemove.add(feature);
234-
} else if (feature.getLatitude() > upperRightLatitude) {
235+
} else if (featurePosition.getLatitude() > upperRightLatitude) {
235236
featuresToRemove.add(feature);
236-
} else if (feature.getLongitude() < lowerLeftLongitude) {
237+
} else if (featurePosition.getLongitude() < lowerLeftLongitude) {
237238
featuresToRemove.add(feature);
238-
} else if (feature.getLongitude() > upperRightLongitude) {
239+
} else if (featurePosition.getLongitude() > upperRightLongitude) {
239240
featuresToRemove.add(feature);
240241
}
241242
}

libandroid/lib/src/main/java/com/mapbox/services/android/geocoder/GeocoderUtils.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import android.location.Address;
44

5+
import com.mapbox.services.commons.models.Position;
56
import com.mapbox.services.geocoding.v5.models.GeocodingFeature;
67

78
import java.util.Locale;
@@ -15,8 +16,11 @@ public static Address featureToAddress(GeocodingFeature geocodingFeature, Locale
1516
Address address = new Address(locale);
1617
address.setAddressLine(0, geocodingFeature.getPlaceName());
1718
address.setFeatureName(geocodingFeature.getText());
18-
address.setLongitude(geocodingFeature.getLongitude());
19-
address.setLatitude(geocodingFeature.getLatitude());
19+
20+
Position position = geocodingFeature.asPosition();
21+
address.setLongitude(position.getLongitude());
22+
address.setLatitude(position.getLatitude());
23+
2024
return address;
2125
}
2226

0 commit comments

Comments
 (0)