Skip to content

Commit a58b53b

Browse files
fix missing device attribute for navigation events (#571)
1 parent a14b1e6 commit a58b53b

4 files changed

Lines changed: 3 additions & 2 deletions

File tree

mapbox/libandroid-telemetry/src/main/java/com/mapbox/services/android/telemetry/MapboxEvent.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ public class MapboxEvent implements Serializable {
3131
public static final String KEY_USER_ID = "userId";
3232
public static final String KEY_ENABLED_TELEMETRY = "enabled.telemetry";
3333
public static final String KEY_MODEL = "model";
34-
public static final String KEY_DEVICE = "device";
3534
public static final String KEY_OPERATING_SYSTEM = "operatingSystem";
3635
public static final String KEY_RESOLUTION = "resolution";
3736
public static final String KEY_ACCESSIBILITY_FONT_SCALE = "accessibilityFontScale";

mapbox/libandroid-telemetry/src/main/java/com/mapbox/services/android/telemetry/MapboxTelemetry.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,7 @@ private boolean isANavigationEvent(String eventType) {
603603
}
604604

605605
private void addGeneralNavigationMetadataTo(Hashtable<String, Object> eventWithAttributes) {
606-
eventWithAttributes.put(MapboxEvent.KEY_DEVICE, Build.MODEL);
606+
eventWithAttributes.put(MapboxNavigationEvent.KEY_DEVICE, Build.MODEL);
607607
eventWithAttributes.put(MapboxNavigationEvent.KEY_VOLUME_LEVEL, TelemetryUtils.getVolumeLevel(context));
608608
eventWithAttributes.put(MapboxNavigationEvent.KEY_SCREEN_BRIGHTNESS, TelemetryUtils.getScreenBrightness(context));
609609
eventWithAttributes.put(MapboxNavigationEvent.KEY_APPLICATION_STATE, TelemetryUtils.getApplicationState(context));

mapbox/libandroid-telemetry/src/main/java/com/mapbox/services/android/telemetry/http/TelemetryClient.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ private void sendEventsWrapped(Vector<Hashtable<String, Object>> events, Callbac
177177
jsonObject.putOpt(MapboxNavigationEvent.KEY_ESTIMATED_DURATION,
178178
evt.get(MapboxNavigationEvent.KEY_ESTIMATED_DURATION));
179179
jsonObject.putOpt(MapboxNavigationEvent.KEY_REROUTE_COUNT, evt.get(MapboxNavigationEvent.KEY_REROUTE_COUNT));
180+
jsonObject.putOpt(MapboxNavigationEvent.KEY_DEVICE, evt.get(MapboxNavigationEvent.KEY_DEVICE));
180181
jsonObject.putOpt(MapboxNavigationEvent.KEY_VOLUME_LEVEL, evt.get(MapboxNavigationEvent.KEY_VOLUME_LEVEL));
181182
jsonObject.putOpt(MapboxNavigationEvent.KEY_SCREEN_BRIGHTNESS,
182183
evt.get(MapboxNavigationEvent.KEY_SCREEN_BRIGHTNESS));

mapbox/libandroid-telemetry/src/main/java/com/mapbox/services/android/telemetry/navigation/MapboxNavigationEvent.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ public class MapboxNavigationEvent {
4747
public static final String KEY_ESTIMATED_DISTANCE = "estimatedDistance";
4848
public static final String KEY_ESTIMATED_DURATION = "estimatedDuration";
4949
public static final String KEY_REROUTE_COUNT = "rerouteCount";
50+
public static final String KEY_DEVICE = "device";
5051
public static final String KEY_VOLUME_LEVEL = "volumeLevel";
5152
public static final String KEY_SCREEN_BRIGHTNESS = "screenBrightness";
5253
public static final String KEY_APPLICATION_STATE = "applicationState";

0 commit comments

Comments
 (0)