Fixed Checkstyle issues and moved GeoJSON to fixtures (#253)

* fixed checkstyle issues and moved geojson to fixtures

* fixed more checkstyle issues

* fixed usage of wrong file

Author: Cameron Mace

checkstyle.xml

@@ -6,8 +6,8 @@
 <module name = "Checker">
     <property name="charset" value="UTF-8"/>
 
-    <!-- <property name="severity" value="error"/> -->
-    <property name="severity" value="warning"/>
+    <property name="severity" value="error"/>
+    <!-- <property name="severity" value="warning"/> -->
 
     <property name="fileExtensions" value="java, properties, xml"/>
     <!-- Checks for whitespace                               -->
@@ -96,24 +96,24 @@
             <message key="name.invalidPattern"
              value="Type name ''{0}'' must match pattern ''{1}''."/>
         </module>
-        <module name="MemberName">
+        <!-- <module name="MemberName">
             <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>
             <message key="name.invalidPattern"
              value="Member name ''{0}'' must match pattern ''{1}''."/>
-        </module>
-        <module name="ParameterName">
+        </module> -->
+        <!-- <module name="ParameterName">
             <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>
             <message key="name.invalidPattern"
              value="Parameter name ''{0}'' must match pattern ''{1}''."/>
-        </module>
+        </module> -->
         <module name="CatchParameterName">
             <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>
             <message key="name.invalidPattern"
              value="Catch parameter name ''{0}'' must match pattern ''{1}''."/>
         </module>
         <module name="LocalVariableName">
             <property name="tokens" value="VARIABLE_DEF"/>
-            <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>
+            <!--<property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>-->
             <property name="allowOneCharVarInForLoop" value="true"/>
             <message key="name.invalidPattern"
              value="Local variable name ''{0}'' must match pattern ''{1}''."/>
@@ -153,12 +153,12 @@
             <property name="arrayInitIndent" value="2"/>
             <!-- <property name="forceStrictCondition" value="true"/> -->
         </module>
-        <module name="AbbreviationAsWordInName">
+        <!-- <module name="AbbreviationAsWordInName">
             <property name="ignoreFinal" value="false"/>
             <property name="allowedAbbreviationLength" value="1"/>
-        </module>
+        </module> -->
         <module name="OverloadMethodsDeclarationOrder"/>
-        <module name="VariableDeclarationUsageDistance"/>
+        <!--<module name="VariableDeclarationUsageDistance"/>-->
         <module name="AvoidStarImport"/>
         <module name="IllegalImport"/> <!-- defaults to sun.* packages -->
         <module name="RedundantImport"/>

mapbox/app/src/androidTest/java/com/mapbox/services/android/testapp/ExampleInstrumentedTest.java

@@ -7,7 +7,7 @@
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertEquals;
 
 /**
  * Instrumentation test, which will execute on an Android device.

mapbox/app/src/main/java/com/mapbox/services/android/testapp/MasApplication.java

@@ -16,12 +16,16 @@ public void onCreate() {
     super.onCreate();
 
     // Leak canary
-    if (LeakCanary.isInAnalyzerProcess(this)) return;
+    if (LeakCanary.isInAnalyzerProcess(this)) {
+      return;
+    }
     LeakCanary.install(this);
 
     // Access token
     String mapboxAccessToken = Utils.getMapboxAccessToken(getApplicationContext());
-    if (TextUtils.isEmpty(mapboxAccessToken)) Log.w(LOG_TAG, "Warning: access token isn't set.");
+    if (TextUtils.isEmpty(mapboxAccessToken)) {
+      Log.w(LOG_TAG, "Warning: access token isn't set.");
+    }
     MapboxAccountManager.start(getApplicationContext(), mapboxAccessToken);
   }
 }

mapbox/app/src/main/java/com/mapbox/services/android/testapp/geocoding/GeocodingWidgetActivity.java

@@ -50,7 +50,7 @@ protected void onCreate(Bundle savedInstanceState) {
     autocomplete.setLimit(10);
     autocomplete.setOnFeatureListener(new GeocoderAutoCompleteView.OnFeatureListener() {
       @Override
-      public void OnFeatureClick(CarmenFeature feature) {
+      public void onFeatureClick(CarmenFeature feature) {
         Position position = feature.asPosition();
         updateMap(position.getLatitude(), position.getLongitude());
       }

mapbox/app/src/main/java/com/mapbox/services/android/testapp/turf/TurfLineSliceActivity.java

@@ -12,10 +12,10 @@
 import com.mapbox.mapboxsdk.maps.OnMapReadyCallback;
 import com.mapbox.services.Constants;
 import com.mapbox.services.android.testapp.R;
+import com.mapbox.services.api.utils.turf.TurfMisc;
 import com.mapbox.services.commons.geojson.LineString;
 import com.mapbox.services.commons.geojson.Point;
 import com.mapbox.services.commons.models.Position;
-import com.mapbox.services.api.utils.turf.TurfMisc;
 import com.mapbox.services.commons.utils.PolylineUtils;
 
 import java.util.ArrayList;
@@ -39,7 +39,9 @@ protected void onCreate(Bundle savedInstanceState) {
     getSupportActionBar().setDisplayHomeAsUpEnabled(true);
 
     // Full route
-    routePoints = PolylineUtils.decode("ovnnEzvcrUt@o@z@u@_DkHu@cBM]Wi@q@aB[u@_BwDkBiEcB_EQ_@g@iAk@sAc@cAkA{CqAuCkAqCk@mAWm@S]]y@qBwEYq@]{@Z{@Xw@LYTm@Tm@Rk@Vq@JUJWNc@L]N_@Pc@HQPc@DKBKFO`@gARg@Tg@L[J[Rg@Tm@Nc@Pe@Zw@N_@JUNc@Z{@DIL[Tm@FDFF", Constants.OSRM_PRECISION_V5);
+    routePoints = PolylineUtils.decode("ovnnEzvcrUt@o@z@u@_DkHu@cBM]Wi@q@aB[u@_BwDkBiEcB_EQ_@g@iAk@sAc@cAkA{CqAuC"
+      + "kAqCk@mAWm@S]]y@qBwEYq@]{@Z{@Xw@LYTm@Tm@Rk@Vq@JUJWNc@L]N_@Pc@HQPc@DKBKFO`@gARg@Tg@L[J[Rg@Tm@Nc@Pe@Zw@N_@J"
+      + "UNc@Z{@DIL[Tm@FDFF", Constants.OSRM_PRECISION_V5);
 
     mapView = (MapView) findViewById(R.id.mapView);
     mapView.onCreate(savedInstanceState);

mapbox/app/src/test/java/com/mapbox/services/android/testapp/ExampleUnitTest.java

@@ -2,7 +2,7 @@
 
 import org.junit.Test;
 
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertEquals;
 
 /**
  * Example local unit test, which will execute on the development machine (host).

mapbox/libandroid-services/src/androidTest/java/com/mapbox/services/android/ExampleInstrumentedTest.java

@@ -7,7 +7,7 @@
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertEquals;
 
 /**
  * Instrumentation test, which will execute on an Android device.

mapbox/libandroid-services/src/test/java/com/mapbox/services/android/ExampleUnitTest.java

@@ -2,7 +2,7 @@
 
 import org.junit.Test;
 
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertEquals;
 
 /**
  * Example local unit test, which will execute on the development machine (host).

mapbox/libandroid-telemetry/src/androidTest/java/com/mapbox/services/android/telemetry/ExampleInstrumentedTest.java

@@ -7,7 +7,7 @@
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertEquals;
 
 /**
  * Instrumentation test, which will execute on an Android device.

mapbox/libandroid-telemetry/src/test/java/com/mapbox/services/android/telemetry/ExampleUnitTest.java

@@ -2,7 +2,7 @@
 
 import org.junit.Test;
 
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertEquals;
 
 /**
  * Example local unit test, which will execute on the development machine (host).