add subType to bannerComponents

Author: abhishek1508

services-directions-models/src/main/java/com/mapbox/api/directions/v5/models/BannerComponents.java

@@ -71,11 +71,19 @@ public abstract class BannerComponents extends DirectionsJsonObject
 
   /**
    * This view gives guidance through junctions and is used to complete maneuvers.
-   *
-   * @since 5.0.0
    */
   public static final String GUIDANCE_VIEW = "guidance-view";
 
+  /**
+   * This view gives guidance through signboards and is used to complete maneuvers.
+   */
+  public static final String SIGNBOARD = "signboard";
+
+  /**
+   * This view gives guidance through junctions and is used to complete maneuvers.
+   */
+  public static final String JCT = "jct";
+
   /**
    * Banner component types.
    * https://docs.mapbox.com/api/navigation/#banner-instruction-object
@@ -95,6 +103,19 @@ public abstract class BannerComponents extends DirectionsJsonObject
   public @interface BannerComponentsType {
   }
 
+  /**
+   * Banner component types.
+   * https://docs.mapbox.com/api/navigation/#banner-instruction-object
+   *
+   */
+  @Retention(RetentionPolicy.SOURCE)
+  @StringDef( {
+      JCT,
+      SIGNBOARD
+  })
+  public @interface BannerComponentsSubType {
+  }
+
   /**
    * Create a new instance of this class by using the {@link Builder} class.
    *
@@ -137,6 +158,22 @@ public static Builder builder() {
   @BannerComponentsType
   public abstract String type();
 
+  /**
+   * String giving you more context about {@link BannerComponentsType} which
+   * may help in visual markup/display choices.
+   * <p>
+   * Possible values:
+   * <ul>
+   * <li><strong>jct</strong>: indicates a junction guidance view.</li>
+   * <li><strong>signboard</strong>: indicates a signboard guidance view.</li>
+   * </ul>
+   *
+   * @return String type from above list
+   */
+  @Nullable
+  @BannerComponentsType
+  public abstract String subType();
+
   /**
    * The abbreviated form of text.
    * <p>
@@ -316,6 +353,25 @@ public abstract static class Builder {
     public abstract Builder type(@NonNull @BannerComponentsType String type);
 
 
+
+    /**
+     * String giving you more context about {@link BannerComponentsType}
+     * which may help in visual markup/display choices.
+     * <p>
+     * Possible values:
+     * <ul>
+     * <li><strong>jct</strong>: indicates a junction guidance view.</li>
+     * <li><strong>signboard</strong>: indicates a signboard guidance view.</li>
+     * </ul>
+     *
+     * @param subType String subType from above list
+     * @return String type from above list
+     */
+    @NonNull
+    @BannerComponentsType
+    public abstract Builder subType(@Nullable @BannerComponentsSubType String subType);
+
+
     /**
      * The abbreviated form of text.
      *

services-directions-models/src/test/java/com/mapbox/api/directions/v5/models/BannerComponentTest.java

@@ -175,4 +175,34 @@ public void testToFromJsonLaneText() {
 
     assertEquals(bannerComponents, bannerComponentsFromJson);
   }
+
+  @Test
+  public void testToFromJsonJctSubType() {
+
+    BannerComponents bannerComponents = BannerComponents.builder()
+        .text("")
+        .type("guidance-view")
+        .subType("jct")
+        .build();
+
+    String jsonString = bannerComponents.toJson();
+    BannerComponents bannerComponentsFromJson = BannerComponents.fromJson(jsonString);
+
+    assertEquals(bannerComponents, bannerComponentsFromJson);
+  }
+
+  @Test
+  public void testToFromJsonSignboardSubType() {
+
+    BannerComponents bannerComponents = BannerComponents.builder()
+        .text("")
+        .type("guidance-view")
+        .subType("signboard")
+        .build();
+
+    String jsonString = bannerComponents.toJson();
+    BannerComponents bannerComponentsFromJson = BannerComponents.fromJson(jsonString);
+
+    assertEquals(bannerComponents, bannerComponentsFromJson);
+  }
 }