Access array of doubles directly for LineString and MultiPoint (#9537)

This PR uses direct access to the `double []` provided by the new
`FlattenListOfPoints` in GeoJSON `MultiPoint` and `LineString` when
marshalling through JNI.

For `Point` there's no need to change it since we were already doing two
JNI calls (latitude, longitude).

The changes requires Mapbox GeoJSON 7.10.0 which includes:
- mapbox/mapbox-java#1630

GitOrigin-RevId: 26168ab0d9f7df6a1a42d9005466e01c02ea00bf

Author: jush

CHANGELOG.md

@@ -5,8 +5,10 @@ Mapbox welcomes participation and contributions from everyone.
 > **16 KB Page Size Support:** Starting with version 11.7.0 and 10.19.0, **NDK 27 is supported** with dedicated artifacts that include [support for 16 KB page sizes](https://developer.android.com/guide/practices/page-sizes). If your app does not require 16 KB page size support, you can keep using our default artifacts without `-ndk27` suffix. For more information about our NDK support, see https://docs.mapbox.com/android/maps/guides/#ndk-support
 
 # main
+## Features ✨ and improvements 🏁
 * Introduce new `LineLayer.lineElevationGroundScale` property to scale elevated lines with terrain exaggeration.
 * Promote elevated lines properties to stable: `LineLayer.lineZOffset` and `LineLayer.lineElevationReference`.
+* Improve data serialization speed when using `LineString` or `MultiPoint` in `GeoJsonSource`.
 
 # 11.19.0-rc.1
 

app/src/main/java/com/mapbox/maps/testapp/examples/linesandpolygons/SnakingDirectionsRouteActivity.kt

@@ -18,6 +18,7 @@ import com.mapbox.geojson.Feature
 import com.mapbox.geojson.FeatureCollection
 import com.mapbox.geojson.LineString
 import com.mapbox.geojson.Point
+import com.mapbox.maps.MapboxMap
 import com.mapbox.maps.Style
 import com.mapbox.maps.extension.style.image.image
 import com.mapbox.maps.extension.style.layers.generated.lineLayer
@@ -150,30 +151,56 @@ class SnakingDirectionsRouteActivity : AppCompatActivity() {
       .flatMap { it.coordinates() }
       .let(LineString::fromLngLats)
 
-    val features = List(ANIMATION_STEPS) { index ->
-      Feature.fromGeometry(
+    val features = MutableList(ANIMATION_STEPS) { index ->
         TurfMisc.lineSliceAlong(
           line,
           singleAnimationDistance * index,
           singleAnimationDistance * (index + 1),
           TurfConstants.UNIT_METERS
         )
-      )
     }
 
     val map = binding.mapView.mapboxMap
-    (0..ANIMATION_STEPS).forEach { index ->
       binding.mapView.postDelayed(
         {
-          if (map.isValid()) {
-            map.getStyle {
-              (it.getSource(DRIVING_ROUTE_POLYLINE_SOURCE_ID) as? GeoJsonSource)
-                ?.featureCollection(FeatureCollection.fromFeatures(features.take(index)))
-            }
-          }
+          setCurrentLine(map, features, features.removeAt(0))
         },
-        DRAW_SPEED_MILLISECONDS * index
+        DRAW_SPEED_MILLISECONDS
       )
+  }
+
+  private fun setCurrentLine(
+    map: MapboxMap,
+    features: MutableList<LineString>,
+    currentLineString: LineString
+  ) {
+    if (map.isValid()) {
+      // Draw current line
+      map.getStyle {
+        (it.getSource(DRIVING_ROUTE_POLYLINE_SOURCE_ID) as? GeoJsonSource)
+          ?.geometry(currentLineString)
+      }
+
+      // Extend the current line with the next segment
+      if (features.isNotEmpty()) {
+        val currentSegmentLngLats = currentLineString.flattenCoordinates().flattenLngLatArray
+        val nextSegmentLngLats = features.removeAt(0).flattenCoordinates().flattenLngLatArray
+        // Merge the current segment and the next one
+        val lngLats = DoubleArray(nextSegmentLngLats.size + currentSegmentLngLats.size)
+        System.arraycopy(currentSegmentLngLats, 0, lngLats, 0, currentSegmentLngLats.size)
+        System.arraycopy(
+          nextSegmentLngLats,
+          0,
+          lngLats,
+          currentSegmentLngLats.size,
+          nextSegmentLngLats.size
+        )
+        val nextLine = LineString.fromFlattenArrayOfPoints(lngLats, null)
+        binding.mapView.postDelayed(
+          { setCurrentLine(map, features, nextLine) },
+          DRAW_SPEED_MILLISECONDS
+        )
+      }
     }
   }
 

app/src/main/java/com/mapbox/maps/testapp/utils/SimulateRouteLocationProvider.kt

@@ -28,10 +28,12 @@ class SimulateRouteLocationProvider(
   private val scope = CoroutineScope(SupervisorJob() + Dispatchers.Default)
   private var emitLocationsJob: Job? = null
   private val totalRouteLength by lazy { TurfMeasurement.length(route, TurfConstants.UNIT_CENTIMETERS) }
-  private val routeStartPoint = route.coordinates().first()
+  private val routeStartPoint = Point.fromLngLat(
+    route.flattenCoordinates().flattenLngLatArray[0],
+    route.flattenCoordinates().flattenLngLatArray[1]
+  )
   private val locationConsumers = CopyOnWriteArraySet<LocationConsumer>()
   private var isFakeLocationEmitting = false
-  private val iterator = route.coordinates().toMutableList().iterator()
 
   override fun registerLocationConsumer(locationConsumer: LocationConsumer) {
     locationConsumers.add(locationConsumer)
@@ -54,16 +56,18 @@ class SimulateRouteLocationProvider(
     emitLocationsJob = scope.launch {
       // Make sure previous job is cancelled before starting a new one
       previousEmitLocationsJob?.cancelAndJoin()
-      var lastLocation: Point = if (iterator.hasNext()) {
-        iterator.next()
-      } else {
-        Point.fromLngLat(0.0, 0.0)
-      }
-      while (isActive && iterator.hasNext()) {
-        val point = iterator.next().insertProgressInfo()
+      val flattenCoordinates = route.flattenCoordinates()
+      var lastLocation: Point = routeStartPoint
+      var nextLocationIdx = 1
+      val flattenLngLatArray = flattenCoordinates.flattenLngLatArray
+      while (isActive && nextLocationIdx < flattenCoordinates.size()) {
+        val point = Point.fromLngLat(
+          flattenLngLatArray[nextLocationIdx * 2],
+          flattenLngLatArray[(nextLocationIdx * 2) + 1]
+        ).insertProgressInfo()
         val bearing = TurfMeasurement.bearing(lastLocation, point)
         lastLocation = point
-        iterator.remove()
+        nextLocationIdx++
 
         withContext(Dispatchers.Main) {
           locationConsumers.forEach { it.onLocationUpdated(point) }

compose-app/src/main/java/com/mapbox/maps/compose/testapp/examples/utils/SimulateRouteLocationProvider.kt

@@ -28,10 +28,12 @@ public class SimulateRouteLocationProvider(
   private val scope = CoroutineScope(SupervisorJob() + Dispatchers.Default)
   private var emitLocationsJob: Job? = null
   private val totalRouteLength by lazy { TurfMeasurement.length(route, TurfConstants.UNIT_CENTIMETERS) }
-  private val routeStartPoint = route.coordinates().first()
+  private val routeStartPoint = Point.fromLngLat(
+    route.flattenCoordinates().flattenLngLatArray[0],
+    route.flattenCoordinates().flattenLngLatArray[1]
+  )
   private val locationConsumers = CopyOnWriteArraySet<LocationConsumer>()
   private var isFakeLocationEmitting = false
-  private val iterator = route.coordinates().toMutableList().iterator()
 
   override fun registerLocationConsumer(locationConsumer: LocationConsumer) {
     locationConsumers.add(locationConsumer)
@@ -54,16 +56,18 @@ public class SimulateRouteLocationProvider(
     emitLocationsJob = scope.launch {
       // Make sure previous job is cancelled before starting a new one
       previousEmitLocationsJob?.cancelAndJoin()
-      var lastLocation: Point = if (iterator.hasNext()) {
-        iterator.next()
-      } else {
-        Point.fromLngLat(0.0, 0.0)
-      }
-      while (isActive && iterator.hasNext()) {
-        val point = iterator.next().insertProgressInfo()
+      val flattenCoordinates = route.flattenCoordinates()
+      var lastLocation: Point = routeStartPoint
+      var nextLocationIdx = 1
+      val flattenLngLatArray = flattenCoordinates.flattenLngLatArray
+      while (isActive && nextLocationIdx < flattenCoordinates.size()) {
+        val point = Point.fromLngLat(
+          flattenLngLatArray[nextLocationIdx * 2],
+          flattenLngLatArray[(nextLocationIdx * 2) + 1]
+        ).insertProgressInfo()
         val bearing = TurfMeasurement.bearing(lastLocation, point)
         lastLocation = point
-        iterator.remove()
+        nextLocationIdx++
 
         withContext(Dispatchers.Main) {
           locationConsumers.forEach { it.onLocationUpdated(point) }