Skip to content

Commit ad7ef70

Browse files
Fix number property generation in featureset feature template (#11851)
https://mapbox.atlassian.net/browse/MAPSAND-2672 ## Summary - Fix `featureset_feature.kt.ejs` template: for `number`-typed featureset properties, emit `getNumberProperty(...)?.toDouble()` / `?.toLong()` instead of the non-existent `getDoubleProperty()` / `getLongProperty()` (which don't exist on `com.mapbox.geojson.Feature`) - Generated files updated by running `generate-all` and `update-api` cc @mapbox/maps-ios cc @mapbox/maps-android cc @mapbox/sdk-platform cc @mapbox/nav-core-sdk --------- Co-authored-by: Changelog autocreator bot <github-actions[bot]@users.noreply.github.com> GitOrigin-RevId: a3df82c813e92c8171f3718c787dcba4a2fbf77d
1 parent 6660a9f commit ad7ef70

File tree

5 files changed

+19
-2
lines changed

5 files changed

+19
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Mapbox welcomes participation and contributions from everyone.
66
77
# main
88
## Features ✨ and improvements 🏁
9+
* Expose `height` and `minHeight` properties on `StandardBuildingsFeature`.
910
* Deprecate `PointAnnotation.iconImage` getter. Reading this property exposes an internally generated image ID managed by the annotation manager. If you need a stable, reusable image ID, register the image in the style yourself via the Style API and pass the ID explicitly via `PointAnnotationOptions.withIconImage(String)`. In that case you are responsible for the image's lifecycle and must remove it from the style when no longer needed.
1011

1112
## Bug fixes 🐞

plugin-annotation/api/Release/metalava.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ package com.mapbox.maps.plugin.annotation.generated {
507507
method public String? getIconHaloColorUseTheme();
508508
method public Double? getIconHaloWidth();
509509
method public Boolean? getIconIgnorePlacement();
510-
method public String? getIconImage();
510+
method @Deprecated public String? getIconImage();
511511
method public android.graphics.Bitmap? getIconImageBitmap();
512512
method public Double? getIconImageCrossFade();
513513
method public Boolean? getIconKeepUpright();
@@ -676,7 +676,7 @@ package com.mapbox.maps.plugin.annotation.generated {
676676
property public final String? iconHaloColorUseTheme;
677677
property public final Double? iconHaloWidth;
678678
property public final Boolean? iconIgnorePlacement;
679-
property public final String? iconImage;
679+
property @Deprecated public final String? iconImage;
680680
property public final android.graphics.Bitmap? iconImageBitmap;
681681
property public final Double? iconImageCrossFade;
682682
property public final Boolean? iconKeepUpright;

sdk-base/api/Release/metalava.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -878,7 +878,11 @@ package com.mapbox.maps.interactions.standard.generated {
878878
public final class StandardBuildingsFeature extends com.mapbox.maps.interactions.FeaturesetFeature<com.mapbox.maps.interactions.standard.generated.StandardBuildingsState> {
879879
ctor public StandardBuildingsFeature(com.mapbox.maps.FeaturesetFeatureId? id, String? importId, com.mapbox.geojson.Feature originalFeature, com.mapbox.maps.interactions.standard.generated.StandardBuildingsState state);
880880
method public String? getGroup();
881+
method public Double? getHeight();
882+
method public Double? getMinHeight();
881883
property public final String? group;
884+
property public final Double? height;
885+
property public final Double? minHeight;
882886
}
883887

884888
public final class StandardBuildingsState extends com.mapbox.maps.interactions.FeatureState {

sdk-base/api/sdk-base.api

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -874,6 +874,8 @@ public final class com/mapbox/maps/interactions/standard/generated/StandardBuild
874874
public final class com/mapbox/maps/interactions/standard/generated/StandardBuildingsFeature : com/mapbox/maps/interactions/FeaturesetFeature {
875875
public fun <init> (Lcom/mapbox/maps/FeaturesetFeatureId;Ljava/lang/String;Lcom/mapbox/geojson/Feature;Lcom/mapbox/maps/interactions/standard/generated/StandardBuildingsState;)V
876876
public final fun getGroup ()Ljava/lang/String;
877+
public final fun getHeight ()Ljava/lang/Double;
878+
public final fun getMinHeight ()Ljava/lang/Double;
877879
}
878880

879881
public final class com/mapbox/maps/interactions/standard/generated/StandardBuildingsState : com/mapbox/maps/interactions/FeatureState {

sdk-base/src/main/java/com/mapbox/maps/interactions/standard/generated/StandardBuildingsFeature.kt

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)