Fix 3d puck switching (#11873)

This fixes an issue introduced in
mapbox/mapbox-sdk#9292 when old 3d puck model
will remain on the screen after changing 3D puck model to another one.

https://mapbox.atlassian.net/browse/MAPSIOS-2150

cc @mapbox/maps-ios
cc @mapbox/sdk-platform

GitOrigin-RevId: 46fd028ca5c16befe2bf12ab14c1f5818a73851e

Author: evil159

CHANGELOG.md

@@ -4,6 +4,8 @@ Mapbox welcomes participation and contributions from everyone.
 
 ## main
 
+* Fix old 3D puck model remaining after updating the puck model.
+
 ## 11.21.0 - 02 April, 2026
 
 ## 11.21.0-rc.1 - 23 March, 2026

Sources/MapboxMaps/Location/Puck/Puck3DRenderer.swift

@@ -32,6 +32,7 @@ final class Puck3DRenderer: PuckRenderer {
 
     private func updateSourceModel(newState: PuckRendererState<Puck3DConfiguration>, oldState: PuckRendererState<Puck3DConfiguration>?) {
         var model = newState.configuration.model
+        model.id = "puck-model"
         model.position = [newState.coordinate.longitude, newState.coordinate.latitude]
 
         model.orientation = model.orientation

Tests/MapboxMapsTests/Location/Puck/Puck3DRendererTests.swift

@@ -18,7 +18,7 @@ final class Puck3DRendererTests: XCTestCase {
     }
 
     func test_SetNewState_With3DPuck_StartsRendering() throws {
-        let configuration = Puck3DConfiguration(model: Model())
+        let configuration = Puck3DConfiguration(model: Model(id: "puck-model"))
         let newState: PuckRendererState = .fixture(configuration: configuration)
         var expectedModel = configuration.model
         expectedModel.position = [newState.coordinate.longitude, newState.coordinate.latitude]
@@ -31,7 +31,7 @@ final class Puck3DRendererTests: XCTestCase {
     }
 
     func test_SetNewDuplicatedState_With3DPuck_DoNothing() throws {
-        let configuration = Puck3DConfiguration(model: Model(id: "test"))
+        let configuration = Puck3DConfiguration(model: Model(id: "puck-model"))
         let newState: PuckRendererState = .fixture()
         var expectedModel = configuration.model
         expectedModel.position = [newState.coordinate.longitude, newState.coordinate.latitude]
@@ -45,7 +45,7 @@ final class Puck3DRendererTests: XCTestCase {
     }
 
     func test_SetNewState_WithNil_RemovesLayerAndSource() throws {
-        let configuration = Puck3DConfiguration(model: Model())
+        let configuration = Puck3DConfiguration(model: Model(id: "puck-model"))
         let newState: PuckRendererState = .fixture(configuration: configuration)
         var expectedModel = configuration.model
         expectedModel.position = [newState.coordinate.longitude, newState.coordinate.latitude]
@@ -59,7 +59,7 @@ final class Puck3DRendererTests: XCTestCase {
     }
 
     func test_SetNewState_WithSameConfiguration_UpdatesOnlySources() throws {
-        let configuration = Puck3DConfiguration(model: Model())
+        let configuration = Puck3DConfiguration(model: Model(id: "puck-model"))
         let firstState: PuckRendererState = .fixture(
             accuracyAuthorization: .reducedAccuracy,
             configuration: configuration
@@ -88,13 +88,13 @@ final class Puck3DRendererTests: XCTestCase {
 
     }
     func test_SetNewState_WithNewConfiguration_UpdatesSourcesAndLayer() throws {
-        let firstConfiguration = Puck3DConfiguration(model: Model(id: "first"))
+        let firstConfiguration = Puck3DConfiguration(model: Model(id: "puck-model"))
         let firstState: PuckRendererState = .fixture(configuration: firstConfiguration)
         var firstModel = firstConfiguration.model
         firstModel.position = [firstState.coordinate.longitude, firstState.coordinate.latitude]
         firstModel.orientation = [0, 0, 0]
 
-        let secondConfiguration = Puck3DConfiguration(model: Model(id: "second"), modelScale: .constant([3]))
+        let secondConfiguration = Puck3DConfiguration(model: Model(id: "puck-model"), modelScale: .constant([3]))
         let secondState: PuckRendererState = .fixture(configuration: secondConfiguration)
         var secondModel = secondConfiguration.model
         secondModel.position = [secondState.coordinate.longitude, secondState.coordinate.latitude]