fix crash by removing fragment constructor

Author: abhishek1508

CHANGELOG.md

@@ -5,6 +5,7 @@ Mapbox welcomes participation and contributions from everyone.
 ## Unreleased
 #### Features
 #### Bug fixes and improvements
+- Fixed crash in `PermissionsLauncherFragment` occurring on device rotation. [#6635](https://github.com/mapbox/mapbox-navigation-android/pull/6635)
 
 ## Mapbox Navigation SDK 2.9.2 - 18 November, 2022
 ### Changelog

libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/permission/PermissionsLauncherFragment.kt

@@ -13,20 +13,21 @@ import androidx.fragment.app.FragmentActivity
 /**
  * A view-less fragment that requests permissions using [ActivityResultCaller] interface.
  */
-internal class PermissionsLauncherFragment(
-    private val permissions: Array<String>,
-    private val onResult: ActivityResultCallback<Map<String, Boolean>>
-) : Fragment() {
+internal class PermissionsLauncherFragment : Fragment() {
 
+    private var permissions: Array<String>? = null
+    private var onResult: ActivityResultCallback<Map<String, Boolean>>? = null
     private var launcher: ActivityResultLauncher<Array<String>>? = null
 
     override fun onAttach(context: Context) {
         super.onAttach(context)
-        val missingPermissions = permissions.filter { permission ->
+        val missingPermissions = permissions?.filter { permission ->
             checkSelfPermission(context, permission) != PERMISSION_GRANTED
         }
-        if (missingPermissions.isNotEmpty()) {
-            launcher = registerForActivityResult(RequestMultiplePermissions(), onResult)
+        if (!missingPermissions.isNullOrEmpty()) {
+            launcher = registerForActivityResult(RequestMultiplePermissions()) {
+                onResult?.onActivityResult(it)
+            }
             launcher?.launch(missingPermissions.toTypedArray())
         }
     }
@@ -45,9 +46,13 @@ internal class PermissionsLauncherFragment(
             onResult: ActivityResultCallback<Map<String, Boolean>>
         ) {
             fragActivity.supportFragmentManager.apply {
+                val fragment = PermissionsLauncherFragment().apply {
+                    this.permissions = permissions
+                    this.onResult = onResult
+                }
                 val t = beginTransaction()
                 findFragmentByTag(TAG)?.also { t.remove(it) }
-                t.add(PermissionsLauncherFragment(permissions, onResult), TAG)
+                t.add(fragment, TAG)
                 t.commit()
             }
         }
@@ -56,7 +61,7 @@ internal class PermissionsLauncherFragment(
             if (!fragActivity.isFinishing) {
                 fragActivity.supportFragmentManager.apply {
                     findFragmentByTag(TAG)?.also {
-                        beginTransaction().remove(it).commit()
+                        beginTransaction().remove(it).commitAllowingStateLoss()
                     }
                 }
             }

qa-test-app/src/main/java/com/mapbox/navigation/qa_test_app/view/NavigationViewFragmentLifecycleActivity.kt

@@ -34,7 +34,7 @@ class NavigationViewFragmentLifecycleActivity : AppCompatActivity() {
         supportFragmentManager.commit {
             add(
                 R.id.navigationViewFragment,
-                PageNavigationFragment(FIRST_FRAGMENT_TAG),
+                PageNavigationFragment().apply { this.logTag = FIRST_FRAGMENT_TAG },
                 FIRST_FRAGMENT_TAG
             )
         }
@@ -57,9 +57,15 @@ class NavigationViewFragmentLifecycleActivity : AppCompatActivity() {
     private fun swapFragments() {
         val fragment = supportFragmentManager.findFragmentById(R.id.navigationViewFragment)
         val newFragmentPair = if (fragment?.tag == FIRST_FRAGMENT_TAG) {
-            Pair(PageNavigationFragment(SECOND_FRAGMENT_TAG), SECOND_FRAGMENT_TAG)
+            Pair(
+                PageNavigationFragment().apply { this.logTag = SECOND_FRAGMENT_TAG },
+                SECOND_FRAGMENT_TAG
+            )
         } else {
-            Pair(PageNavigationFragment(FIRST_FRAGMENT_TAG), FIRST_FRAGMENT_TAG)
+            Pair(
+                PageNavigationFragment().apply { this.logTag = FIRST_FRAGMENT_TAG },
+                FIRST_FRAGMENT_TAG
+            )
         }
         supportFragmentManager.commit {
             replace(R.id.navigationViewFragment, newFragmentPair.first, newFragmentPair.second)
@@ -69,8 +75,9 @@ class NavigationViewFragmentLifecycleActivity : AppCompatActivity() {
 }
 
 @OptIn(ExperimentalPreviewMapboxNavigationAPI::class)
-class PageNavigationFragment(private val logTag: String) : Fragment() {
+class PageNavigationFragment : Fragment() {
 
+    var logTag: String = ""
     var navigationView: NavigationView? = null
         private set
     private var frame: FrameLayout? = null