More tests and minor tweaks

Author: tomaszrybakiewicz

…ndablebutton/ArrivalTextComponentTest.kt …opin/arrival/ArrivalTextComponentTest.ktlibnavui-dropin/src/test/java/com/mapbox/navigation/dropin/extendablebutton/ArrivalTextComponentTest.kt renamed to libnavui-dropin/src/test/java/com/mapbox/navigation/dropin/arrival/ArrivalTextComponentTest.kt libnavui-dropin/src/test/java/com/mapbox/navigation/dropin/extendablebutton/ArrivalTextComponentTest.kt renamed to libnavui-dropin/src/test/java/com/mapbox/navigation/dropin/arrival/ArrivalTextComponentTest.kt

@@ -1,4 +1,4 @@
-package com.mapbox.navigation.dropin.component.infopanel
+package com.mapbox.navigation.dropin.arrival
 
 import android.content.Context
 import android.os.Build
@@ -12,6 +12,7 @@ import io.mockk.spyk
 import io.mockk.verify
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.flow.MutableStateFlow
+import kotlinx.coroutines.runBlocking
 import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
@@ -25,7 +26,7 @@ import org.robolectric.annotation.Config
 class ArrivalTextComponentTest {
 
     @get:Rule
-    var coroutineRule = MainCoroutineRule()
+    val coroutineRule = MainCoroutineRule()
 
     private lateinit var textView: AppCompatTextView
     private lateinit var textAppearance: MutableStateFlow<Int>
@@ -45,4 +46,19 @@ class ArrivalTextComponentTest {
 
         verify { textView.setTextAppearance(textAppearance.value) }
     }
+
+    @Test
+    fun `onAttached should observe apply textAppearance style to the textView`() = runBlocking {
+        sut.onAttached(mockk())
+
+        textAppearance.value = R.style.TextAppearance_AppCompat_Small
+
+        verify { textView.setTextAppearance(R.style.TextAppearance_AppCompat_Small) }
+    }
+
+    @Test
+    fun `onAttached not crash when wrong style resource id is used`() {
+        textAppearance.value = Int.MAX_VALUE
+        sut.onAttached(mockk())
+    }
 }

libnavui-dropin/src/test/java/com/mapbox/navigation/dropin/camera/CameraLayoutObserverTest.kt

@@ -1,6 +1,6 @@
 @file:Suppress("PrivatePropertyName", "MaxLineLength")
 
-package com.mapbox.navigation.dropin.component.camera
+package com.mapbox.navigation.dropin.camera
 
 import android.app.Service
 import android.content.Context

…centerButtonComponentContractImplTest.kt …centerButtonComponentContractImplTest.ktlibnavui-dropin/src/test/java/com/mapbox/navigation/dropin/recenter/RecenterButtonComponentContractImplTest.kt renamed to libnavui-dropin/src/test/java/com/mapbox/navigation/dropin/camera/RecenterButtonComponentContractImplTest.kt libnavui-dropin/src/test/java/com/mapbox/navigation/dropin/recenter/RecenterButtonComponentContractImplTest.kt renamed to libnavui-dropin/src/test/java/com/mapbox/navigation/dropin/camera/RecenterButtonComponentContractImplTest.kt

@@ -1,4 +1,4 @@
-package com.mapbox.navigation.dropin.component.recenter
+package com.mapbox.navigation.dropin.camera
 
 import com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI
 import com.mapbox.navigation.dropin.util.TestStore
@@ -10,7 +10,6 @@ import io.mockk.mockk
 import io.mockk.spyk
 import io.mockk.verify
 import kotlinx.coroutines.ExperimentalCoroutinesApi
-import kotlinx.coroutines.yield
 import org.junit.Assert.assertFalse
 import org.junit.Assert.assertTrue
 import org.junit.Before
@@ -21,7 +20,7 @@ import org.junit.Test
 class RecenterButtonComponentContractImplTest {
 
     @get:Rule
-    var coroutineRule = MainCoroutineRule()
+    val coroutineRule = MainCoroutineRule()
 
     private lateinit var store: TestStore
     private lateinit var sut: RecenterButtonComponentContractImpl
@@ -41,32 +40,36 @@ class RecenterButtonComponentContractImplTest {
                     navigation = NavigationState.FreeDrive
                 )
             }
-            yield() // yielding to allow isVisible StateFlow run its logic
+            coroutineRule.testDispatcher.advanceUntilIdle()
             assertTrue(
                 "expected TRUE when camera is Idle and not in RoutePreview",
                 sut.isVisible.value
             )
         }
 
     @Test
-    fun `isVisible - should return FALSE when camera not Idle or in RoutePreview`() =
+    fun `isVisible - should return FALSE when camera not Idle`() =
         coroutineRule.runBlockingTest {
             store.updateState {
                 it.copy(
                     camera = it.camera.copy(cameraMode = TargetCameraMode.Following),
                     navigation = NavigationState.FreeDrive
                 )
             }
-            yield() // yielding to allow isVisible StateFlow run its logic
+            coroutineRule.testDispatcher.advanceUntilIdle()
             assertFalse("expected FALSE when camera not Idle", sut.isVisible.value)
+        }
 
+    @Test
+    fun `isVisible - should return FALSE when camera in RoutePreview`() =
+        coroutineRule.runBlockingTest {
             store.updateState {
                 it.copy(
                     camera = it.camera.copy(cameraMode = TargetCameraMode.Idle),
                     navigation = NavigationState.RoutePreview
                 )
             }
-            yield() // yielding to allow isVisible StateFlow run its logic
+            coroutineRule.testDispatcher.advanceUntilIdle()
             assertFalse("expected FALSE when NavigationState not RoutePreview", sut.isVisible.value)
         }