NAVAND-899: meet code review

Author: dzinad

CHANGELOG.md

@@ -7,6 +7,8 @@ Mapbox welcomes participation and contributions from everyone.
 #### Bug fixes and improvements
 - Fixed crash in `PermissionsLauncherFragment` occurring on device rotation. [#6635](https://github.com/mapbox/mapbox-navigation-android/pull/6635)
 - Fixed a rare `java.lang.IllegalArgumentException: The Path cannot loop back on itself.` exception when using `NavigationLocationProvider`. [#6641](https://github.com/mapbox/mapbox-navigation-android/pull/6641)
+- Started clearing route geometry cache when no routes (neither routes used for Active Guidance nor previewed ones) are available. [#6617](https://github.com/mapbox/mapbox-navigation-android/pull/6617)
+- Added convenience `MapboxNavigation#moveRoutesFromPreviewToNavigator` method to simplify transition from Routes Preview state to Active Guidance state. [#6617](https://github.com/mapbox/mapbox-navigation-android/pull/6617)
 
 ## Mapbox Navigation SDK 2.9.2 - 18 November, 2022
 ### Changelog
@@ -44,11 +46,6 @@ This release depends on, and has been tested with, the following Mapbox dependen
 - Mapbox Java `v6.10.0-beta.2` ([release notes](https://github.com/mapbox/mapbox-java/releases/tag/v6.10.0-beta.2))
 - Mapbox Android Core `v5.0.2` ([release notes](https://github.com/mapbox/mapbox-events-android/releases/tag/core-5.0.2))
 
-- Added `DecodeUtils#clearCache` to allow trigger route geometry cache clearing in order to reduce memory usage.
-- Started clearing route geometry cache when no routes (neither routes used for Active Guidance nor previewed ones) are available.
-- Added `DecodeUtils#clearCache` to allow trigger route geometry cache clearing in order to reduce memory usage. [#6617](https://github.com/mapbox/mapbox-navigation-android/pull/6617)
-- Started clearing route geometry cache when no routes (neither routes used for Active Guidance nor previewed ones) are available. [#6617](https://github.com/mapbox/mapbox-navigation-android/pull/6617)
-- Added convenience `MapboxNavigation#moveRoutesFromPreviewToNavigator` method to simplify transition from Routes Preview state to Active Guidance state. [#6617](https://github.com/mapbox/mapbox-navigation-android/pull/6617)
 
 ## Mapbox Navigation SDK 2.9.1 - 11 November, 2022
 ### Changelog

libnavigation-base/api/current.txt

@@ -1720,7 +1720,6 @@ package com.mapbox.navigation.base.trip.notification {
 package com.mapbox.navigation.base.utils {
 
   public final class DecodeUtils {
-    method public static void clearCache();
     method public static com.mapbox.geojson.LineString completeGeometryToLineString(com.mapbox.api.directions.v5.models.DirectionsRoute);
     method public static java.util.List<com.mapbox.geojson.Point> completeGeometryToPoints(com.mapbox.api.directions.v5.models.DirectionsRoute);
     method public static com.mapbox.geojson.LineString stepGeometryToLineString(com.mapbox.api.directions.v5.models.DirectionsRoute, com.mapbox.api.directions.v5.models.LegStep legStep);

libnavigation-base/src/main/java/com/mapbox/navigation/base/internal/DecodeUtilsEx.kt

@@ -0,0 +1,7 @@
+package com.mapbox.navigation.base.internal
+
+import com.mapbox.navigation.base.utils.DecodeUtils
+
+fun DecodeUtils.clearCache() {
+    clearCacheInternal()
+}

libnavigation-base/src/main/java/com/mapbox/navigation/base/utils/DecodeUtils.kt

@@ -127,7 +127,7 @@ object DecodeUtils {
      * [stepGeometryToPoints], [completeGeometryToPoints], etc.
      */
     @JvmStatic
-    fun clearCache() {
+    internal fun clearCacheInternal() {
         synchronized(stepsGeometryDecodeCache) {
             cachedRoutes.clear()
             stepsGeometryDecodeCache.evictAll()

libnavigation-core/src/main/java/com/mapbox/navigation/core/MapboxNavigation.kt

@@ -911,7 +911,9 @@ class MapboxNavigation @VisibleForTesting internal constructor(
     fun moveRoutesFromPreviewToNavigator() {
         val preview = getRoutesPreview()
         requireNotNull(preview) {
-            "Can't move routes from preview to navigator as no previewed routes are available"
+            "Can't move routes from preview to navigator as no previewed routes are available. " +
+                "Make sure you have set routes to preview and received previewed routes " +
+                "in RoutesPreviewObserver before moving them to navigator."
         }
         setNavigationRoutes(preview.routesList)
         setRoutesPreview(emptyList())

libnavigation-core/src/main/java/com/mapbox/navigation/core/RoutesCacheClearer.kt

@@ -1,6 +1,7 @@
 package com.mapbox.navigation.core
 
 import com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI
+import com.mapbox.navigation.base.internal.clearCache
 import com.mapbox.navigation.base.route.NavigationRoute
 import com.mapbox.navigation.base.utils.DecodeUtils
 import com.mapbox.navigation.core.directions.session.RoutesObserver

libnavigation-core/src/test/java/com/mapbox/navigation/core/RoutesCacheClearerTest.kt

@@ -1,6 +1,7 @@
 package com.mapbox.navigation.core
 
 import com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI
+import com.mapbox.navigation.base.internal.clearCache
 import com.mapbox.navigation.base.utils.DecodeUtils
 import com.mapbox.navigation.core.directions.session.RoutesUpdatedResult
 import com.mapbox.navigation.core.preview.RoutesPreview