Skip to content

Commit 5a77f6d

Browse files
author
Pablo Guardiola
authored
use mapbox navigation app lifecycle owner instead of process lifecycle owner to support android auto and remove android x lifecycle process dependency not necessary anymore (#6609)
1 parent b7a5147 commit 5a77f6d

4 files changed

Lines changed: 69 additions & 63 deletions

File tree

gradle/dependencies.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ ext {
139139
androidXLifecycleRuntime : "androidx.lifecycle:lifecycle-runtime-ktx:${version.androidXLifecycle}",
140140
androidXLifecycleLivedata : "androidx.lifecycle:lifecycle-livedata-ktx:${version.androidXLifecycle}",
141141
androidXLifecycleViewmodel: "androidx.lifecycle:lifecycle-viewmodel-ktx:${version.androidXLifecycle}",
142-
androidXLifecycleProcess : "androidx.lifecycle:lifecycle-process:${version.androidXLifecycle}",
143142
androidXLifecycleTesting : "androidx.lifecycle:lifecycle-runtime-testing:${version.androidXLifecycle}",
144143

145144
// square crew

libnavigation-copilot/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ dependencies {
2929
implementation dependenciesList.coroutinesAndroid
3030

3131
implementation dependenciesList.androidXWorkManager
32-
implementation dependenciesList.androidXLifecycleProcess
3332

3433
testImplementation project(':libtesting-navigation-util')
3534
testImplementation project(':libtesting-utils')

libnavigation-copilot/src/main/java/com/mapbox/navigation/copilot/MapboxCopilotImpl.kt

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package com.mapbox.navigation.copilot
33
import android.content.pm.ApplicationInfo
44
import androidx.lifecycle.DefaultLifecycleObserver
55
import androidx.lifecycle.LifecycleOwner
6-
import androidx.lifecycle.ProcessLifecycleOwner
76
import com.google.gson.Gson
87
import com.mapbox.common.UploadOptions
98
import com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI
@@ -31,6 +30,7 @@ import com.mapbox.navigation.core.internal.telemetry.UserFeedback
3130
import com.mapbox.navigation.core.internal.telemetry.UserFeedbackCallback
3231
import com.mapbox.navigation.core.internal.telemetry.registerUserFeedbackCallback
3332
import com.mapbox.navigation.core.internal.telemetry.unregisterUserFeedbackCallback
33+
import com.mapbox.navigation.core.lifecycle.MapboxNavigationApp
3434
import java.io.File
3535
import java.util.Locale
3636

@@ -115,7 +115,9 @@ internal class MapboxCopilotImpl(
115115
*/
116116
fun start() {
117117
registerUserFeedbackCallback(userFeedbackCallback)
118-
ProcessLifecycleOwner.get().lifecycle.addObserver(foregroundBackgroundLifecycleObserver)
118+
MapboxNavigationApp.lifecycleOwner.lifecycle.addObserver(
119+
foregroundBackgroundLifecycleObserver
120+
)
119121
mapboxNavigation.registerHistoryRecordingStateChangeObserver(
120122
historyRecordingStateChangeObserver
121123
)
@@ -126,7 +128,9 @@ internal class MapboxCopilotImpl(
126128
*/
127129
fun stop() {
128130
unregisterUserFeedbackCallback(userFeedbackCallback)
129-
ProcessLifecycleOwner.get().lifecycle.removeObserver(foregroundBackgroundLifecycleObserver)
131+
MapboxNavigationApp.lifecycleOwner.lifecycle.removeObserver(
132+
foregroundBackgroundLifecycleObserver
133+
)
130134
mapboxNavigation.unregisterHistoryRecordingStateChangeObserver(
131135
historyRecordingStateChangeObserver
132136
)

0 commit comments

Comments
 (0)