Skip to content

Commit 7a51baa

Browse files
committed
added comment
1 parent 2405e62 commit 7a51baa

File tree

4 files changed

+21
-7
lines changed

4 files changed

+21
-7
lines changed

libnavigation-core/src/main/java/com/mapbox/navigation/core/fasterroute/FasterRouteOptions.kt

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,19 @@ package com.mapbox.navigation.core.fasterroute
33
import com.mapbox.navigation.base.ExperimentalMapboxNavigationAPI
44

55
@ExperimentalMapboxNavigationAPI
6-
data class FasterRouteOptions(
7-
val maxSimilarityToExistingRoute: Double = 0.5
8-
)
6+
class FasterRouteOptions internal constructor(
7+
val maxSimilarityToExistingRoute: Double
8+
) {
9+
class Builder {
10+
11+
private val maxSimilarityToExistingRoute = 0.5
12+
13+
fun maxSimilarityToExistingRoute(value: Double) {
14+
assert(value in 0.0..1.0) { "similarity should be a value between 0 and 1" }
15+
}
16+
17+
fun build() = FasterRouteOptions(maxSimilarityToExistingRoute)
18+
}
19+
}
20+
21+

libnavigation-core/src/main/java/com/mapbox/navigation/core/fasterroute/SimilarRoutes.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ import com.mapbox.navigation.base.route.NavigationRoute
55
import com.mapbox.navigation.base.utils.DecodeUtils.completeGeometryToPoints
66
import com.mapbox.turf.TurfMeasurement
77

8+
/***
9+
* The function uses summary of route leg which is not guaranteed to have a stable format.
10+
*/
811
internal fun calculateDescriptionSimilarity(a: NavigationRoute, b: NavigationRoute): Double {
912
val firstSummary = parseSummaries(a)
1013
val secondSummary = parseSummaries(b)

libnavigation-core/src/test/java/com/mapbox/navigation/core/fasterroute/FasterRouteTrackerTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,5 +73,5 @@ class FasterRouteTrackerTest {
7373
}
7474

7575
internal fun createFasterRoutesTracker() = FasterRouteTracker(
76-
FasterRouteOptions(maxSimilarityToExistingRoute = 0.5)
76+
FasterRouteOptions.Builder().build()
7777
)

qa-test-app/src/main/java/com/mapbox/navigation/qa_test_app/view/AlternativeRouteActivity.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,7 @@ class AlternativeRouteActivity : AppCompatActivity(), OnMapLongClickListener {
150150
@OptIn(ExperimentalMapboxNavigationAPI::class)
151151
private val fasterRoutes by lazy {
152152
mapboxNavigation.createFasterRoutes(
153-
FasterRouteOptions(
154-
maxSimilarityToExistingRoute = 0.5
155-
)
153+
FasterRouteOptions.Builder().build()
156154
)
157155
}
158156

0 commit comments

Comments
 (0)