NAVAND-302 Refactored methodology for calculating restricted road expressions using the intersections of a DirectionsRoute rather than the distance array. (#6399)

Co-authored-by: Seth Bourget <seth@cafesilencio.net>

Author: Seth Bourget

CHANGELOG.md

@@ -10,6 +10,9 @@ Mapbox welcomes participation and contributions from everyone.
 - :warning: Restructured the package system of Drop-In UI into feature verticals. [#6430](https://github.com/mapbox/mapbox-navigation-android/pull/6430)
 - [TileStoreService] Use shared memory for marshaling large types and improve error handling. [#6422](https://github.com/mapbox/mapbox-navigation-android/pull/6422)
 - [TileStoreService] Fixed an issue that prevented callbacks to be invoked if an operation had to be retried because of a loss of connection to the service process. [#6422](https://github.com/mapbox/mapbox-navigation-android/pull/6422)
+- Fixed an issue with restricted road visualization on the route line that occurred during route refreshes. [#6399](https://github.com/mapbox/mapbox-navigation-android/pull/6399)
+- Improved precision of restricted sections visualization, especially for long routes. [#6399](https://github.com/mapbox/mapbox-navigation-android/pull/6399)
+- Fixed a rare issue where alternative route would not be vanished until deviation point for `MapboxRouteLineApi#setNavigationRoutes(routes, metadata)` when the route's geometry contained duplicate points. [#6399](https://github.com/mapbox/mapbox-navigation-android/pull/6399)
 
 ## Mapbox Navigation SDK 2.9.0-alpha.4 - 30 September, 2022
 ### Changelog
@@ -134,7 +137,6 @@ This release depends on, and has been tested with, the following Mapbox dependen
 - Mapbox Android Core `v5.0.2` ([release notes](https://github.com/mapbox/mapbox-events-android/releases/tag/core-5.0.2))
 - Mapbox Android Telemetry `v8.1.5` ([release notes](https://github.com/mapbox/mapbox-events-android/releases/tag/telem-8.1.5-core-5.0.2))
 
-
 ## Mapbox Navigation SDK 2.9.0-alpha.3 - 23 September, 2022
 ### Changelog
 [Changes between v2.9.0-alpha.2 and v2.9.0-alpha.3](https://github.com/mapbox/mapbox-navigation-android/compare/v2.9.0-alpha.2...v2.9.0-alpha.3)

instrumentation-tests/src/androidTest/java/com/mapbox/navigation/instrumentation_tests/ui/routeline/RouteLineLayersTest.kt

@@ -17,8 +17,6 @@ import com.mapbox.navigation.base.route.RouterOrigin
 import com.mapbox.navigation.base.route.toNavigationRoute
 import com.mapbox.navigation.base.utils.DecodeUtils.completeGeometryToPoints
 import com.mapbox.navigation.core.MapboxNavigationProvider
-import com.mapbox.navigation.core.routealternatives.AlternativeRouteIntersection
-import com.mapbox.navigation.core.routealternatives.AlternativeRouteMetadata
 import com.mapbox.navigation.instrumentation_tests.R
 import com.mapbox.navigation.instrumentation_tests.activity.BasicNavigationViewActivity
 import com.mapbox.navigation.instrumentation_tests.utils.MapboxNavigationRule
@@ -393,16 +391,39 @@ class RouteLineLayersTest : BaseTest<BasicNavigationViewActivity>(
     /**
      * This test ensures that we're not crashing when parsing alternative routes metadata
      * in a specific case (caught by crashlytics) that involved
-     * Nav Native reporting the [AlternativeRouteIntersection.geometryIndexInRoute] of
-     * [AlternativeRouteMetadata.forkIntersectionOfAlternativeRoute] to be out of bounds
-     * for the shape points collection of that particular route.
+     * Directions API returning a route which contains a duplicate point in a step.
      */
     @Test
-    fun should_not_crash_when_fork_intersection_out_of_bounds_NAVAND_692() = sdkTest {
+    fun should_provide_valid_offset_when_route_contains_duplicate_points_NAVAND_692() = sdkTest {
         val primaryRoute = createRoute(
             responseJson = R.raw.route_response_japan_1,
             requestUrlJson = R.raw.route_response_japan_1_url,
         ).first()
+
+        /**
+         * this route contains a duplicate point somewhere in the middle of the first step.
+         * Inspecting a decoded portion of the `LineString` presents this:
+         * ```
+         * ...
+         *     [
+         *       140.9184,
+         *       37.718443
+         *     ],
+         *     [
+         *       140.918069,
+         *       37.719383
+         *     ],
+         *     [
+         *       140.918069,
+         *       37.719383
+         *     ],
+         *     [
+         *       140.917924,
+         *       37.719839
+         *     ],
+         * ...
+         * ```
+         */
         val alternativeRoute = createRoute(
             responseJson = R.raw.route_response_japan_2,
             requestUrlJson = R.raw.route_response_japan_2_url,
@@ -432,10 +453,10 @@ class RouteLineLayersTest : BaseTest<BasicNavigationViewActivity>(
             alternativeRoutesMetadata = mapboxNavigation.getAlternativeMetadataFor(routesUpdate)
         )
 
-        // we're expecting to ignore the attempt to hide the alternative until the deviation point,
-        // hence the cleared offset
+        // the alternative route turns out to fully overlaps with the original route,
+        // hence the 1.0 offset
         assertEquals(
-            0.0,
+            1.0,
             result.value!!.alternativeRouteLinesData[0].dynamicData.trimOffset!!.offset,
             0.0000000001
         )