Skip to content

Commit 893ae7d

Browse files
committed
mark base classes with UiThread annotation
1 parent f28c864 commit 893ae7d

5 files changed

Lines changed: 12 additions & 4 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ Mapbox welcomes participation and contributions from everyone.
88
- Introduced `ViewOptionsCustomization.showCameraDebugInfo` to allow end users to enable camera debug info. [#6356](https://github.com/mapbox/mapbox-navigation-android/pull/6356)
99
#### Bug fixes and improvements
1010
- Marked `PredictiveCacheController`, `MapboxBuildingView`, `ViewportDataSourceUpdateObserver`, `NavigationScaleGestureHandler`, `NavigationCameraStateChangedObserver`, `NavigationCameraStateTransition`, `NavigationCameraTransition`, `TransitionEndListener`, `MapboxRecenterButton`, `MapboxRouteOverviewButton`, `MapboxJunctionView`, `MapboxSignboardView`, `MapboxRoadNameLabelView`, `MapboxRoadNameView`, `MapboxRouteArrowView`, `MapboxRouteLineView`, `MapboxCameraModeButton` methods and `View.capture` extension with `@UiThread` annotation. [#6235](https://github.com/mapbox/mapbox-navigation-android/pull/6235)
11+
- Marked `Binder`, `MapboxExtendableButton` methods and `MapboxNavigation#installComponents` methods with `@UiThread` annotation. [#6268](https://github.com/mapbox/mapbox-navigation-android/pull/6268)
1112

1213
## Mapbox Navigation SDK 2.9.0-alpha.2 - 16 September, 2022
1314
### Changelog

libnavui-base/api/current.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ package com.mapbox.navigation.ui.base.installer {
1717

1818
public final class ComponentInstallerKt {
1919
method @com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI public static inline <reified T> T! findComponent(com.mapbox.navigation.ui.base.installer.ComponentInstaller);
20-
method @com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI public static void installComponents(com.mapbox.navigation.core.lifecycle.MapboxNavigationApp, androidx.lifecycle.LifecycleOwner lifecycleOwner, kotlin.jvm.functions.Function1<? super com.mapbox.navigation.ui.base.installer.ComponentInstaller,kotlin.Unit> config);
21-
method @com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI public static void installComponents(com.mapbox.navigation.core.MapboxNavigation, androidx.lifecycle.LifecycleOwner lifecycleOwner, kotlin.jvm.functions.Function1<? super com.mapbox.navigation.ui.base.installer.ComponentInstaller,kotlin.Unit> config);
20+
method @UiThread @com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI public static void installComponents(com.mapbox.navigation.core.lifecycle.MapboxNavigationApp, androidx.lifecycle.LifecycleOwner lifecycleOwner, kotlin.jvm.functions.Function1<? super com.mapbox.navigation.ui.base.installer.ComponentInstaller,kotlin.Unit> config);
21+
method @UiThread @com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI public static void installComponents(com.mapbox.navigation.core.MapboxNavigation, androidx.lifecycle.LifecycleOwner lifecycleOwner, kotlin.jvm.functions.Function1<? super com.mapbox.navigation.ui.base.installer.ComponentInstaller,kotlin.Unit> config);
2222
}
2323

2424
@com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI public fun interface Installation {
@@ -30,7 +30,7 @@ package com.mapbox.navigation.ui.base.installer {
3030
package com.mapbox.navigation.ui.base.lifecycle {
3131

3232
@com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI public interface Binder<T> {
33-
method public com.mapbox.navigation.core.lifecycle.MapboxNavigationObserver bind(T? viewGroup);
33+
method @UiThread public com.mapbox.navigation.core.lifecycle.MapboxNavigationObserver bind(T? viewGroup);
3434
}
3535

3636
@com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI public fun interface UIBinder extends com.mapbox.navigation.ui.base.lifecycle.Binder<android.view.ViewGroup> {
@@ -76,7 +76,7 @@ package com.mapbox.navigation.ui.base.util {
7676

7777
package com.mapbox.navigation.ui.base.view {
7878

79-
@com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI public final class MapboxExtendableButton extends android.widget.FrameLayout {
79+
@UiThread @com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI public final class MapboxExtendableButton extends android.widget.FrameLayout {
8080
ctor public MapboxExtendableButton(android.content.Context context);
8181
ctor public MapboxExtendableButton(android.content.Context context, android.util.AttributeSet? attrs);
8282
ctor public MapboxExtendableButton(android.content.Context context, android.util.AttributeSet? attrs, int defStyleAttr);

libnavui-base/src/main/java/com/mapbox/navigation/ui/base/installer/ComponentInstaller.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.mapbox.navigation.ui.base.installer
22

3+
import androidx.annotation.UiThread
34
import androidx.lifecycle.Lifecycle
45
import androidx.lifecycle.LifecycleOwner
56
import com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI
@@ -75,6 +76,7 @@ fun interface Installation {
7576
*/
7677
@ExperimentalPreviewMapboxNavigationAPI
7778
@Suppress("unused")
79+
@UiThread
7880
fun MapboxNavigationApp.installComponents(
7981
lifecycleOwner: LifecycleOwner,
8082
config: ComponentInstaller.() -> Unit
@@ -114,6 +116,7 @@ fun MapboxNavigationApp.installComponents(
114116
* ```
115117
*/
116118
@ExperimentalPreviewMapboxNavigationAPI
119+
@UiThread
117120
fun MapboxNavigation.installComponents(
118121
lifecycleOwner: LifecycleOwner,
119122
config: ComponentInstaller.() -> Unit

libnavui-base/src/main/java/com/mapbox/navigation/ui/base/lifecycle/Binder.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.mapbox.navigation.ui.base.lifecycle
22

33
import android.view.ViewGroup
4+
import androidx.annotation.UiThread
45
import com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI
56
import com.mapbox.navigation.core.MapboxNavigation
67
import com.mapbox.navigation.core.lifecycle.MapboxNavigationObserver
@@ -17,6 +18,7 @@ interface Binder<T> {
1718
* Triggered when this view binder instance is attached. The [viewGroup] returns a
1819
* [MapboxNavigationObserver] which gives this view a simple lifecycle.
1920
*/
21+
@UiThread
2022
fun bind(viewGroup: T): MapboxNavigationObserver
2123
}
2224

libnavui-base/src/main/java/com/mapbox/navigation/ui/base/view/MapboxExtendableButton.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import android.view.LayoutInflater
77
import android.widget.FrameLayout
88
import androidx.annotation.DrawableRes
99
import androidx.annotation.StyleRes
10+
import androidx.annotation.UiThread
1011
import androidx.appcompat.widget.AppCompatImageView
1112
import androidx.appcompat.widget.AppCompatTextView
1213
import androidx.constraintlayout.widget.ConstraintLayout
@@ -21,6 +22,7 @@ import com.mapbox.navigation.ui.utils.internal.extensions.measureTextWidth
2122
* Button with an icon and expand behaviour.
2223
*/
2324
@ExperimentalPreviewMapboxNavigationAPI
25+
@UiThread
2426
class MapboxExtendableButton : FrameLayout {
2527

2628
private val binding =

0 commit comments

Comments
 (0)