Skip to content

Commit a9df339

Browse files
committed
Don't remove milestone listener on arrival / adjust arrival verbiage
1 parent d3188a9 commit a9df339

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

navigation/libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/DefaultMilestones.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,6 @@ public String buildInstruction(RouteProgress routeProgress) {
194194
private String getInstructionString(RouteProgress routeProgress) {
195195
return routeProgress.currentLegProgress().upComingStep() != null
196196
? routeProgress.currentLegProgress().upComingStep().getManeuver().getInstruction() :
197-
"Arrived at your destination";
197+
"You have arrived";
198198
}
199199
}

navigation/libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/MapboxNavigation.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,6 @@ public void onProgressChange(Location location, RouteProgress routeProgress) {
603603
NavigationMetricsWrapper.arriveEvent(sessionState, routeProgress, location);
604604
// Remove all listeners except the onProgressChange by passing in null.
605605
navigationEventDispatcher.removeOffRouteListener(null);
606-
navigationEventDispatcher.removeMilestoneEventListener(null);
607606
// Remove this listener so that the arrival event only occurs once.
608607
navigationEventDispatcher.removeInternalProgressChangeListener();
609608
}

0 commit comments

Comments
 (0)