[Drop-In UI] Changes RoadName positioning and customization (#6792)

* Increased InfoPanel bottom guideline max pos to 50% of the NavigationView height and made it customizable via ViewStyleCustomization.infoPanelGuidelineMaxPosPercent.

* CHANGELOG entry

* Rename changelog files

Co-authored-by: runner <runner@fv-az465-655>

Author: 2 people

changelog/unreleased/features/6792.md

@@ -0,0 +1 @@
+- Introduced `ViewStyleCustomization.infoPanelGuidelineMaxPosPercent` that allows customization of the `NavigationView` InfoPanel bottom guideline maximum position. Increased default value to 50%.

libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/ViewStyleCustomization.kt

@@ -2,6 +2,7 @@ package com.mapbox.navigation.dropin
 
 import android.content.Context
 import androidx.annotation.DrawableRes
+import androidx.annotation.FloatRange
 import androidx.annotation.Px
 import androidx.annotation.StyleRes
 import androidx.core.content.ContextCompat
@@ -64,6 +65,14 @@ class ViewStyleCustomization {
     @DrawableRes
     var infoPanelBackground: Int? = null
 
+    /**
+     * Info panel guideline maximum position within its parent view.
+     * This value must be within 0.0f..1.0f range.
+     * Use [defaultInfoPanelGuidelineMaxPosPercent] to reset to default.
+     */
+    @FloatRange(from = 0.0, to = 1.0)
+    var infoPanelGuidelineMaxPosPercent: Float? = null
+
     /**
      * Provide custom [POINameComponent] [TextAppearance].
      * Use [defaultPoiNameTextAppearance] to reset to default.
@@ -208,6 +217,12 @@ class ViewStyleCustomization {
         @DrawableRes
         fun defaultInfoPanelBackground(): Int = R.drawable.mapbox_bg_info_panel
 
+        /**
+         * Default info panel guideline maximum position within its parent view.
+         */
+        @FloatRange(from = 0.0, to = 1.0)
+        fun defaultInfoPanelGuidelineMaxPosPercent(): Float = 0.5f
+
         /**
          * Default [PointAnnotationOptions] for showing destination marker.
          */

libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/infopanel/InfoPanelCoordinator.kt

@@ -81,6 +81,14 @@ internal class InfoPanelCoordinator(
         coroutineScope.launch {
             context.systemBarsInsets.collect { updateGuidelinePosition(systemBarsInsets = it) }
         }
+        coroutineScope.launch {
+            context.styles.infoPanelGuidelineMaxPosPercent.collect {
+                updateGuidelinePosition(maxPosPercent = it)
+            }
+        }
+        coroutineScope.launch {
+            infoPanelTop.collect { updateGuidelinePosition(infoPanelTop = it) }
+        }
         coroutineScope.launch {
             context.options.isInfoPanelHideable.collect { hideable ->
                 if (behavior.state != BottomSheetBehavior.STATE_HIDDEN) {
@@ -95,9 +103,6 @@ internal class InfoPanelCoordinator(
         coroutineScope.launch {
             bottomSheetPeekHeight().collect { behavior.peekHeight = it }
         }
-        coroutineScope.launch {
-            infoPanelTop.collect { updateGuidelinePosition(infoPanelTop = it) }
-        }
     }
 
     override fun onDetached(mapboxNavigation: MapboxNavigation) {
@@ -158,11 +163,14 @@ internal class InfoPanelCoordinator(
     private fun updateGuidelinePosition(
         systemBarsInsets: Insets = context.systemBarsInsets.value,
         infoPanelTop: Int = infoPanel.top,
+        maxPosPercent: Float = context.styles.infoPanelGuidelineMaxPosPercent.value
     ) {
         val parentHeight = (infoPanel.parent as ViewGroup).height
-        val maxPos = (parentHeight * GUIDELINE_MAX_POSITION_PERCENT).toInt()
-        val pos = parentHeight - infoPanelTop - systemBarsInsets.bottom
-        guidelineBottom.setGuidelineEnd(pos.coerceIn(0, maxPos))
+        val maxPos = (parentHeight * maxPosPercent).toInt() - systemBarsInsets.bottom
+        if (0 < maxPos) {
+            val pos = parentHeight - infoPanelTop - systemBarsInsets.bottom
+            guidelineBottom.setGuidelineEnd(pos.coerceIn(0, maxPos))
+        }
     }
 
     private fun resetSlideOffset(prevBottomSheetState: Int, bottomSheetState: Int) {
@@ -206,12 +214,4 @@ internal class InfoPanelCoordinator(
             }
         }
     }
-
-    private companion object {
-        /**
-         * Guideline bottom maximum position within its parent view.
-         * This value must be within 0.0f..1.0f range.
-         */
-        const val GUIDELINE_MAX_POSITION_PERCENT = 0.3f
-    }
 }

libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/navigationview/NavigationViewStyles.kt

@@ -19,6 +19,8 @@ internal class NavigationViewStyles(context: Context) {
         MutableStateFlow(ViewStyleCustomization.defaultInfoPanelMarginEnd())
     private val _infoPanelBackground: MutableStateFlow<Int> =
         MutableStateFlow(ViewStyleCustomization.defaultInfoPanelBackground())
+    private val _infoPanelGuidelineMaxPosPercent: MutableStateFlow<Float> =
+        MutableStateFlow(ViewStyleCustomization.defaultInfoPanelGuidelineMaxPosPercent())
     private val _poiNameTextAppearance: MutableStateFlow<Int> =
         MutableStateFlow(ViewStyleCustomization.defaultPoiNameTextAppearance())
     private val _tripProgressStyle: MutableStateFlow<Int> =
@@ -60,6 +62,8 @@ internal class NavigationViewStyles(context: Context) {
     val infoPanelMarginStart: StateFlow<Int> = _infoPanelMarginStart.asStateFlow()
     val infoPanelMarginEnd: StateFlow<Int> = _infoPanelMarginEnd.asStateFlow()
     val infoPanelBackground: StateFlow<Int> = _infoPanelBackground.asStateFlow()
+    val infoPanelGuidelineMaxPosPercent: StateFlow<Float> =
+        _infoPanelGuidelineMaxPosPercent.asStateFlow()
     val poiNameTextAppearance: StateFlow<Int> = _poiNameTextAppearance.asStateFlow()
     val tripProgressStyle: StateFlow<Int> = _tripProgressStyle.asStateFlow()
 
@@ -86,6 +90,9 @@ internal class NavigationViewStyles(context: Context) {
         customization.infoPanelMarginStart?.also { _infoPanelMarginStart.value = it }
         customization.infoPanelMarginEnd?.also { _infoPanelMarginEnd.value = it }
         customization.infoPanelBackground?.also { _infoPanelBackground.value = it }
+        customization.infoPanelGuidelineMaxPosPercent?.also {
+            _infoPanelGuidelineMaxPosPercent.value = it.coerceIn(0.0f, 1.0f)
+        }
         customization.poiNameTextAppearance?.also { _poiNameTextAppearance.value = it }
         customization.tripProgressStyle?.also { _tripProgressStyle.value = it }
 

libnavui-dropin/src/test/java/com/mapbox/navigation/dropin/navigationview/NavigationViewStylesTest.kt

@@ -37,6 +37,7 @@ class NavigationViewStylesTest {
         assertEquals(c.infoPanelMarginStart, sut.infoPanelMarginStart.value)
         assertEquals(c.infoPanelMarginEnd, sut.infoPanelMarginEnd.value)
         assertEquals(c.infoPanelBackground, sut.infoPanelBackground.value)
+        assertEquals(c.infoPanelGuidelineMaxPosPercent, sut.infoPanelGuidelineMaxPosPercent.value)
         assertEquals(c.poiNameTextAppearance, sut.poiNameTextAppearance.value)
         assertEquals(c.tripProgressStyle, sut.tripProgressStyle.value)
         assertEquals(c.compassButtonStyle, sut.compassButtonStyle.value)
@@ -59,11 +60,29 @@ class NavigationViewStylesTest {
         assertEquals(c.locationPuckOptions, sut.locationPuckOptions.value)
     }
 
+    @Test
+    fun `applyCustomization should clamp infoPanelGuidelineMaxPosPercent value`() {
+        sut.applyCustomization(
+            ViewStyleCustomization().apply {
+                infoPanelGuidelineMaxPosPercent = -0.1f
+            }
+        )
+        assertEquals(0.0f, sut.infoPanelGuidelineMaxPosPercent.value)
+
+        sut.applyCustomization(
+            ViewStyleCustomization().apply {
+                infoPanelGuidelineMaxPosPercent = 1.1f
+            }
+        )
+        assertEquals(1.0f, sut.infoPanelGuidelineMaxPosPercent.value)
+    }
+
     private fun customization() = ViewStyleCustomization().apply {
         infoPanelPeekHeight = 1
         infoPanelMarginStart = 2
         infoPanelMarginEnd = 3
         infoPanelBackground = android.R.drawable.spinner_background
+        infoPanelGuidelineMaxPosPercent = 0.25f
         poiNameTextAppearance = android.R.style.TextAppearance_DeviceDefault_Large
         tripProgressStyle = R.style.MapboxStyleTripProgressView
         compassButtonStyle = R.style.MapboxStyleExtendableButton_Circle