make RouteShieldCallback methods with UiThread annotation

dzinad · dzinad · commit ca886f50da36 · 2022-10-11T16:25:50.000+03:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@ Mapbox welcomes participation and contributions from everyone.
 - Marked `MapboxSpeedLimitView`, `MapboxStatusView`, `MapboxTripProgressView`, `MapboxSoundButton` methods with `@UiThread` annotation. [#6272](https://github.com/mapbox/mapbox-navigation-android/pull/6272)
 - Marked `InfoPanelBinder`, `NavigationView`, `NavigationViewApi` methods with `@UiThread` annotation. [#6269](https://github.com/mapbox/mapbox-navigation-android/pull/6269)
 - Marked `MapboxExitText`, `MapboxLaneGuidance`, `MapboxLaneGuidanceAdapter`, `MapboxManeuverView`, `MapboxPrimaryManeuver`, `MapboxSecondaryManeuver`, `MapboxStepDistance`, `MapboxSubManeuver`, `MapboxTurnIconManeuver`, `MapboxUpcomingManeuverAdapter` methods with `@UiThread` annotation. [#6270](https://github.com/mapbox/mapbox-navigation-android/pull/6270)
+- Marked `RouteShieldCallback` methods with `@UiThread` annotation. [#6271](https://github.com/mapbox/mapbox-navigation-android/pull/6271)
 
 ## Mapbox Navigation SDK 2.9.0-beta.1 - 06 October, 2022
 ### Changelog
diff --git a/libnavui-shield/api/current.txt b/libnavui-shield/api/current.txt
@@ -39,7 +39,7 @@ package com.mapbox.navigation.ui.shield.model {
   }
 
   public fun interface RouteShieldCallback {
-    method public void onRoadShields(java.util.List<? extends com.mapbox.bindgen.Expected<com.mapbox.navigation.ui.shield.model.RouteShieldError,com.mapbox.navigation.ui.shield.model.RouteShieldResult>> shields);
+    method @UiThread public void onRoadShields(java.util.List<? extends com.mapbox.bindgen.Expected<com.mapbox.navigation.ui.shield.model.RouteShieldError,com.mapbox.navigation.ui.shield.model.RouteShieldResult>> shields);
   }
 
   public final class RouteShieldError {
diff --git a/libnavui-shield/src/main/java/com/mapbox/navigation/ui/shield/model/RouteShieldCallback.kt b/libnavui-shield/src/main/java/com/mapbox/navigation/ui/shield/model/RouteShieldCallback.kt
@@ -1,6 +1,7 @@
 package com.mapbox.navigation.ui.shield.model
 
 import android.graphics.Bitmap
+import androidx.annotation.UiThread
 import com.mapbox.bindgen.Expected
 
 /**
@@ -18,6 +19,7 @@ fun interface RouteShieldCallback {
      *
      * @param shields list of [Expected] wither containing [RouteShieldError] or [RouteShieldResult]
      */
+    @UiThread
     fun onRoadShields(
         shields: List<Expected<RouteShieldError, RouteShieldResult>>
     )

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ package com.mapbox.navigation.ui.shield.model {`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`public fun interface RouteShieldCallback {`
`42`		`- method public void onRoadShields(java.util.List<? extends com.mapbox.bindgen.Expected<com.mapbox.navigation.ui.shield.model.RouteShieldError,com.mapbox.navigation.ui.shield.model.RouteShieldResult>> shields);`
	`42`	`+ method @UiThread public void onRoadShields(java.util.List<? extends com.mapbox.bindgen.Expected<com.mapbox.navigation.ui.shield.model.RouteShieldError,com.mapbox.navigation.ui.shield.model.RouteShieldResult>> shields);`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`public final class RouteShieldError {`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`package com.mapbox.navigation.ui.shield.model`
`2`	`2`
`3`	`3`	`import android.graphics.Bitmap`
	`4`	`+import androidx.annotation.UiThread`
`4`	`5`	`import com.mapbox.bindgen.Expected`
`5`	`6`
`6`	`7`	`/**`
`@@ -18,6 +19,7 @@ fun interface RouteShieldCallback {`
`18`	`19`	`*`
`19`	`20`	`* @param shields list of [Expected] wither containing [RouteShieldError] or [RouteShieldResult]`
`20`	`21`	`*/`
	`22`	`+ @UiThread`
`21`	`23`	`fun onRoadShields(`
`22`	`24`	`shields: List<Expected<RouteShieldError, RouteShieldResult>>`
`23`	`25`	`)`