Skip to content

Commit cefe454

Browse files
jushgithub-actions[bot]
authored andcommitted
Ktlint
GitOrigin-RevId: dce9c20d2b6b3bd1e0ab2eefa6f4d3f68083b059
1 parent 0334774 commit cefe454

6 files changed

Lines changed: 66 additions & 36 deletions

File tree

ui-maps/src/main/java/com/mapbox/navigation/ui/maps/internal/route/line/RouteLineDataConverter.kt

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,20 @@ private suspend fun RouteLineDynamicData.toData(
130130
return RouteLineDynamicEventData(
131131
baseExpressionCommandHolder.toRouteLineExpressionEventData(workerCoroutineContext, data),
132132
casingExpressionCommandHolder.toRouteLineExpressionEventData(workerCoroutineContext, data),
133-
trafficExpressionCommandHolder?.toRouteLineExpressionEventData(workerCoroutineContext, data),
134-
restrictedSectionExpressionCommandHolder?.toRouteLineExpressionEventData(workerCoroutineContext, data),
133+
trafficExpressionCommandHolder?.toRouteLineExpressionEventData(
134+
workerCoroutineContext,
135+
data,
136+
),
137+
restrictedSectionExpressionCommandHolder?.toRouteLineExpressionEventData(
138+
workerCoroutineContext,
139+
data,
140+
),
135141
trimOffset,
136142
trailExpressionCommandHolder?.toRouteLineExpressionEventData(workerCoroutineContext, data),
137-
trailCasingExpressionCommandHolder?.toRouteLineExpressionEventData(workerCoroutineContext, data),
143+
trailCasingExpressionCommandHolder?.toRouteLineExpressionEventData(
144+
workerCoroutineContext,
145+
data,
146+
),
138147
blurExpressionCommandHolder?.toRouteLineExpressionEventData(workerCoroutineContext, data),
139148
)
140149
}

ui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/RouteLineHistoryRecordingPusher.kt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,9 @@ internal class RouteLineHistoryRecordingPusher(
6969
recorder = null
7070
}
7171

72-
fun pushEventOrAddToQueue(@WorkerThread eventFormer: suspend (CoroutineContext) -> RouteLineEvent) {
72+
fun pushEventOrAddToQueue(
73+
@WorkerThread eventFormer: suspend (CoroutineContext) -> RouteLineEvent,
74+
) {
7375
val recorderCopy = recorder
7476
if (recorderCopy == null) {
7577
eventsQueue.add(eventFormer)
@@ -96,7 +98,10 @@ internal class RouteLineHistoryRecordingPusher(
9698
}
9799
}
98100

99-
fun pushEventIfEnabled(@WorkerThread eventFormer: suspend (CoroutineContext) -> RouteLineEvent) {
101+
fun pushEventIfEnabled(
102+
@WorkerThread
103+
eventFormer: suspend (CoroutineContext) -> RouteLineEvent,
104+
) {
100105
recorder?.let { pushEvent(it, eventFormer) }
101106
}
102107
}

ui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/RouteLineHistoryRecordingViewSender.kt

Lines changed: 28 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -66,34 +66,11 @@ internal class RouteLineHistoryRecordingViewSender : RouteLineHistoryRecordingIn
6666
value: Expected<RouteLineError, RouteSetValue>,
6767
) {
6868
options.also { data ->
69-
RouteLineHistoryRecordingPusherProvider.instance.pushEventIfEnabled { workerCoroutineContext ->
70-
RouteLineViewEvent(
71-
instanceId,
72-
RouteLineViewRenderRouteDrawDataValue(
73-
styleId,
74-
value.toInput {
75-
if (data == null) {
76-
RouteLineViewDataError("NoOptions")
77-
} else {
78-
toEventValue(workerCoroutineContext, data)
79-
}
80-
},
81-
),
82-
)
83-
}
84-
}
85-
}
86-
87-
fun sendRenderRouteLineUpdateEvent(
88-
styleId: String?,
89-
value: Expected<RouteLineError, RouteLineUpdateValue>,
90-
) {
91-
options.also { data ->
92-
if (value.isValue) {
93-
RouteLineHistoryRecordingPusherProvider.instance.pushEventIfEnabled { workerCoroutineContext ->
69+
RouteLineHistoryRecordingPusherProvider.instance
70+
.pushEventIfEnabled { workerCoroutineContext ->
9471
RouteLineViewEvent(
9572
instanceId,
96-
RouteLineViewRenderRouteLineUpdateValue(
73+
RouteLineViewRenderRouteDrawDataValue(
9774
styleId,
9875
value.toInput {
9976
if (data == null) {
@@ -105,6 +82,31 @@ internal class RouteLineHistoryRecordingViewSender : RouteLineHistoryRecordingIn
10582
),
10683
)
10784
}
85+
}
86+
}
87+
88+
fun sendRenderRouteLineUpdateEvent(
89+
styleId: String?,
90+
value: Expected<RouteLineError, RouteLineUpdateValue>,
91+
) {
92+
options.also { data ->
93+
if (value.isValue) {
94+
RouteLineHistoryRecordingPusherProvider.instance
95+
.pushEventIfEnabled { workerCoroutineContext ->
96+
RouteLineViewEvent(
97+
instanceId,
98+
RouteLineViewRenderRouteLineUpdateValue(
99+
styleId,
100+
value.toInput {
101+
if (data == null) {
102+
RouteLineViewDataError("NoOptions")
103+
} else {
104+
toEventValue(workerCoroutineContext, data)
105+
}
106+
},
107+
),
108+
)
109+
}
108110
}
109111
}
110112
}

ui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/api/RouteLineCommandProvider.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ internal fun interface RouteLineCommandProvider<T, R> {
1717
suspend fun generateCommand(workerCoroutineContext: CoroutineContext, input: R): T
1818
}
1919

20-
internal abstract class RouteLineValueProvider : RouteLineCommandProvider<StylePropertyValue, RouteLineViewOptionsData>
20+
internal abstract class RouteLineValueProvider :
21+
RouteLineCommandProvider<StylePropertyValue, RouteLineViewOptionsData>
2122

2223
/**
2324
* Version of [RouteLineValueProvider] that does not use a worker context to generate the expression.

ui-maps/src/test/java/com/mapbox/navigation/ui/maps/internal/route/line/RouteLineDataConverterTest.kt

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -709,14 +709,22 @@ internal class RouteLineDataConverterTest {
709709
}
710710

711711
private suspend fun checkGradient(holder: RouteLineValueCommandHolder, exp: Expression) {
712-
holder.applier.applyCommand(style, layerId, holder.provider.generateCommand(coroutineContext, eventData))
712+
holder.applier.applyCommand(
713+
style,
714+
layerId,
715+
holder.provider.generateCommand(coroutineContext, eventData),
716+
)
713717
verify(exactly = 1) {
714718
style.setStyleLayerProperty(layerId, "line-gradient", exp)
715719
}
716720
}
717721

718722
private suspend fun checkTrimOffset(holder: RouteLineValueCommandHolder, exp: Expression) {
719-
holder.applier.applyCommand(style, layerId, holder.provider.generateCommand(coroutineContext, eventData))
723+
holder.applier.applyCommand(
724+
style,
725+
layerId,
726+
holder.provider.generateCommand(coroutineContext, eventData),
727+
)
720728
verify(exactly = 1) {
721729
style.setStyleLayerProperty(layerId, "line-trim-offset", exp)
722730
}

ui-maps/src/test/java/com/mapbox/navigation/ui/maps/route/line/api/RouteLineValueCommandHolderTest.kt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,19 @@ internal class RouteLineValueCommandHolderTest {
3939
fun toRouteLineExpressionEventData_throws() = runBlocking {
4040
val viewData = mockk<RouteLineViewOptionsData>(relaxed = true)
4141
val provider = mockk<RouteLineValueProvider>(relaxed = true) {
42-
coEvery { generateCommand(coroutineContext, viewData) } throws UnsupportedOperationException()
42+
coEvery {
43+
generateCommand(
44+
coroutineContext,
45+
viewData,
46+
)
47+
} throws UnsupportedOperationException()
4348
}
4449
val applier = mockk<RouteLineCommandApplier<StylePropertyValue>>(relaxed = true) {
4550
every { getProperty() } returns "some-property"
4651
}
4752
val data = RouteLineValueCommandHolder(provider, applier)
4853

49-
val actual = data.toRouteLineExpressionEventData(coroutineContext, viewData)
54+
val actual = data.toRouteLineExpressionEventData(coroutineContext, viewData)
5055
assertTrue(actual is RouteLineNoOpExpressionEventData)
5156
}
5257

0 commit comments

Comments
 (0)