make MapViewBinder#shouldLoadMapStyle false by default

Author: dzinad

CHANGELOG.md

@@ -7,6 +7,7 @@ Mapbox welcomes participation and contributions from everyone.
 #### Bug fixes and improvements
 - Improved precision of congestion visualization and independent leg styling transitions, especially for long routes. [#6476](https://github.com/mapbox/mapbox-navigation-android/pull/6476)
 - Fixed an issue with congestion visualization on the route line that occurred during route refreshes. [#6476](https://github.com/mapbox/mapbox-navigation-android/pull/6476)
+- Made `MapViewBinder#shouldLoadMapStyle` false by default. [#6485](https://github.com/mapbox/mapbox-navigation-android/pull/6485)
 
 ## Mapbox Navigation SDK 2.9.0-beta.2 - 14 October, 2022
 ### Changelog
@@ -37,6 +38,7 @@ binding.navigationView.customizeViewBinders {
     }
 }
 ```
+- Removed force disabling of `MapView#compass` for custom MapViews. [#6433](https://github.com/mapbox/mapbox-navigation-android/pull/6433)
 - :warning: Improved alternatives route processing. `MapboxNavigation#setNavigationRoutes` doesn't accept alternatives which don't deviate from primary route or which have different destinations. Rejected alternatives will be present in `RoutesSetSuccess.ignoredAlternatives` and won't produce `AlternativeRouteMetadata`. [#6464](https://github.com/mapbox/mapbox-navigation-android/pull/6464)
 - Fixed false detection of passed alternatives that led to their removal. [#6464](https://github.com/mapbox/mapbox-navigation-android/pull/6464)
 - Improved route matching. [#6464](https://github.com/mapbox/mapbox-navigation-android/pull/6464)

libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/map/MapViewBinder.kt

@@ -50,7 +50,7 @@ abstract class MapViewBinder : UIBinder {
      * `True` if Mapbox should load map style,
      * `false` if it will be loaded by the user or handled in any other way.
      */
-    open val shouldLoadMapStyle: Boolean = true
+    open val shouldLoadMapStyle: Boolean = false
 
     /**
      * Triggered when this view binder instance is attached. The [viewGroup] returns a

libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/map/MapboxMapViewBinder.kt

@@ -8,6 +8,8 @@ import com.mapbox.navigation.base.ExperimentalPreviewMapboxNavigationAPI
 @ExperimentalPreviewMapboxNavigationAPI
 internal class MapboxMapViewBinder : MapViewBinder() {
 
+    override val shouldLoadMapStyle: Boolean = true
+
     override fun getMapView(context: Context): MapView {
         return MapView(context).apply {
             compass.enabled = false

libnavui-dropin/src/test/java/com/mapbox/navigation/dropin/map/MapViewBinderTest.kt

@@ -53,10 +53,10 @@ import io.mockk.verify
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.FlowPreview
 import kotlinx.coroutines.flow.MutableStateFlow
+import org.junit.Assert.assertFalse
 import org.junit.Assert.assertNotEquals
 import org.junit.Assert.assertNotNull
 import org.junit.Assert.assertNull
-import org.junit.Assert.assertTrue
 import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
@@ -390,7 +390,7 @@ class MapViewBinderTest {
     }
 
     @Test
-    fun `shouldLoadMapStyle should be true`() {
-        assertTrue(sut.shouldLoadMapStyle)
+    fun `shouldLoadMapStyle should be false`() {
+        assertFalse(sut.shouldLoadMapStyle)
     }
 }

qa-test-app/src/main/java/com/mapbox/navigation/qa_test_app/view/customnavview/CustomMapViewBinder.kt

@@ -11,6 +11,4 @@ class CustomMapViewBinder : MapViewBinder() {
     override fun getMapView(context: Context): MapView {
         return customMapViewFromCode(context)
     }
-
-    override val shouldLoadMapStyle: Boolean = false
 }