fix copilot anr executing copy to and remove in a separate io thread (#6876)

Author: Pablo Guardiola

libnavigation-copilot/src/main/java/com/mapbox/navigation/copilot/HistoryAttachmentsUtils.kt

@@ -3,6 +3,8 @@ package com.mapbox.navigation.copilot
 import android.util.Base64
 import com.mapbox.navigation.copilot.internal.CopilotMetadata
 import com.mapbox.navigation.core.BuildConfig
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.withContext
 import org.json.JSONObject
 import java.io.File
 import java.text.SimpleDateFormat
@@ -60,11 +62,10 @@ internal object HistoryAttachmentsUtils {
 
     fun delete(file: File): Boolean = file.delete()
 
-    fun copyToAndRemove(from: File, filename: String): File {
-        val to = from.copyTo(File(from.parent, filename))
-        from.delete()
-        return to
-    }
+    suspend fun copyToAndRemove(from: File, filename: String): File =
+        withContext(Dispatchers.IO) {
+            File(from.parent, filename).also { from.renameTo(it) }
+        }
 
     private fun decode(str: String): JSONObject {
         val requiredLength = (str.length - 1) / 4 * 4 + 4

libnavigation-copilot/src/main/java/com/mapbox/navigation/copilot/MapboxCopilotImpl.kt

@@ -35,6 +35,8 @@ import com.mapbox.navigation.core.internal.telemetry.UserFeedbackCallback
 import com.mapbox.navigation.core.internal.telemetry.registerUserFeedbackCallback
 import com.mapbox.navigation.core.internal.telemetry.unregisterUserFeedbackCallback
 import com.mapbox.navigation.core.lifecycle.MapboxNavigationApp
+import com.mapbox.navigation.utils.internal.InternalJobControlFactory
+import kotlinx.coroutines.launch
 import java.io.File
 import java.util.Locale
 
@@ -48,6 +50,7 @@ internal class MapboxCopilotImpl(
     private val mapboxNavigation: MapboxNavigation,
 ) {
 
+    private val mainJobController by lazy { InternalJobControlFactory.createMainScopeJobControl() }
     private val activeGuidanceHistoryEvents = mutableSetOf<HistoryEventDTO>()
     private val copilotHistoryRecorder = mapboxNavigation.retrieveCopilotHistoryRecorder()
     private var currentHistoryRecordingSessionState: HistoryRecordingSessionState = Idle
@@ -277,7 +280,9 @@ internal class MapboxCopilotImpl(
         val drive = buildNavigationSession()
         stopRecording { historyFilePath ->
             if (hasFeedback || !shouldSendHistoryOnlyWithFeedback) {
-                pushHistoryFile(historyFilePath, drive)
+                mainJobController.scope.launch {
+                    pushHistoryFile(historyFilePath, drive)
+                }
             }
         }
     }
@@ -310,7 +315,7 @@ internal class MapboxCopilotImpl(
         return context.applicationInfo.flags and ApplicationInfo.FLAG_DEBUGGABLE != 0
     }
 
-    private fun pushHistoryFile(historyFilePath: String, drive: CopilotMetadata) {
+    private suspend fun pushHistoryFile(historyFilePath: String, drive: CopilotMetadata) {
         val metadata = buildAttachmentMetadata(drive)
         val uploadOptions = buildUploadOptions(historyFilePath, metadata)
         HistoryUploadWorker.uploadHistory(
@@ -335,7 +340,7 @@ internal class MapboxCopilotImpl(
         )
     }
 
-    private fun buildUploadOptions(
+    private suspend fun buildUploadOptions(
         filePath: String,
         metadata: AttachmentMetadata,
     ): UploadOptions {

libnavigation-copilot/src/test/java/com/mapbox/navigation/copilot/HistoryUploadWorkerTest.kt

@@ -18,6 +18,7 @@ import com.mapbox.navigation.copilot.internal.PushStatus
 import com.mapbox.navigation.copilot.internal.PushStatusObserver
 import com.mapbox.navigation.utils.internal.logD
 import io.mockk.Runs
+import io.mockk.coEvery
 import io.mockk.every
 import io.mockk.just
 import io.mockk.mockk
@@ -446,7 +447,7 @@ class HistoryUploadWorkerTest {
         mockkObject(HistoryAttachmentsUtils)
         val fileSlot = slot<File>()
         val mockedFile = mockk<File>(relaxed = true)
-        every { copyToAndRemove(capture(fileSlot), any()) } answers {
+        coEvery { copyToAndRemove(capture(fileSlot), any()) } coAnswers {
             every { mockedFile.absolutePath } returns fileSlot.captured.toString()
             mockedFile
         }

libnavigation-copilot/src/test/java/com/mapbox/navigation/copilot/MapboxCopilotImplTest.kt

@@ -30,8 +30,10 @@ import com.mapbox.navigation.core.internal.telemetry.UserFeedbackCallback
 import com.mapbox.navigation.core.internal.telemetry.registerUserFeedbackCallback
 import com.mapbox.navigation.core.internal.telemetry.unregisterUserFeedbackCallback
 import com.mapbox.navigation.core.lifecycle.MapboxNavigationApp
+import com.mapbox.navigation.testing.MainCoroutineRule
 import com.mapbox.navigation.utils.internal.logD
 import io.mockk.Runs
+import io.mockk.coEvery
 import io.mockk.every
 import io.mockk.just
 import io.mockk.mockk
@@ -44,6 +46,7 @@ import io.mockk.verifyOrder
 import org.junit.After
 import org.junit.Assert.assertEquals
 import org.junit.Assert.assertTrue
+import org.junit.Rule
 import org.junit.Test
 import java.io.File
 import java.util.Locale
@@ -58,6 +61,9 @@ import java.util.Locale
 @OptIn(ExperimentalPreviewMapboxNavigationAPI::class)
 class MapboxCopilotImplTest {
 
+    @get:Rule
+    val coroutineRule = MainCoroutineRule()
+
     @After
     fun teardown() {
         unmockkAll()
@@ -2458,7 +2464,7 @@ class MapboxCopilotImplTest {
         mockkObject(HistoryAttachmentsUtils)
         val fileSlot = slot<File>()
         val mockedFile = mockk<File>(relaxed = true)
-        every { copyToAndRemove(capture(fileSlot), any()) } answers {
+        coEvery { copyToAndRemove(capture(fileSlot), any()) } coAnswers {
             every { mockedFile.absolutePath } returns fileSlot.captured.toString()
             mockedFile
         }