refactor: extract handleValidationError helper and include error details in validation failures

Author: zmofei

src/tools/MapboxApiBasedTool.ts

@@ -217,6 +217,18 @@ export abstract class MapboxApiBasedTool<
     };
   }
 
+  protected handleValidationError(error: unknown): CallToolResult {
+    return {
+      isError: true,
+      content: [
+        {
+          type: 'text',
+          text: `Unexpected API response format from Mapbox API: ${error instanceof Error ? error.message : 'Unknown validation error'}`
+        }
+      ]
+    };
+  }
+
   /**
    * Tool logic to be implemented by subclasses.
    * Must return a complete OutputSchema with content and optional structured content.

src/tools/create-token-tool/CreateTokenTool.ts

@@ -95,16 +95,8 @@ export class CreateTokenTool extends MapboxApiBasedTool<
     let data;
     try {
       data = CreateTokenOutputSchema.parse(rawData);
-    } catch {
-      return {
-        isError: true,
-        content: [
-          {
-            type: 'text',
-            text: 'Unexpected API response format from Mapbox API'
-          }
-        ]
-      };
+    } catch (validationError) {
+      return this.handleValidationError(validationError);
     }
 
     this.log('info', `CreateTokenTool: Successfully created token`);

src/tools/list-styles-tool/ListStylesTool.ts

@@ -73,16 +73,8 @@ export class ListStylesTool extends MapboxApiBasedTool<
     let validatedData;
     try {
       validatedData = StylesArraySchema.parse(rawData);
-    } catch {
-      return {
-        isError: true,
-        content: [
-          {
-            type: 'text',
-            text: 'Unexpected API response format from Mapbox API'
-          }
-        ]
-      };
+    } catch (validationError) {
+      return this.handleValidationError(validationError);
     }
 
     this.log('info', `ListStylesTool: Successfully listed styles`);

src/tools/list-tokens-tool/ListTokensTool.ts

@@ -133,16 +133,8 @@ export class ListTokensTool extends MapboxApiBasedTool<
         let validatedTokens;
         try {
           validatedTokens = TokenObjectSchema.array().parse(tokens);
-        } catch {
-          return {
-            isError: true,
-            content: [
-              {
-                type: 'text',
-                text: 'Unexpected API response format from Mapbox API'
-              }
-            ]
-          };
+        } catch (validationError) {
+          return this.handleValidationError(validationError);
         }
 
         allTokens.push(...validatedTokens);

src/tools/retrieve-style-tool/RetrieveStyleTool.ts

@@ -57,16 +57,8 @@ export class RetrieveStyleTool extends MapboxApiBasedTool<
     let data: MapboxStyleOutput;
     try {
       data = MapboxStyleOutputSchema.parse(rawData);
-    } catch {
-      return {
-        isError: true,
-        content: [
-          {
-            type: 'text',
-            text: 'Unexpected API response format from Mapbox API'
-          }
-        ]
-      };
+    } catch (validationError) {
+      return this.handleValidationError(validationError);
     }
 
     this.log(

src/tools/tilequery-tool/TilequeryTool.ts

@@ -84,16 +84,8 @@ export class TilequeryTool extends MapboxApiBasedTool<
     let data: TilequeryResponse;
     try {
       data = TilequeryResponseSchema.parse(rawData);
-    } catch {
-      return {
-        isError: true,
-        content: [
-          {
-            type: 'text',
-            text: 'Unexpected API response format from Mapbox API'
-          }
-        ]
-      };
+    } catch (validationError) {
+      return this.handleValidationError(validationError);
     }
 
     this.log(

src/tools/update-style-tool/UpdateStyleTool.ts

@@ -67,16 +67,8 @@ export class UpdateStyleTool extends MapboxApiBasedTool<
     let data: MapboxStyleOutput;
     try {
       data = MapboxStyleOutputSchema.parse(rawData);
-    } catch {
-      return {
-        isError: true,
-        content: [
-          {
-            type: 'text',
-            text: 'Unexpected API response format from Mapbox API'
-          }
-        ]
-      };
+    } catch (validationError) {
+      return this.handleValidationError(validationError);
     }
 
     this.log('info', `UpdateStyleTool: Successfully updated style ${data.id}`);