Support authentication token parameter for Mapbox API tools#6
Merged
Conversation
zmofei
changed the title
zmofei
changed the title
- Add support for passing authentication tokens via MCP request context - Modified BaseTool to accept and pass through authentication tokens - Update all Mapbox API tools to use provided token or fall back to env variable - Fix failing tests related to token validation - Simplify execute method signature by removing unused extra parameter
| async run(rawInput: unknown): Promise<z.infer<typeof OutputSchema>> { | ||
| async run( | ||
| rawInput: unknown, | ||
| extra?: RequestHandlerExtra<any, any> |
There was a problem hiding this comment.
@zmofei , can we have this somehow in the base class so that we don't need to pass it to every tool?
this supposed to remove some code duplication.
run could store token in a property and exec simply use it as it was with MAPBOX_ACCESS_TOKEN
ivan-yankavets
left a comment
ivan-yankavets
left a comment
There was a problem hiding this comment.
It would be better to move some of the code to the base method,
but i'm good with everything else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for passing authentication tokens to Mapbox API tools through the MCP protocol, enabling Bearer token authentication as an alternative to environment variables.
Changes
How it works
Tools now support two authentication methods:
This enables more flexible authentication when using the tools through MCP clients that support Bearer authentication.