Implement ClonableUndoCommand for object commands (undo/redo)#4436
Open
abhinavs1920 wants to merge 1 commit into
Open
Implement ClonableUndoCommand for object commands (undo/redo)#4436abhinavs1920 wants to merge 1 commit into
abhinavs1920 wants to merge 1 commit into
Conversation
Signed-off-by: Abhinav Sharma <abhinavs1920bpl@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3471
Problem
When Automapping rules placed both tiles and objects, you had to press Ctrl+Z multiple times (2-3 times) to fully undo the operation. Tiles-only rules worked fine with a single undo.
Solution
Implemented the
ClonableUndoCommandinterface inAddMapObjectsandRemoveMapObjects. This allows the undo system to properly clone and merge object commands, so they undo together with tiles in a single step.###Changes
src/tiled/addremovemapobject.h- Added interface inheritance and method declarationssrc/tiled/addremovemapobject.cpp- Implementedclone()andmergeWith()methods with proper ownership transferI am adding screenshots produced by my manual testing, along with it tests are also added.