`from_sssom_dataframe()` ignores prior sorting

[joeflack4]

Overview

I'm doing msdf: MappingSetDataFrame = from_sssom_dataframe(df, prefix_map, metadata), but I notice I lose my sorting.

I had a siimlarity_score column sorted from highest to lowest, but the resulting msdf.df appeared to have no sorting (at least not on this column).

[matentzn]

Yes that is true.. Un-very-fortunately the from_sssom_dataframe code cycles through the LinkML intermediate model (which makes this process also much slower):

mapping_set = _get_mapping_set_from_df(df=df, meta=meta)
doc = MappingSetDocument(mapping_set=mapping_set, converter=converter)
return to_mapping_set_dataframe(doc)

So we create a linkml representation (using python dataclasses) in _get_mapping_set_from_df, then producing the mapping set data frame in to_mapping_set_dataframe. All sorting will be lost. Adding it back would be hacky:

keep_sort_order = ...

....

mapping_set = _get_mapping_set_from_df(df=df, meta=meta)
doc = MappingSetDocument(mapping_set=mapping_set, converter=converter)
msdf = to_mapping_set_dataframe(doc)

if keep_sort_order:
    msdf.df = msdf.df.reindex(df.index)

I don't know...