Skip to content

Add SSSOM rewire to rewire method#403

Draft
matentzn wants to merge 4 commits into
masterfrom
add-sssom-rewire
Draft

Add SSSOM rewire to rewire method#403
matentzn wants to merge 4 commits into
masterfrom
add-sssom-rewire

Conversation

@matentzn

@matentzn matentzn commented Aug 3, 2023

Copy link
Copy Markdown
Collaborator

This PR introduces the possibility of rewiring an SSSOM table based on another SSSOM table. This is in scope for sssom-py because of the complex handing of SSSOM mapping set metadata.

@matentzn

matentzn commented Aug 3, 2023

Copy link
Copy Markdown
Collaborator Author

@ehartley would you be interested to take this on? I created the basic outline of the method (without testing anything of course).

This will solve the sssom- rewiring problem at least. We can think of a generic client later, but note that due to the possibly complex handling of prefix map and metadata it makes sense to have a solid solution here as well.

@ehartley

ehartley commented Aug 3, 2023

Copy link
Copy Markdown

@matentzn yes, I can take this on.

@matentzn

matentzn commented Aug 3, 2023

Copy link
Copy Markdown
Collaborator Author

Super!

@cthoyt

cthoyt commented Sep 19, 2023

Copy link
Copy Markdown
Member

#426 is about fixing the reconciliation code, which also effectively includes the solution to this

@matentzn

Copy link
Copy Markdown
Collaborator Author

@cthoyt Amazing! Ok then. @ehartley hold off then on any further thinking in this direction, lets wait for Charlie to tell us what, if anything, will be needed on top of his insane work right now :) Thanks @cthoyt

@cthoyt

cthoyt commented Sep 27, 2023

Copy link
Copy Markdown
Member

@ehartley I added the code that standardizes a MSDF based on recent updates. You can continue on here. I realize I may have misunderstood what was going on here before, so I highly suggest writing several clear, explicit examples as unit tests before starting any implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants