Testing sssom-schema update#511
Draft
hrshdhgd wants to merge 10 commits into
Draft
Conversation
Contributor
Author
|
Updates:
|
matentzn
reviewed
Apr 2, 2024
| python = "^3.9" | ||
| click = ">=8.1.7" | ||
| curies = ">=0.7.8" | ||
| pandas = ">=2.2.1" |
Collaborator
There was a problem hiding this comment.
Will this cause a problem like it did with #432
Contributor
There was a problem hiding this comment.
It might, but we can solve it on the cat-merge / kgx side this time, I say go for it
| pyyaml = "^6.0.1" | ||
| rdflib = ">=6.0.0" | ||
| PyYAML = "^6.0.1" | ||
| rdflib = ">=7.0.0" |
Contributor
Author
There was a problem hiding this comment.
might as well if it isn't breaking for us.
Contributor
Author
matentzn
requested changes
Apr 4, 2024
matentzn
left a comment
matentzn
left a comment
Collaborator
There was a problem hiding this comment.
I moved this to draft mode because:
- I am worried of breaking the monarch pipelines again with pandas 2
- Chris suggests to introduce 3.9+ dependencies in a separate release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the steps that were followed in this branch
sssom convert https://raw.githubusercontent.com/mapping-commons/sssom-py/master/tests/data/basic.tsv -o tests/data/basic.sssom2.rdf -O rdfself.rdf_graph_file = f"{test_data_dir}/basic.sssom2.rdf"pytest tests/test_parsers.py -k test_parse_sssom_rdfsssom-schemato 0.15.0 [poetry add sssom-schema@0.15.0]pytest tests/test_parsers.py -k test_parse_sssom_rdfagain