Skip to content

fix initial filters bug on review table #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CollinBeczak merged 1 commit into from
Jun 19, 2025
Merged

fix initial filters bug on review table #2678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 8 additions & 23 deletions src/components/HOCs/WithReviewTasks/WithReviewTasks.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,28 +82,14 @@ export const WithReviewTasks = function (WrappedComponent) {
searchOnCriteria.invertFields = this.state.criteria[props.reviewTasksType].invertFields;
}

// Only apply defaults that would affect the URL if we're not skipping URL update
// This prevents adding default parameters to the URL on initial load
if (!skipURLUpdate) {
if (searchOnCriteria.savedChallengesOnly === undefined) {
searchOnCriteria.savedChallengesOnly =
this.state.criteria[this.props.reviewTasksType]?.savedChallengesOnly;
}
if (searchOnCriteria.excludeOtherReviewers === undefined) {
// Exclude reviews assigned to other reviewers by default
searchOnCriteria.excludeOtherReviewers =
this.state.criteria[this.props.reviewTasksType]?.excludeOtherReviewers ?? true;
}
} else {
// On initial load, preserve the original values or use existing state values
if (searchOnCriteria.savedChallengesOnly === undefined) {
searchOnCriteria.savedChallengesOnly =
this.state.criteria[this.props.reviewTasksType]?.savedChallengesOnly ?? false;
}
if (searchOnCriteria.excludeOtherReviewers === undefined) {
searchOnCriteria.excludeOtherReviewers =
this.state.criteria[this.props.reviewTasksType]?.excludeOtherReviewers ?? true;
}
if (searchOnCriteria.savedChallengesOnly === undefined) {
searchOnCriteria.savedChallengesOnly =
this.state.criteria[this.props.reviewTasksType]?.savedChallengesOnly;
}
if (searchOnCriteria.excludeOtherReviewers === undefined) {
// Exclude reviews assigned to other reviewers by default
searchOnCriteria.excludeOtherReviewers =
this.state.criteria[this.props.reviewTasksType]?.excludeOtherReviewers ?? true;
}

// We need to update our list of challenges since some challenges may
Expand Down Expand Up @@ -215,7 +201,6 @@ export const WithReviewTasks = function (WrappedComponent) {
);
}
this.setState({ criteria: stateCriteria });
this.update(this.props, criteria, true);
}

componentDidUpdate(prevProps) {
Expand Down