Fix bug where Rapid does not correctly zoom to task#2714
Merged
Conversation
Collaborator
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2639 by setting the Rapid editor's
window.location.hashonce the editor finishes loading (i.e. once thesetupRapid()promise resolves). Previously we set the hash only via the iframe'ssrcattribute. I'm not sure why setting it a second time fixes the issue, but I observed that clicking the "Reselect Task" button did correctly zoom the editor, and did so by updating the iframe'swindow.location.hash, so I figured also doing this after the editor finishes loading wouldn't hurt.