Refactor state management of table state#2725
Closed
CollinBeczak wants to merge 8 commits into
Closed
Conversation
- Simplified the default dashboard setup in ProjectDashboard.jsx by removing unnecessary constants and directly defining the filters. - Enhanced WithFilterCriteria.jsx to ensure that filter properties are only updated if they exist in the new criteria object. - Updated method names in WithReviewTasks and WithReviewTaskClusters to consistently use updateReviewCriteria. - Improved PaginationControl.jsx to use pageCount instead of totalPages for better clarity. - Introduced new columns and setupColumnTypes for TaskAnalysisTable, enhancing the table's configurability and readability. - Refactored ViewTask component to use functional component syntax and integrated WithLoadedTask HOC for better task loading management. - Adjusted TasksReviewTable to consistently use updateReviewCriteria for updating review criteria state. These changes improve code clarity, maintainability, and consistency across components.
- Updated TaskAnalysisTable to include criteria for inverting fields in the dependency array. - Refactored TaskReviewTable to utilize a new setup for configurable columns, improving clarity and maintainability. - Introduced new column definitions for TasksReviewTable, allowing for better customization and filtering options. - Improved table configuration to prevent column width resets and enhance user experience with sorting and filtering. These changes enhance the overall functionality and usability of the task review components.
…ation - Increased minimum and default widths for columns in TaskAnalysisTable and TasksReviewTable to enhance text display and prevent excessive width. - Updated column rendering logic to improve layout and sorting functionality, ensuring a better user experience. - Refactored button styles for clarity and consistency across components. These changes improve the usability and visual presentation of the task analysis and review components.
- Updated WithReviewTasks to remove legacy filter fields and ensure only necessary data is sent to the backend. - Enhanced MetricsTable with new filtering capabilities for text columns, improving user interaction and search functionality. - Refactored Inbox and Sent components to include clear filters functionality, allowing users to reset filters easily. - Improved overall table structure and pagination handling across various components for better performance and user experience. These changes enhance the usability and maintainability of the table components, providing a more intuitive interface for users.
- Simplified import statements in MetricsTable and TasksReviewTable by removing unnecessary imports. - Updated TaskAnalysisTable to enhance filter functionality by removing unused parameters in filter components. - Improved key assignment in table rendering for better performance and consistency. These changes enhance the maintainability and performance of the table components, providing a cleaner codebase.
- Updated import paths in TasksReviewTable.test.jsx for improved clarity and organization. - Moved setupColumnTypes import to align with the new structure, enhancing maintainability. These changes streamline the test file structure, contributing to better code organization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issues introduced in the react table v4 upgrade.
I simplified a lot of the styles, and the biggest thing i did was remove the filtering functionality from the frontend and put the majority of the sorting and filtering functionality in the backend.