move filtering to the data passed to the backend and fix pagination on the task analysis table#2726
Closed
CollinBeczak wants to merge 6 commits into
Closed
move filtering to the data passed to the backend and fix pagination on the task analysis table#2726CollinBeczak wants to merge 6 commits into
CollinBeczak wants to merge 6 commits into
Conversation
…n the task analysis table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issues introduced in the react table v4 upgrade.
Changes were made in the WithFilterCriteria HOC to make it easier to apply new filters and sorting to the criteria.
The PaginationControl was modified to be compatible with prop based pagination instead of that being supplied by the React Tables useTable hook.
The SearchFilter input component was modified to make consolidate the clear filter functionality and to make it somewhat type sensitive so that users cant type characters in a numbers field (this would cause the endpoint to throw an error)
Various parts of the enhanced table and task analysis table were modified to either improve styling, resolve styling bugs, transition filters, applied filters, and sorting to the criteria prop instead of using the useTable Functionality.
Once the taskAnalysis table fix is approved, i will move onto fixing the rest of the tables.