EmulatedUnitEnum should not care about values

Author: marc-mabe

src/Mabe/Enum/Cl/EmulatedUnitEnum.php

@@ -3,13 +3,12 @@
 namespace Mabe\Enum\Cl;
 
 use ArgumentCountError;
+use AssertionError;
 use BadMethodCallException;
 use LogicException;
 use ReflectionClass;
 use ReflectionClassConstant;
-use TypeError;
 use UnitEnum;
-use ValueError;
 
 /**
  * Abstract base class for emulated unit enumerations.
@@ -37,11 +36,9 @@ abstract class EmulatedUnitEnum implements UnitEnum
      */
     private static $cases = [];
 
-    /** @param int|string $value */
-    final private function __construct(string $name, $value)
+    final private function __construct(string $name)
     {
-        $this->name  = $name;
-        $this->value = $value;
+        $this->name = $name;
     }
 
     /**
@@ -149,12 +146,7 @@ private static function init(string $enumClass)
 
             $cases = [];
             foreach ($caseConstants as $name => $value) {
-                assert(
-                    \count(\array_keys($caseConstants, $value, true)) === 1,
-                    "Enum case value for {$enumClass}::{$name} is ambiguous"
-                );
-
-                $cases[$name] = new $enumClass($name, $value);
+                $cases[$name] = new $enumClass($name);
             }
 
             self::$cases[$enumClass] = $cases;

tests/BasicUnitEnumTest.php

@@ -41,7 +41,31 @@ public function testCases()
             }, null));
         }
     }
-    
+
+    public function testUnitEnumDoesNotCareAboutValue()
+    {
+        if (PHP_VERSION_ID >= 80100) {
+            $this->markTestSkipped('This test is for PHP < 8.1 only');
+        }
+
+        $class = __FUNCTION__;
+
+        eval(
+            'final class ' . $class . ' extends Mabe\Enum\Cl\EmulatedUnitEnum {'
+            . ' const TEST1 = "test";'
+            . ' const TEST2 = "test";'
+            . '}'
+        );
+
+        $test1 = $class::TEST1();
+        $test2 = $class::TEST2();
+
+        static::assertNotSame($test1, $test2);
+        static::assertSame($test1, $class::TEST1());
+        static::assertSame($test2, $class::TEST2());
+        static::assertSame([$test1, $test2], $class::cases());
+    }
+
     /* BasicUnitEnum::__callStatic() */
 
     public function testCallStaticSuccess()

tests/EnumExistsTest.php

@@ -125,7 +125,7 @@ public function testAutoloadFalse()
         $classLoader = function (string $class) use ($enumClass, &$called) {
             if ($class === $enumClass) {
                 $called++;
-                eval('final class ' . $class . ' extends Mabe\Enum\Cl\StringEnumPolyfill {}');
+                eval('final class ' . $class . ' extends Mabe\Enum\Cl\EmulatedStringEnum {}');
             }
         };