Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ abstract class DeveloperToolsInstanceSettings : PersistentStateComponent<Instanc
var expandedGroupNodeIds: MutableSet<String>? = null
private set

private val tabOrders =
ConcurrentHashMap<String, MutableList<String>>()

// -- Initialization ------------------------------------------------------ //
// -- Exposed Methods ----------------------------------------------------- //

Expand Down Expand Up @@ -70,6 +73,13 @@ abstract class DeveloperToolsInstanceSettings : PersistentStateComponent<Instanc
developerToolsConfigurations[developerToolId]?.remove(developerToolConfiguration)
}

fun getToolTabOrder(toolId: String): List<String> =
tabOrders[toolId]?.toList() ?: emptyList()

fun setToolTabOrder(toolId: String, order: List<String>) {
tabOrders[toolId] = order.toMutableList()
}

override fun getState(): InstanceState {
val stateDeveloperToolsConfigurations =
developerToolsConfigurations
Expand All @@ -86,6 +96,7 @@ abstract class DeveloperToolsInstanceSettings : PersistentStateComponent<Instanc
developerToolsConfigurations = stateDeveloperToolsConfigurations,
lastSelectedContentNodeId = lastSelectedContentNodeId.get(),
expandedGroupNodeIds = expandedGroupNodeIds?.toList(),
tabOrders = tabOrders.mapValues { it.value.toList() },
)
}

Expand Down Expand Up @@ -132,6 +143,11 @@ abstract class DeveloperToolsInstanceSettings : PersistentStateComponent<Instanc
}
}
}

tabOrders.clear()
state.tabOrders?.forEach { (toolId, order) ->
tabOrders[toolId] = order.toMutableList()
}
}

// -- Private Methods ----------------------------------------------------- //
Expand Down Expand Up @@ -181,6 +197,8 @@ abstract class DeveloperToolsInstanceSettings : PersistentStateComponent<Instanc
@get:Attribute("lastSelectedContentNodeId") var lastSelectedContentNodeId: String? = null,
@get:XCollection(style = v2, elementName = "expandedGroupNodeId")
var expandedGroupNodeIds: List<String>? = null,
@get:XCollection(style = v2, elementName = "tabOrder")
var tabOrders: Map<String, List<String>>? = null,
)

// -- Inner Type ---------------------------------------------------------- //
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@ open class DeveloperToolContentPanel(protected val developerToolNode: DeveloperT
tabs = JBTabsFactory.createTabs(developerToolNode.project, developerToolNode.parentDisposable)

developerToolNode.developerTools.forEach { addWorkbench(it) }

restoreTabOrder()

selectedDeveloperToolInstance = AtomicProperty(tabs.selectedInfo!!.castedObject())

tabs.addListener(createTabsChangedListener(), developerToolNode.parentDisposable)
Expand All @@ -142,6 +145,10 @@ open class DeveloperToolContentPanel(protected val developerToolNode: DeveloperT
newDeveloperToolInstance.instance.activated()
}
}

override fun tabsMoved() {
saveTabOrder()
}
}

private fun addWorkbench(developerToolContainer: DeveloperToolContainer) {
Expand All @@ -163,7 +170,11 @@ open class DeveloperToolContentPanel(protected val developerToolNode: DeveloperT
tabs.addTab(tabInfo)
tabs.select(tabInfo, false)
tabs.setPopupGroup(
DefaultActionGroup(createRenameWorkbenchAction()),
DefaultActionGroup(
createRenameWorkbenchAction(),
createMoveTabAction(direction = -1),
createMoveTabAction(direction = 1),
),
DeveloperToolContentPanel::class.java.name,
true,
)
Expand Down Expand Up @@ -194,6 +205,37 @@ open class DeveloperToolContentPanel(protected val developerToolNode: DeveloperT
override fun getActionUpdateThread() = ActionUpdateThread.BGT
}

private fun createMoveTabAction(direction: Int) =
object : DumbAwareAction(
if (direction < 0) "Move Left" else "Move Right",
null,
if (direction < 0) AllIcons.General.ArrowLeft else AllIcons.General.ArrowRight
) {

override fun update(e: AnActionEvent) {
val selectedInfo = tabs.selectedInfo
val currentIndex = tabs.tabs.indexOf(selectedInfo)
val targetIndex = currentIndex + direction
e.presentation.isEnabled = selectedInfo != null && targetIndex in 0 until tabs.tabCount
}

override fun actionPerformed(e: AnActionEvent) {
val selectedInfo = tabs.selectedInfo ?: return
val currentIndex = tabs.tabs.indexOf(selectedInfo)
val targetIndex = currentIndex + direction

if (targetIndex in 0 until tabs.tabCount) {
tabs.removeTab(selectedInfo)
tabs.addTab(selectedInfo, targetIndex)
tabs.select(selectedInfo, true)
saveTabOrder()
}
}

override fun getActionUpdateThread() = ActionUpdateThread.BGT
}


private fun createDestroyWorkbenchAction(developerUiTool: DeveloperUiTool, tabInfo: TabInfo) =
DestroyWorkbenchAction(
{
Expand All @@ -215,6 +257,43 @@ open class DeveloperToolContentPanel(protected val developerToolNode: DeveloperT
override fun getActionUpdateThread() = ActionUpdateThread.BGT
}

private fun restoreTabOrder() {
val savedOrder = developerToolNode.settings.getToolTabOrder(developerToolNode.id)
if (savedOrder.isEmpty()) {
return
}

val existingTabs = mutableMapOf<String, TabInfo>()
tabs.tabs.forEach { tab ->
val container = tab.`object` as DeveloperToolContainer
existingTabs[container.configuration.id.toString()] = tab
}

val orderedTabs = ArrayList<TabInfo>()

savedOrder.forEach { id ->
existingTabs[id]?.let { tab ->
orderedTabs.add(tab)
existingTabs.remove(id)
}
}

orderedTabs.addAll(existingTabs.values)

tabs.removeAllTabs()
orderedTabs.forEach { tab ->
tabs.addTab(tab)
}
}

private fun saveTabOrder() {
val order = tabs.tabs.map {
(it.`object` as DeveloperToolContainer).configuration.id.toString()
}
developerToolNode.settings.setToolTabOrder(developerToolNode.id, order)
}


// -- Inner Type ---------------------------------------------------------- //

private class DestroyWorkbenchAction(
Expand Down