Data API Migrations - Use path exists sync#49
Open
hellotoby wants to merge 3 commits into
Open
Conversation
Owner
|
Hi @hellotoby, great catch! I'd love to merge but tests are failing: see https://github.com/marcgreenstock/data-api-suite/runs/3288104728?check_suite_focus=true#step:7:165 It appears the version of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If using the data api migrations library without Typescript, migrations will fail as
fs.pathExistsreturns a promise not a boolean.Currently the migration will always fail in plain javascript projects with the error
Error: ENOENT: no such file or directory, open '/path/to/project/tsconfig.json'This PR changes the conditional to use
fs.pathExistsSyncwhich will return a boolean instead.