Fixing some items not applying their effects when dropped (a bit of a workaround way but it works)

Author: marchellcx

.gitignore

@@ -8,3 +8,4 @@
 /packages
 LabExtended.sln.DotSettings.user
 global.json
+/LabExtended.ImageConvertor/obj

LabExtended.ImageConvertor/LabExtended.ImageConvertor.csproj

@@ -2,7 +2,7 @@
 
     <PropertyGroup>
         <OutputType>Exe</OutputType>
-        <TargetFramework>net10.0</TargetFramework>
+        <TargetFramework>net9.0</TargetFramework>
         <LangVersion>preview</LangVersion>
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>

LabExtended/Extensions/ItemExtensions.cs

@@ -1,11 +1,13 @@
 using InventorySystem;
 using InventorySystem.Items;
+using InventorySystem.Items.DebugTools;
+using InventorySystem.Items.Firearms;
+using InventorySystem.Items.Keycards;
 using InventorySystem.Items.Pickups;
-
+using InventorySystem.Items.Usables.Scp1344;
 using LabExtended.API;
 using LabExtended.Utilities;
 using Mirror;
-
 using UnityEngine;
 
 #pragma warning disable CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring as nullable.
@@ -37,15 +39,15 @@ public static void ReloadPrefabs()
     /// Gets the current inventory slot of an item.
     /// </summary>
     /// <param name="item">The target item.</param>
-    /// <returns>The item slot number (1 - 8)</returns>
+    /// <returns>The item slot number (1 - 8 or 0 if the item does not have an owner)</returns>
     /// <exception cref="InvalidOperationException"></exception>
     public static byte GetInventorySlot(this ItemBase item)
     {
         if (item == null)
             throw new ArgumentNullException(nameof(item));
-        
-        if (item.Owner is null)
-            throw new InvalidOperationException("The targeted item must be owned by a player.");
+
+        if (item.Owner == null)
+            return 0;
 
         return (byte)(item.OwnerInventory.UserInventory.Items.FindKeyIndex(item.ItemSerial) + 1);
     }
@@ -189,6 +191,48 @@ public static bool TryGetRigidbody(this ItemPickupBase pickup, out Rigidbody? ri
         return itemPickupBase.GetComponent<Rigidbody>();
     }
 
+    /// <summary>
+    /// Applies effects granted to an item's owner once the item is dropped.
+    /// </summary>
+    /// <param name="item">The item to simulate drop of.</param>
+    /// <param name="keepItem">Whether or not the item should be kept in the player's inventory.</param>
+    /// <returns>true if a pickup of the item should be dropped</returns>
+    public static bool SimulateDrop(this ItemBase item, out bool keepItem)
+    {
+        keepItem = false;
+
+        if (item != null && item.Owner != null)
+        {
+            if (item is Scp1344Item scp1344 && scp1344 != null)
+            {
+                if (scp1344.Status is Scp1344Status.Deactivating)
+                {
+                    keepItem = true;
+                    return false;
+                }
+
+                if (scp1344.Status is Scp1344Status.Active)
+                {
+                    scp1344.ServerSetStatus(Scp1344Status.Dropping);
+
+                    keepItem = true;
+                    return false;
+                }
+            }
+
+            if (item is ParticleDisruptor particleDisruptor && particleDisruptor.DeleteOnDrop)
+                return false;
+
+            if (item is SingleUseKeycardItem singleUseKeycard && singleUseKeycard._destroyed)
+                return false;
+
+            if (item is RagdollMover)
+                return false;
+        }
+
+        return true;
+    }
+
     /// <summary>
     /// Freezes the specified pickup.
     /// </summary>

LabExtended/Patches/Events/Player/PlayerThrowingItemPatch.cs

@@ -67,9 +67,13 @@ private static bool Prefix(Inventory __instance, ushort itemSerial, bool tryThro
 
         CustomItemPickupBehaviour? pickupBehaviour = null;
 
-        var pickup = pickupType != item.ItemTypeId || pickupScale != Vector3.one
-            ? ExMap.SpawnItem(pickupType, player.Position, pickupScale, player.Rotation, itemSerial)
-            : player.ReferenceHub.inventory.ServerDropItem(itemSerial);
+        var spawnPickup = item.SimulateDrop(out var keepItem);
+
+        var pickup = spawnPickup 
+            ? (pickupType != item.ItemTypeId || pickupScale != Vector3.one
+                    ? ExMap.SpawnItem(pickupType, player.Position, pickupScale, player.Rotation, itemSerial)
+                    : player.ReferenceHub.inventory.ServerDropItem(itemSerial))
+            : null;
 
         __instance.SendItemsNextFrame = true;
 
@@ -88,7 +92,7 @@ private static bool Prefix(Inventory __instance, ushort itemSerial, bool tryThro
             pickupBehaviour = inventoryBehaviour.ProcessDropped(pickup, player, droppedArgs);
         }
 
-        if (item != null)
+        if (item != null && !keepItem)
             item.DestroyItem();
 
         if (pickup != null && player.Toggles.CanThrowItems && tryThrow && pickup.TryGetRigidbody(out var rigidbody))