Reworked Mirror events for some performance gain

Author: marchellcx

LabExtended/Events/Mirror/MirrorAddedObserverEventArgs.cs

@@ -9,20 +9,19 @@ namespace LabExtended.Events.Mirror
     /// </summary>
     public class MirrorAddedObserverEventArgs : MirrorIdentityEventArgs
     {
+        /// <summary>
+        /// Gets the singleton instance of the <see cref="MirrorAddedObserverEventArgs"/> class.
+        /// </summary>
+        internal static MirrorAddedObserverEventArgs Singleton { get; } = new();
+
         /// <summary>
         /// Gets the player who was added. May be null if no instance was created for this connection.
         /// </summary>
-        public ExPlayer? Observer { get; }
+        public ExPlayer? Observer { get; internal set; }
 
         /// <summary>
         /// Gets the connection of the player who was added as observer.
         /// </summary>
-        public NetworkConnectionToClient Connection { get; }
-
-        public MirrorAddedObserverEventArgs(NetworkIdentity identity, ExPlayer? observer, NetworkConnectionToClient connection) : base(identity)
-        {
-            Observer = observer;
-            Connection = connection;
-        }
+        public NetworkConnectionToClient Connection { get; internal set; }
     }
 }

LabExtended/Events/Mirror/MirrorAddingObserverEventArgs.cs

@@ -9,20 +9,19 @@ namespace LabExtended.Events.Mirror
     /// </summary>
     public class MirrorAddingObserverEventArgs : MirrorIdentityBooleanEventArgs
     {
+        /// <summary>
+        /// Gets the singleton instance of the <see cref="MirrorAddingObserverEventArgs"/> class.
+        /// </summary>
+        internal static MirrorAddingObserverEventArgs Singleton { get; } = new();
+
         /// <summary>
         /// Gets the player who should be added. May be null if no instance was created for this connection.
         /// </summary>
-        public ExPlayer? Observer { get; }
+        public ExPlayer? Observer { get; internal set; }
 
         /// <summary>
         /// Gets the connection of the player to be added as observer.
         /// </summary>
-        public NetworkConnectionToClient Connection { get; }
-
-        public MirrorAddingObserverEventArgs(NetworkIdentity identity, ExPlayer? observer, NetworkConnectionToClient connection) : base(identity)
-        {
-            Observer = observer;
-            Connection = connection;
-        }
+        public NetworkConnectionToClient Connection { get; internal set; }
     }
 }

LabExtended/Events/Mirror/MirrorDestroyedIdentityEventArgs.cs

@@ -8,13 +8,13 @@ namespace LabExtended.Events.Mirror
     public class MirrorDestroyedIdentityEventArgs : MirrorIdentityEventArgs    
     {
         /// <summary>
-        /// Gets the destroy mode.
+        /// Gets the singleton instance of the <see cref="MirrorDestroyedIdentityEventArgs"/> class.
         /// </summary>
-        public NetworkServer.DestroyMode Mode { get; }
+        internal static MirrorDestroyedIdentityEventArgs Singleton { get; } = new();
 
-        public MirrorDestroyedIdentityEventArgs(NetworkIdentity identity, NetworkServer.DestroyMode mode) : base(identity)
-        {
-            Mode = mode;
-        }
+        /// <summary>
+        /// Gets the destroy mode.
+        /// </summary>
+        public NetworkServer.DestroyMode Mode { get; internal set; }
     }
 }

LabExtended/Events/Mirror/MirrorDestroyingIdentityEventArgs.cs

@@ -8,13 +8,13 @@ namespace LabExtended.Events.Mirror
     public class MirrorDestroyingIdentityEventArgs : MirrorIdentityBooleanEventArgs
     {
         /// <summary>
-        /// Gets the destroy mode.
+        /// Gets the singleton instance of the <see cref="MirrorDestroyingIdentityEventArgs"/> class.
         /// </summary>
-        public NetworkServer.DestroyMode Mode { get; }
+        internal static MirrorDestroyingIdentityEventArgs Singleton { get; } = new();
 
-        public MirrorDestroyingIdentityEventArgs(NetworkIdentity identity, NetworkServer.DestroyMode mode) : base(identity)
-        {
-            Mode = mode;
-        }
+        /// <summary>
+        /// Gets the destroy mode.
+        /// </summary>
+        public NetworkServer.DestroyMode Mode { get; internal set; }
     }
 }

LabExtended/Events/Mirror/MirrorIdentityBooleanEventArgs.cs

@@ -5,16 +5,16 @@ namespace LabExtended.Events.Mirror
     /// <summary>
     /// Base class for Mirror events with a network identity.
     /// </summary>
-    public abstract class MirrorIdentityBooleanEventArgs : BooleanEventArgs
+    public class MirrorIdentityBooleanEventArgs : BooleanEventArgs
     {
         /// <summary>
-        /// Gets the targeted network identity.
+        /// Gets the singleton instance of the <see cref="MirrorIdentityBooleanEventArgs"/> class.
         /// </summary>
-        public NetworkIdentity Identity { get; }
+        internal static MirrorIdentityBooleanEventArgs Instance { get; } = new();
 
-        public MirrorIdentityBooleanEventArgs(NetworkIdentity identity)
-        {
-            Identity = identity;
-        }
+        /// <summary>
+        /// Gets the targeted network identity.
+        /// </summary>
+        public NetworkIdentity Identity { get; internal set; }
     }
 } 

LabExtended/Events/Mirror/MirrorIdentityEventArgs.cs

@@ -5,16 +5,16 @@ namespace LabExtended.Events.Mirror
     /// <summary>
     /// Base class for Mirror events with a network identity.
     /// </summary>
-    public abstract class MirrorIdentityEventArgs : EventArgs
+    public class MirrorIdentityEventArgs : EventArgs
     {
         /// <summary>
-        /// Gets the targeted network identity.
+        /// Gets the singleton instance of the <see cref="MirrorIdentityEventArgs"/> class.
         /// </summary>
-        public NetworkIdentity Identity { get; }
+        internal static MirrorIdentityEventArgs Instance { get; } = new();
 
-        public MirrorIdentityEventArgs(NetworkIdentity identity)
-        {
-            Identity = identity;
-        }
+        /// <summary>
+        /// Gets the targeted network identity.
+        /// </summary>
+        public NetworkIdentity Identity { get; internal set; }
     }
 }

LabExtended/Events/Mirror/MirrorRemovedObserverEventArgs.cs

@@ -9,20 +9,19 @@ namespace LabExtended.Events.Mirror
     /// </summary>
     public class MirrorRemovedObserverEventArgs : MirrorIdentityBooleanEventArgs
     {
+        /// <summary>
+        /// Gets the singleton instance of the <see cref="MirrorRemovedObserverEventArgs"/> class.
+        /// </summary>
+        internal static MirrorRemovedObserverEventArgs Singleton { get; } = new();
+
         /// <summary>
         /// Gets the player who should be removed. May be null if no instance was created for this connection.
         /// </summary>
-        public ExPlayer? Observer { get; }
+        public ExPlayer? Observer { get; internal set; }
 
         /// <summary>
         /// Gets the connection of the player to be removed as observer.
         /// </summary>
-        public NetworkConnection Connection { get; }
-
-        public MirrorRemovedObserverEventArgs(NetworkIdentity identity, ExPlayer? observer, NetworkConnection connection) : base(identity)
-        {
-            Observer = observer;
-            Connection = connection;
-        }
+        public NetworkConnection Connection { get; internal set; }
     }
 }

LabExtended/Events/Mirror/MirrorRemovingObserverEventArgs.cs

@@ -9,20 +9,19 @@ namespace LabExtended.Events.Mirror
     /// </summary>
     public class MirrorRemovingObserverEventArgs : MirrorIdentityBooleanEventArgs
     {
+        /// <summary>
+        /// Gets the singleton instance of the <see cref="MirrorRemovingObserverEventArgs"/> class.
+        /// </summary>
+        internal static MirrorRemovingObserverEventArgs Singleton { get; } = new();
+
         /// <summary>
         /// Gets the player who should be removed. May be null if no instance was created for this connection.
         /// </summary>
-        public ExPlayer? Observer { get; }
+        public ExPlayer? Observer { get; internal set; }
 
         /// <summary>
         /// Gets the connection of the player to be removed as observer.
         /// </summary>
-        public NetworkConnection Connection { get; }
-
-        public MirrorRemovingObserverEventArgs(NetworkIdentity identity, ExPlayer? observer, NetworkConnection connection) : base(identity)
-        {
-            Observer = observer;
-            Connection = connection;
-        }
+        public NetworkConnection Connection { get; internal set; }
     }
 }

LabExtended/Events/Mirror/MirrorSendingRpcEventArgs.cs

@@ -9,6 +9,11 @@ namespace LabExtended.Events.Mirror
     /// </summary>
     public class MirrorSendingRpcEventArgs : MirrorIdentityBooleanEventArgs
     {
+        /// <summary>
+        /// Gets the singleton instance of the <see cref="MirrorSendingRpcEventArgs"/> class.
+        /// </summary>
+        internal static MirrorSendingRpcEventArgs Singleton { get; } = new();
+
         /// <summary>
         /// Gets the player who will receive the RPC.
         /// </summary>
@@ -22,25 +27,16 @@ public class MirrorSendingRpcEventArgs : MirrorIdentityBooleanEventArgs
         /// <summary>
         /// Gets the behaviour sending the RPC.
         /// </summary>
-        public NetworkBehaviour Behaviour { get; }
+        public NetworkBehaviour Behaviour { get; internal set; }
 
         /// <summary>
         /// Gets the hash of the RPC method name.
         /// </summary>
-        public int RpcHash { get; }
+        public int RpcHash { get; internal set; }
 
         /// <summary>
         /// Gets the full name of the RPC method.
         /// </summary>
-        public string RpcName { get; }
-
-        public MirrorSendingRpcEventArgs(ExPlayer player, NetworkWriter writer, NetworkBehaviour behaviour, int rpcHash, string rpcName) : base(behaviour.netIdentity)
-        {
-            Player = player;
-            Writer = writer;
-            Behaviour = behaviour;
-            RpcHash = rpcHash;
-            RpcName = rpcName;
-        }
+        public string RpcName { get; internal set; }
     }
 }

LabExtended/Events/Mirror/MirrorSentRpcEventArgs.cs

@@ -9,6 +9,11 @@ namespace LabExtended.Events.Mirror
     /// </summary>
     public class MirrorSentRpcEventArgs : MirrorIdentityEventArgs
     {
+        /// <summary>
+        /// Gets the singleton instance of the <see cref="MirrorSentRpcEventArgs"/> class.
+        /// </summary>
+        internal static MirrorSentRpcEventArgs Singleton { get; } = new();
+
         /// <summary>
         /// Gets the player who received the RPC.
         /// </summary>
@@ -22,25 +27,16 @@ public class MirrorSentRpcEventArgs : MirrorIdentityEventArgs
         /// <summary>
         /// Gets the behaviour which sent the RPC.
         /// </summary>
-        public NetworkBehaviour Behaviour { get; }
+        public NetworkBehaviour Behaviour { get; internal set; }
 
         /// <summary>
         /// Gets the hash of the RPC method name.
         /// </summary>
-        public int RpcHash { get; }
+        public int RpcHash { get; internal set; }
 
         /// <summary>
         /// Gets the full name of the RPC method.
         /// </summary>
-        public string RpcName { get; }
-
-        public MirrorSentRpcEventArgs(ExPlayer player, NetworkWriter writer, NetworkBehaviour behaviour, int rpcHash, string rpcName) : base(behaviour.netIdentity)
-        {
-            Player = player;
-            Writer = writer;
-            Behaviour = behaviour;
-            RpcHash = rpcHash;
-            RpcName = rpcName;
-        }
+        public string RpcName { get; internal set; }
     }
 }