Removed unusued utilities (including the entire Generation namespace - replaced by UniqueList<T>), added docs to I think every method + general code cleanup.

Author: marchellcx

.editorconfig

@@ -0,0 +1,4 @@
+[*.cs]
+
+# CS8618: Non-nullable field must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring as nullable.
+dotnet_diagnostic.CS8618.severity = none

LabExtended.sln

@@ -1,5 +1,8 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
+# Visual Studio Version 18
+VisualStudioVersion = 18.0.11012.119 d18.0
+MinimumVisualStudioVersion = 10.0.40219.1
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "LabExtended", "LabExtended\LabExtended.csproj", "{2B2B3DCB-2B69-488F-8D9F-ACC001F4E9E2}"
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "LabExtended.ImageConvertor", "LabExtended.ImageConvertor\LabExtended.ImageConvertor.csproj", "{01637DCD-155C-4458-BEE8-1B3C1BF8149F}"
@@ -10,13 +13,19 @@ Global
 		Release|Any CPU = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(ProjectConfigurationPlatforms) = postSolution
-		{2B2B3DCB-2B69-488F-8D9F-ACC001F4E9E2}.Release|Any CPU.ActiveCfg = Release|Any CPU
-		{2B2B3DCB-2B69-488F-8D9F-ACC001F4E9E2}.Release|Any CPU.Build.0 = Release|Any CPU
 		{2B2B3DCB-2B69-488F-8D9F-ACC001F4E9E2}.Debug|Any CPU.ActiveCfg = Release|Any CPU
 		{2B2B3DCB-2B69-488F-8D9F-ACC001F4E9E2}.Debug|Any CPU.Build.0 = Release|Any CPU
+		{2B2B3DCB-2B69-488F-8D9F-ACC001F4E9E2}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{2B2B3DCB-2B69-488F-8D9F-ACC001F4E9E2}.Release|Any CPU.Build.0 = Release|Any CPU
 		{01637DCD-155C-4458-BEE8-1B3C1BF8149F}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
 		{01637DCD-155C-4458-BEE8-1B3C1BF8149F}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{01637DCD-155C-4458-BEE8-1B3C1BF8149F}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{01637DCD-155C-4458-BEE8-1B3C1BF8149F}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
+	GlobalSection(SolutionProperties) = preSolution
+		HideSolutionNode = FALSE
+	EndGlobalSection
+	GlobalSection(ExtensibilityGlobals) = postSolution
+		SolutionGuid = {CAA4E5D4-59F5-4A6A-AD9E-580E9CC46365}
+	EndGlobalSection
 EndGlobal

LabExtended/.idea/.idea.LabExtended.dir/.idea/.gitignore

@@ -2,6 +2,13 @@
 
 namespace LabExtended.API.Collections.Unsafe;
 
+/// <summary>
+/// Provides an enumerator for iterating over the elements of an UnsafeList{T} without thread safety guarantees.
+/// </summary>
+/// <remarks>This enumerator does not provide thread safety. Modifying the underlying UnsafeList{T} during
+/// enumeration may result in undefined behavior. The enumerator is intended for performance-critical scenarios where
+/// thread safety is managed externally or is not required.</remarks>
+/// <typeparam name="T">The type of elements in the collection to enumerate.</typeparam>
 public struct UnsafeEnumerator<T> : IEnumerator<T>, IEnumerator
 {
     internal static volatile IEnumerator<T> emptyEnumerator = new UnsafeEnumerator<T>();
@@ -10,6 +17,11 @@ public struct UnsafeEnumerator<T> : IEnumerator<T>, IEnumerator
     private volatile int index;
     private T? current;
 
+    /// <summary>
+    /// Initializes a new instance of the UnsafeEnumerator{T} class for the specified list.
+    /// </summary>
+    /// <param name="list">The UnsafeList{T} to enumerate. Cannot be null.</param>
+    /// <exception cref="ArgumentNullException">Thrown if the list parameter is null.</exception>
     public UnsafeEnumerator(UnsafeList<T> list)
     {
         if (list is null)
@@ -38,7 +50,7 @@ public UnsafeEnumerator(UnsafeList<T> list)
     /// <inheritdoc cref="IDisposable.Dispose"/>
     public void Dispose() { }
 
-    /// <inheritdoc cref="IEnumerator{T}.MoveNext"/>
+    /// <inheritdoc cref="IEnumerator.MoveNext"/>
     public bool MoveNext()
     {
         if (((uint)index < (uint)list.size))

LabExtended/API/Collections/Unsafe/UnsafeEnumerator.cs

@@ -4,9 +4,16 @@
 namespace LabExtended.API.Collections.Unsafe;
 
 /// <summary>
-/// An unsafe version of <see cref="List{T}"/> which ignores modifications made during enumeration. As an addition, volatile operations are allowed.
+/// Represents a high-performance, array-backed list of elements that provides fast, low-level access and manipulation
+/// without built-in thread safety or bounds checking. Intended for scenarios where maximum performance is required and
+/// the caller is responsible for ensuring correct usage.
 /// </summary>
-/// <typeparam name="T">The type of the list's object.</typeparam>
+/// <remarks>UnsafeList{T} is similar to List{T} but omits certain safety checks and thread synchronization to
+/// maximize performance. It is not thread-safe and does not perform bounds checking on all operations; callers must
+/// ensure that indices and capacities are valid. This type is suitable for advanced scenarios where the overhead of
+/// additional safety is undesirable and the caller can guarantee correct usage. Modifying the collection while
+/// enumerating it is not supported and may result in undefined behavior.</remarks>
+/// <typeparam name="T">The type of elements stored in the list.</typeparam>
 public class UnsafeList<T> : IList<T>, IList, IReadOnlyList<T>
 {
     /// <summary>

LabExtended/API/Collections/Unsafe/UnsafeList.cs

@@ -1,16 +1,21 @@
-using LabExtended.API.Collections.Unsafe;
 using LabExtended.Core;
 using LabExtended.Extensions;
 using LabExtended.Utilities.Update;
+using LabExtended.API.Collections.Unsafe;
 
 using UnityEngine;
 
 namespace LabExtended.API.Collections.Updateable;
 
 /// <summary>
-/// Represents a list of updateable elements. Wraps around <see cref="UnsafeList{T}"/>.
+/// Represents a list of elements that can be updated at a specified interval and provides events for element and list
+/// updates.
 /// </summary>
-/// <typeparam name="T">The element type.</typeparam>
+/// <remarks>The update loop is managed automatically after calling <see cref="Initialize"/>, which subscribes the
+/// list to periodic updates. The <see cref="Updated"/> event is raised after each update cycle, and the <see
+/// cref="ElementUpdated"/> event is raised for each element as it is updated. Call <see cref="Dispose"/> to unsubscribe
+/// the list from updates and release resources. This class is not thread-safe.</remarks>
+/// <typeparam name="T">The type of elements in the list. Must implement <see cref="IUpdateableElement"/>.</typeparam>
 public class UpdateableList<T> : UnsafeList<T>, IDisposable 
     where T : IUpdateableElement
 {

LabExtended/API/Collections/Updateable/UpdateableList.cs

@@ -6,8 +6,8 @@
 using InventorySystem.Items.Keycards;
 using InventorySystem.Items.Pickups;
 
-using LabExtended.Utilities.Keycards;
 using LabExtended.Extensions;
+using LabExtended.API.CustomAmmo;
 
 using UnityEngine;
 
@@ -16,10 +16,8 @@
 using PlayerRoles.FirstPersonControl;
 
 using InventorySystem.Items.Usables;
-using LabExtended.API.CustomAmmo;
 
 #pragma warning disable CS8603 // Possible null reference return.
-
 #pragma warning disable CS8625 // Cannot convert null literal to non-nullable reference type.
 
 namespace LabExtended.API.Containers;
@@ -153,7 +151,7 @@ public ItemBase? this[ushort itemSerial]
     /// Gets permissions of the currently held keycard. <i>(<see cref="DoorPermissionFlags.None"/> if the player isn't holding a keycard)</i>.
     /// </summary>
     public DoorPermissionFlags HeldKeycardPermissions =>
-        CurrentItem is KeycardItem keycardItem && keycardItem.TryGetDetail<PredefinedPermsDetail>(out var perms)
+        CurrentItem is KeycardItem keycardItem && keycardItem.Details.TryGetFirst<PredefinedPermsDetail>(out var perms)
             ? perms.Levels.Permissions
             : DoorPermissionFlags.None;
 
@@ -228,7 +226,7 @@ public DoorPermissionFlags AllKeycardPermissions
 
             foreach (var keycard in Keycards)
             {
-                if (!keycard.TryGetDetail<PredefinedPermsDetail>(out var cardPerms))
+                if (!keycard.Details.TryGetFirst<PredefinedPermsDetail>(out var cardPerms))
                     continue;
 
                 perms |= cardPerms.Levels.Permissions;
@@ -399,7 +397,7 @@ public bool HasItems(ItemType type, int count)
     public bool HasKeycardPermission(DoorPermissionFlags keycardPermissions, bool anyPermission = false)
         => Keycards.Any(card =>
         {
-            if (!card.TryGetDetail<PredefinedPermsDetail>(out var cardPerms))
+            if (!card.Details.TryGetFirst<PredefinedPermsDetail>(out var cardPerms))
                 return false;
 
             return anyPermission

LabExtended/API/Containers/InventoryContainer.cs

@@ -1,22 +1,24 @@
 using System.Reflection;
+
 using HarmonyLib;
+
 using InventorySystem;
 using InventorySystem.Items;
 using InventorySystem.Items.Armor;
+
 using LabApi.Events.Arguments.PlayerEvents;
 using LabApi.Events.Arguments.Scp914Events;
 
 using LabApi.Events.Handlers;
-using LabApi.Features.Wrappers;
 using LabExtended.API.CustomItems.Behaviours;
 
 using LabExtended.Core;
 using LabExtended.Events;
 using LabExtended.Attributes;
 using LabExtended.Events.Map;
 using LabExtended.Extensions;
+
 using LabExtended.Utilities;
-using LabExtended.Utilities.Testing.CustomItems;
 using LabExtended.Utilities.Update;
 
 using NorthwoodLib.Pools;
@@ -564,9 +566,6 @@ private static void OnDiscovered(Type type)
         if (type.GetCustomAttribute<LoaderIgnoreAttribute>() != null)
             return;
 
-        if (type == typeof(TestCustomItemHandler) && !TestCustomItemHandler.IsEnabled)
-            return;
-        
         var constructor = AccessTools.DeclaredConstructor(type);
 
         if (constructor is null)

LabExtended/API/CustomItems/CustomItemRegistry.cs

@@ -8,7 +8,6 @@
 using LabExtended.Events.Player;
 
 using LabExtended.Utilities;
-using LabExtended.Utilities.Testing.FileStorage;
 
 namespace LabExtended.API.FileStorage;
 
@@ -403,9 +402,6 @@ private static void OnDiscovered(Type type)
 
         if (type.HasAttribute<LoaderIgnoreAttribute>())
             return;
-        
-        if (type == typeof(TestFileStorageComponent) && !TestFileStorageComponent.IsEnabled)
-            return;
 
         Components.Add(type);
 

LabExtended/API/FileStorage/FileStorageManager.cs

@@ -9,22 +9,21 @@
 using LabExtended.API.RemoteAdmin.Interfaces;
 
 using LabExtended.Events;
+using LabExtended.Attributes;
 using LabExtended.Extensions;
 
 using LabExtended.Utilities.Update;
-using LabExtended.Utilities.Generation;
-
-using NorthwoodLib.Pools;
 
 using LabExtended.API.RemoteAdmin.Actions;
 using LabExtended.API.RemoteAdmin.Buttons;
 
-using LabExtended.Attributes;
-
 using NetworkManagerUtils.Dummies;
 
 using RemoteAdmin.Communication;
 
+using LabExtended.Utilities;
+using NorthwoodLib.Pools;
+
 #pragma warning disable CS8601 // Possible null reference assignment.
 #pragma warning disable CS8625 // Cannot convert null literal to non-nullable reference type.
 
@@ -50,8 +49,8 @@ public class RemoteAdminController : IDisposable
     /// </summary>
     public const string OverwatchIconPrefix = "<link=RA_OverwatchEnabled><color=white>[</color><color=#03f8fc>\uf06e</color><color=white>]</color></link> ";
 
-    private static readonly UniqueStringGenerator objectIdGenerator = new(10, false);
-    private static readonly UniqueInt32Generator listIdGenerator = new(6000, 11000);
+    private static readonly UniqueList objectIdGenerator = new();
+    private static readonly UniqueList listIdGenerator = new();
 
     // ReSharper disable once CollectionNeverUpdated.Local
     private static readonly HashSet<Type> globalObjects = new();
@@ -174,8 +173,8 @@ public void Dispose()
                     obj.OnDisabled();
                 }
 
-                objectIdGenerator.Free(obj.Id);
-                listIdGenerator.Free(obj.ListId);
+                listIdGenerator.Generated.Remove(obj.Id);
+                objectIdGenerator.Generated.Remove(obj.Id);
             }
 
             ListPool<IRemoteAdminObject>.Shared.Return(Objects);
@@ -209,8 +208,8 @@ public IRemoteAdminObject AddObject(Type objectType, string? customId = null)
 
         raObject.CustomId = customId;
 
-        raObject.Id = objectIdGenerator.Next();
-        raObject.ListId = listIdGenerator.Next();
+        raObject.Id = objectIdGenerator.GetString(10);
+        raObject.ListId = listIdGenerator.Get(() => UnityEngine.Random.Range(6000, 11000));
 
         raObject.IsActive = true;
         raObject.OnEnabled();
@@ -256,9 +255,9 @@ public void AddObject(IRemoteAdminObject remoteAdminObject)
         }
 
         if (string.IsNullOrWhiteSpace(remoteAdminObject.Id))
-            remoteAdminObject.Id = objectIdGenerator.Next();
+            remoteAdminObject.Id = objectIdGenerator.GetString(10);
 
-        remoteAdminObject.ListId = listIdGenerator.Next();
+        remoteAdminObject.ListId = listIdGenerator.Get(() => UnityEngine.Random.Range(6000, 11000));
 
         Objects.Add(remoteAdminObject);
     }
@@ -280,8 +279,8 @@ public bool RemoveObject(IRemoteAdminObject remoteAdminObject)
             remoteAdminObject.OnDisabled();
         }
 
-        objectIdGenerator.Free(remoteAdminObject.Id);
-        listIdGenerator.Free(remoteAdminObject.ListId);
+        objectIdGenerator.Generated.Remove(remoteAdminObject.Id);
+        listIdGenerator.Generated.Remove(remoteAdminObject.ListId);
 
         return Objects.Remove(remoteAdminObject);
     }