add guard in maxpool parser and kernel for kernel length and strides

Author: marchioa

Deeploy/Targets/Generic/Parsers.py

@@ -193,9 +193,13 @@ def __init__(self):
     def parseNode(self, node: gs.Node) -> bool:
 
         ret = all([
-            'ceil_mode' in node.attrs, 'kernel_shape' in node.attrs, 'pads' in node.attrs, 'strides' in node.attrs,
+            'ceil_mode' in node.attrs,
+            'kernel_shape' in node.attrs,
+            'pads' in node.attrs,
+            'strides' in node.attrs,
             len(node.inputs) == 1,
-            len(node.outputs) >= 1
+            len(node.outputs) >= 1,
+            all([stride > 0 for stride in node.attrs['strides']]),
         ])
 
         if ret:

TargetLibraries/Generic/src/MaxPool_fp32.c

@@ -11,6 +11,9 @@ void MaxPool2d_fp32_fp32_NCHW(float32_t const *__restrict__ pSrcA, uint32_t C,
                               uint32_t SP, uint32_t SQ,
                               float32_t *__restrict__ pDstC) {
 
+  if (H < P || W < Q || SP == 0 || SQ == 0) {
+    return;
+  }
   uint32_t H_out = (H - P) / SP + 1;
   uint32_t W_out = (W - Q) / SQ + 1;
 
@@ -43,6 +46,9 @@ void MaxPool2d_fp32_fp32_NCHW(float32_t const *__restrict__ pSrcA, uint32_t C,
 void MaxPool1d_fp32_fp32(float32_t const *__restrict__ pSrcA, uint32_t C,
                          uint32_t W, uint32_t K, uint32_t S,
                          float32_t *__restrict__ pDstC) {
+  if (W < K || S == 0) {
+    return;
+  }
   uint32_t W_out = (W - K) / S + 1;
   for (uint32_t c = 0; c < C; ++c) {
     for (uint32_t w_out = 0; w_out < W_out; ++w_out) {

TargetLibraries/Generic/src/MaxPool_s8.c

@@ -10,6 +10,9 @@ void MaxPool2d_s8_s8_NCHW(int8_t const *__restrict__ pSrcA, uint32_t C,
                           uint32_t H, uint32_t W, uint32_t P, uint32_t Q,
                           uint32_t SP, uint32_t SQ, int8_t *__restrict__ pDstC,
                           int32_t input_offset, int32_t output_offset) {
+  if (H < P || W < Q || SP == 0 || SQ == 0) {
+    return;
+  }
   // WIESEP: For now assume padding=0
   uint32_t H_out = (H - P) / SP + 1;
   uint32_t W_out = (W - Q) / SQ + 1;
@@ -52,6 +55,9 @@ void MaxPool2d_s8_s8_NCHW(int8_t const *__restrict__ pSrcA, uint32_t C,
 void MaxPool1d_s8_s8(int8_t const *__restrict__ pSrcA, uint32_t C, uint32_t L,
                      uint32_t K, uint32_t S, int8_t *__restrict__ pDstC,
                      int32_t input_offset, int32_t output_offset) {
+  if (L < K || S == 0) {
+    return;
+  }
   uint32_t L_out = (L - K) / S + 1;
   for (uint32_t c = 0; c < C; ++c) {
     for (uint32_t l_out = 0; l_out < L_out; ++l_out) {