fix: update tests, update interface name conflict, support isolated test db (#47)

Author: marcinpsk

.devcontainer/config/isolated_test_settings.py

@@ -0,0 +1,24 @@
+# SPDX-License-Identifier: Apache-2.0
+# Copyright (C) 2025 Marcin Zieba <marcinpsk@gmail.com>
+#
+# Isolated test-database settings shim.
+#
+# Django names the test database ``test_<DB_NAME>`` (here: ``test_netbox``), so two
+# ``manage.py test`` runs in the same devcontainer collide on a single test DB and
+# corrupt each other's migrations (and a crashed run can leave an
+# ``idle in transaction`` connection holding locks that wedges every later run).
+#
+# This shim imports the fully-assembled NetBox settings and, when ``TEST_DB_NAME``
+# is set, points the test database at that name — so each session/plugin can run on
+# its own isolated test DB inside the same Postgres/devcontainer. With no env var it
+# falls back to the default ``test_netbox`` and behaves exactly like before.
+#
+# Use it via ``--settings=isolated_test_settings`` with this directory on PYTHONPATH
+# (the ``netbox-test-isolated`` helper in load-aliases.sh wires both up for you).
+import os as _os
+
+from netbox.settings import *  # noqa: F401,F403
+
+_name = _os.environ.get("TEST_DB_NAME")
+if _name:
+    DATABASES["default"].setdefault("TEST", {})["NAME"] = _name  # noqa: F405

.devcontainer/scripts/load-aliases.sh

@@ -123,6 +123,22 @@ netbox-test() {
   cd /opt/netbox/netbox && source /opt/netbox/venv/bin/activate && python manage.py test netbox_interface_name_rules "$@"
 }
 
+# Run tests on a per-session ISOLATED test database, so concurrent suites in the
+# shared devcontainer don't collide on test_netbox (which corrupts migrations and
+# can leave lock-holding zombie connections). Pass the app(s) + any test flags,
+# e.g.  netbox-test-isolated netbox_nso_plugin --keepdb
+# Override the DB name with TEST_DB_NAME=...; otherwise it's derived from the first
+# app argument (a stable name so --keepdb can reuse it).
+netbox-test-isolated() {
+  local first_app="netbox_interface_name_rules"
+  case "${1:-}" in -*|"") ;; *) first_app="$1" ;; esac
+  local db_name="${TEST_DB_NAME:-test_$(printf '%s' "$first_app" | tr -c 'a-zA-Z0-9' '_')}"
+  cd /opt/netbox/netbox && source /opt/netbox/venv/bin/activate && \
+    PYTHONPATH="$PLUGIN_DIR/.devcontainer/config${PYTHONPATH:+:$PYTHONPATH}" \
+    TEST_DB_NAME="$db_name" \
+    python manage.py test "$@" --settings=isolated_test_settings
+}
+
 netbox-manage() {
   cd /opt/netbox/netbox && source /opt/netbox/venv/bin/activate && python manage.py "$@"
 }
@@ -199,6 +215,7 @@ dev-help() {
   echo "🛠️  Development Tools:"
   echo "  netbox-shell        : Open NetBox Django shell"
   echo "  netbox-test         : Run plugin tests"
+  echo "  netbox-test-isolated: Run tests on a per-session isolated test DB (concurrency-safe)"
   echo "  netbox-manage       : Run Django management commands"
   echo "  plugin-install      : Reinstall plugin in development mode"
   echo ""

README.md

@@ -87,3 +87,30 @@ Apache 2.0
 See [CONTRIBUTING.md](CONTRIBUTING.md) for how to submit code or interface name rules.
 
 Community-contributed rules for various vendors are in the [`contrib/`](contrib/) directory.
+
+## Testing
+
+Inside the devcontainer:
+
+```bash
+netbox-test                 # run this plugin's tests (shared test_netbox DB)
+netbox-test-isolated <app> [flags]   # run on a per-session ISOLATED test DB
+```
+
+`netbox-test-isolated` is concurrency-safe: Django otherwise names the test
+database `test_<DB_NAME>` (`test_netbox`), so two `manage.py test` runs in the
+same devcontainer collide on one DB and corrupt each other's migrations (a
+crashed run can even leave an `idle in transaction` connection holding locks that
+wedges every later run). The helper points the test DB at a unique name —
+derived from the first app argument, or `TEST_DB_NAME=...` — via the
+[`isolated_test_settings`](.devcontainer/config/isolated_test_settings.py) shim
+(`--settings=isolated_test_settings` with `.devcontainer/config` on `PYTHONPATH`).
+Plain `netbox-test` keeps using the shared default (`test_netbox`);
+`netbox-test-isolated` instead derives a per-app DB name by default — `test_<app>`
+from the first app argument (this plugin when none is given) — unless you set
+`TEST_DB_NAME` explicitly. Example — test a sibling plugin without disturbing a
+parallel run:
+
+```bash
+netbox-test-isolated netbox_nso_plugin --keepdb
+```