refactor: extract PERM_VIEW_RULE constant for duplicated permission string

Author: marcinpsk

netbox_interface_name_rules/views.py

@@ -23,6 +23,8 @@
 
 logger = logging.getLogger(__name__)
 
+PERM_VIEW_RULE = "netbox_interface_name_rules.view_interfacenamerule"
+
 try:
     _plugins_config = getattr(settings, "PLUGINS_CONFIG", {})
     APPLY_BATCH_LIMIT = max(1, int(_plugins_config.get("netbox_interface_name_rules", {}).get("apply_batch_limit", 50)))
@@ -124,7 +126,7 @@ class InterfaceNameRuleYAMLExportView(BaseMultiObjectView):
 
     def get_required_permission(self):
         """Return the permission required to export rules."""
-        return "netbox_interface_name_rules.view_interfacenamerule"
+        return PERM_VIEW_RULE
 
     def _rules_to_yaml_data(self, queryset):
         """Return a list of dicts (one per rule) using import-form field names."""
@@ -178,7 +180,7 @@ def get(self, request):
         initial = {}
         loaded_rule = None
         rule_id = request.GET.get("rule_id")
-        can_view = request.user.has_perm("netbox_interface_name_rules.view_interfacenamerule")
+        can_view = request.user.has_perm(PERM_VIEW_RULE)
         if rule_id and not can_view:
             messages.warning(request, "You do not have permission to load an existing rule.")
         if rule_id and can_view:
@@ -260,7 +262,7 @@ def _handle_save_rule(self, request, cd):
         # Skip duplicate detection when the user lacks view permission — we cannot
         # query existing rules without it, so add-only users always land on the
         # create form (potentially allowing duplicates).
-        if request.user.has_perm("netbox_interface_name_rules.view_interfacenamerule"):
+        if request.user.has_perm(PERM_VIEW_RULE):
             existing = self._find_existing_rule(cd)
             if existing:
                 messages.info(
@@ -372,7 +374,7 @@ class RuleApplyListView(BaseMultiObjectView):
 
     def get_required_permission(self):
         """Return the permission required to access the apply-rules page."""
-        return "netbox_interface_name_rules.view_interfacenamerule"
+        return PERM_VIEW_RULE
 
     def get(self, request):
         """Render the list of all rules with apply/preview buttons."""