Skip to content

Commit 3fbc321

Browse files
committed
Revert "refactor: extract PERM_VIEW_RULE constant for duplicated permission string"
This reverts commit 304ce97.
1 parent 304ce97 commit 3fbc321

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

netbox_interface_name_rules/views.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323

2424
logger = logging.getLogger(__name__)
2525

26-
PERM_VIEW_RULE = "netbox_interface_name_rules.view_interfacenamerule"
27-
2826
try:
2927
_plugins_config = getattr(settings, "PLUGINS_CONFIG", {})
3028
APPLY_BATCH_LIMIT = max(1, int(_plugins_config.get("netbox_interface_name_rules", {}).get("apply_batch_limit", 50)))
@@ -126,7 +124,7 @@ class InterfaceNameRuleYAMLExportView(BaseMultiObjectView):
126124

127125
def get_required_permission(self):
128126
"""Return the permission required to export rules."""
129-
return PERM_VIEW_RULE
127+
return "netbox_interface_name_rules.view_interfacenamerule"
130128

131129
def _rules_to_yaml_data(self, queryset):
132130
"""Return a list of dicts (one per rule) using import-form field names."""
@@ -180,7 +178,7 @@ def get(self, request):
180178
initial = {}
181179
loaded_rule = None
182180
rule_id = request.GET.get("rule_id")
183-
can_view = request.user.has_perm(PERM_VIEW_RULE)
181+
can_view = request.user.has_perm("netbox_interface_name_rules.view_interfacenamerule")
184182
if rule_id and not can_view:
185183
messages.warning(request, "You do not have permission to load an existing rule.")
186184
if rule_id and can_view:
@@ -262,7 +260,7 @@ def _handle_save_rule(self, request, cd):
262260
# Skip duplicate detection when the user lacks view permission — we cannot
263261
# query existing rules without it, so add-only users always land on the
264262
# create form (potentially allowing duplicates).
265-
if request.user.has_perm(PERM_VIEW_RULE):
263+
if request.user.has_perm("netbox_interface_name_rules.view_interfacenamerule"):
266264
existing = self._find_existing_rule(cd)
267265
if existing:
268266
messages.info(
@@ -374,7 +372,7 @@ class RuleApplyListView(BaseMultiObjectView):
374372

375373
def get_required_permission(self):
376374
"""Return the permission required to access the apply-rules page."""
377-
return PERM_VIEW_RULE
375+
return "netbox_interface_name_rules.view_interfacenamerule"
378376

379377
def get(self, request):
380378
"""Render the list of all rules with apply/preview buttons."""

0 commit comments

Comments
 (0)