refactor: address review feedback on YAML export and test naming

- views.py: simplify _rules_to_yaml_data loop (single condition instead
  of if/elif); change Content-Type to standard 'application/yaml'
- tests/test_views.py: rename test_yaml_export_requires_login to
  test_yaml_export_unauthenticated_responds with accurate docstring
- .gitignore: add docs/superpowers/ (design specs are local-only)
- delete docs/superpowers/specs/ design spec from git history

Author: marcinpsk

.gitignore

@@ -60,3 +60,6 @@ site/
 
 # direnv
 .envrc
+
+# Brainstorming / design specs (local only, not for version control)
+docs/superpowers/

docs/superpowers/specs/2026-03-30-remove-module-path-plus-fixes-design.md

@@ -725,13 +725,12 @@ class YAMLExportViewTest(ViewTestBase):
 
     YAML_URL = "/plugins/interface-name-rules/rules/export/yaml/"
 
-    def test_yaml_export_requires_login(self):
-        """Unauthenticated request behaviour depends on LOGIN_REQUIRED setting.
+    def test_yaml_export_unauthenticated_responds(self):
+        """Unauthenticated GET must not return a server error (4xx or 2xx is acceptable).
 
-        ConditionalLoginRequiredMixin only enforces authentication when
-        LOGIN_REQUIRED=True (the default in production). In the test environment
-        LOGIN_REQUIRED may be False, so we just assert the view responds without
-        a server error rather than asserting a redirect.
+        ViewTestBase does not log in by default — this exercises anonymous access.
+        ConditionalLoginRequiredMixin enforces auth only when LOGIN_REQUIRED=True;
+        in the test environment that setting may be False, so 200 is also valid.
         """
         response = self.client.get(self.YAML_URL)
         self.assertIn(response.status_code, [200, 301, 302])

netbox_interface_name_rules/tests/test_views.py

@@ -124,20 +124,15 @@ def _rules_to_yaml_data(self, queryset):
         for rule in queryset.select_related("module_type", "parent_module_type", "device_type", "platform"):
             entry = {}
             for header, value in zip(InterfaceNameRule.csv_headers, rule.to_csv()):
-                # Omit empty/falsy optional fields to keep output readable,
-                # but always include required fields.
-                required = {"name_template"}
-                if value != "" and value is not None:
-                    entry[header] = value
-                elif header in required:
+                if value != "" and value is not None or header in {"name_template"}:
                     entry[header] = value
             records.append(entry)
         return records
 
     def _build_response(self, queryset):
         data = self._rules_to_yaml_data(queryset)
         content = yaml.dump(data, default_flow_style=False, allow_unicode=True, sort_keys=False)
-        response = HttpResponse(content, content_type="application/x-yaml; charset=utf-8")
+        response = HttpResponse(content, content_type="application/yaml; charset=utf-8")
         response["Content-Disposition"] = 'attachment; filename="interface_name_rules.yaml"'
         return response