Skip to content

fix: exempt standalone E2E/data-loading scripts and forced bump#20

Merged
marcinpsk merged 1 commit into
mainfrom
refactor/simplification
Mar 1, 2026
Merged

fix: exempt standalone E2E/data-loading scripts and forced bump#20
marcinpsk merged 1 commit into
mainfrom
refactor/simplification

Conversation

@marcinpsk

@marcinpsk marcinpsk commented Mar 1, 2026

Copy link
Copy Markdown
Owner

Forced bump due to missed PR title earlier not triggering release.

Summary by CodeRabbit

  • Chores
    • Updated development dependencies (testing, coverage, DB client and networking utilities).
    • Enhanced linting rules with additional checks and cyclomatic complexity limits; added per-file ignore exceptions for generated/scripts.
    • Refined pre-commit hook configuration to streamline and standardize quality checks.

@coderabbitai

coderabbitai Bot commented Mar 1, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 929dce1 and 34b384b.

📒 Files selected for processing (2)
  • .pre-commit-config.yaml
  • pyproject.toml

Walkthrough

Updates pre-commit hooks: replaces ruff with ruff-check, simplifies REUSE lint command, and adjusts hook args; adds dev dependencies and extends Ruff configuration (select W, C901; max-complexity = 15) with per-file C901 exemptions for two scripts in pyproject.toml.

Changes

Cohort / File(s) Summary
Pre-commit Hook Configuration
./.pre-commit-config.yaml
Replaced ruff hook id with ruff-check, kept ruff args (--fix, --exit-non-zero-on-fix), simplified REUSE lint invocation to reuse lint, and adjusted local reusable-lint entry.
Project Configuration
./pyproject.toml
Added dev-dependencies: pytest-cov>=6.0, django>=6.0.2, netaddr>=1.3.0, psycopg>=3.3.3; expanded Ruff select to include W and C901, set max-complexity = 15, and added per-file-ignores to suppress C901 for .devcontainer/scripts/test-e2e.py and .devcontainer/scripts/load-sample-data.py.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through hooks and tidy toml lines,

Ruff-check now guards our linting fines,
Complexity counted, some scripts set free,
Dev deps gathered for testing glee,
A carrot-shaped commit — clean and spry!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title mentions exempting E2E/data-loading scripts which aligns with the pyproject.toml changes (per-file-ignores for test-e2e.py and load-sample-data.py), but partially overlooks the significant .pre-commit-config.yaml updates (ruff-check hook changes).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/simplification

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@marcinpsk marcinpsk changed the title chore: exempt standalone E2E/data-loading scripts from C901 complexit… fix: exempt standalone E2E/data-loading scripts and forced bump Mar 1, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.pre-commit-config.yaml:
- Around line 27-31: The pre-commit hook for ruff (id: ruff-check) currently
sets language: system which bypasses the pinned rev (v0.15.4) and may cause
version drift; either remove the language: system line so pre-commit uses the
pinned rev v0.15.4 consistently, or if the intent is to use the system-installed
ruff, replace it with a one-line comment immediately above the ruff-check entry
stating that this is intentional and why (e.g., "Use system ruff to match dev
tooling managed by uv"); update only the ruff-check block referenced by id:
ruff-check to apply one of these two fixes.

ℹ️ Review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ccb6e38 and 929dce1.

📒 Files selected for processing (2)
  • .pre-commit-config.yaml
  • pyproject.toml

Comment thread .pre-commit-config.yaml Outdated
- pyproject.toml: add per-file C901 ignore for test-e2e.py and
  load-sample-data.py (standalone scripts where high CC is expected)
- .pre-commit-config.yaml: remove language/types/require_serial
  overrides from ruff-check (let pre-commit manage its own env);
  fix reuse-lint entry to use system reuse binary directly instead
  of uv run --no-sync which targeted .venv where reuse was absent
@marcinpsk marcinpsk force-pushed the refactor/simplification branch from 929dce1 to 34b384b Compare March 1, 2026 14:06
@sonarqubecloud

sonarqubecloud Bot commented Mar 1, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Mar 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@marcinpsk

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Mar 1, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@marcinpsk

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Mar 1, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@marcinpsk marcinpsk merged commit b0ecd29 into main Mar 1, 2026
17 checks passed
@marcinpsk marcinpsk deleted the refactor/simplification branch March 1, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant