Skip to content

Commit 7dc2469

Browse files
committed
roling back unnecessary abstraction
1 parent 1048336 commit 7dc2469

9 files changed

Lines changed: 24 additions & 19 deletions

File tree

src/Interfaces/TypeInterface.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@
99
*/
1010
interface TypeInterface
1111
{
12+
/**
13+
* @return TypeInterface
14+
*/
15+
public static function getType();
16+
1217
/**
1318
* Parses a type
1419
* @param string $value value to be processed

src/Types/AbstractType.php

Lines changed: 0 additions & 13 deletions
This file was deleted.

src/Types/ConcreteType.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,10 @@
44

55
use stdClass;
66
use ReflectionClass;
7+
use Minime\Annotations\Interfaces\TypeInterface;
78
use Minime\Annotations\ParserException;
89

9-
class ConcreteType extends AbstractType
10+
class ConcreteType implements TypeInterface
1011
{
1112
/**
1213
* @var TypeInterface

src/Types/DynamicType.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22

33
namespace Minime\Annotations\Types;
44

5-
class DynamicType extends AbstractType
5+
use Minime\Annotations\Interfaces\TypeInterface;
6+
7+
class DynamicType implements TypeInterface
68
{
79
/**
810
* @var TypeInterface

src/Types/FloatType.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22

33
namespace Minime\Annotations\Types;
44

5+
use Minime\Annotations\Interfaces\TypeInterface;
56
use Minime\Annotations\ParserException;
67

7-
class FloatType extends AbstractType
8+
class FloatType implements TypeInterface
89
{
910
/**
1011
* @var TypeInterface

src/Types/IntegerType.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22

33
namespace Minime\Annotations\Types;
44

5+
use Minime\Annotations\Interfaces\TypeInterface;
56
use Minime\Annotations\ParserException;
67

7-
class IntegerType extends AbstractType
8+
class IntegerType implements TypeInterface
89
{
910
/**
1011
* @var TypeInterface

src/Types/JsonType.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22

33
namespace Minime\Annotations\Types;
44

5+
use Minime\Annotations\Interfaces\TypeInterface;
56
use Minime\Annotations\ParserException;
67

7-
class JsonType extends AbstractType
8+
class JsonType implements TypeInterface
89
{
910
/**
1011
* @var TypeInterface

src/Types/StringType.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22

33
namespace Minime\Annotations\Types;
44

5-
class StringType extends AbstractType
5+
use Minime\Annotations\Interfaces\TypeInterface;
6+
7+
class StringType implements TypeInterface
68
{
79
/**
810
* @var TypeInterface

test/fixtures/FooType.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@
66

77
class FooType implements TypeInterface
88
{
9+
public static function getType()
10+
{
11+
return new FooType();
12+
}
13+
914
public function parse($value, $annotation = null)
1015
{
1116
return 'this foo is ' . $value;

0 commit comments

Comments
 (0)